From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 8CCB8986594 for ; Mon, 31 Jan 2022 14:26:43 +0000 (UTC) From: Cornelia Huck In-Reply-To: <20220131083927-mutt-send-email-mst@kernel.org> References: <87tudnzwq9.fsf@redhat.com> <20220128105012-mutt-send-email-mst@kernel.org> <20220130043917-mutt-send-email-mst@kernel.org> <20220130093740-mutt-send-email-mst@kernel.org> <20220130102940-mutt-send-email-mst@kernel.org> <87ilu0z2mc.fsf@redhat.com> <20220131083927-mutt-send-email-mst@kernel.org> Date: Mon, 31 Jan 2022 15:26:36 +0100 Message-ID: <87fsp4yo9v.fsf@redhat.com> MIME-Version: 1.0 Subject: [virtio-comment] Re: [PATCH v2 1/4] Add virtio Admin Virtqueue Content-Type: text/plain To: "Michael S. Tsirkin" Cc: Max Gurtovoy , Halil Pasic , Jason Wang , virtio-comment@lists.oasis-open.org, Virtio-Dev , Parav Pandit , Shahaf Shuler , Oren Duer , Stefan Hajnoczi List-ID: On Mon, Jan 31 2022, "Michael S. Tsirkin" wrote: > On Mon, Jan 31, 2022 at 10:16:43AM +0100, Cornelia Huck wrote: >> On Sun, Jan 30 2022, "Michael S. Tsirkin" wrote: >> >> > On Sun, Jan 30, 2022 at 05:12:46PM +0200, Max Gurtovoy wrote: >> >> #define VIRTIO_PCI_CAP_MISC_CFG 10 >> >> >> >> and >> >> >> >> struct virtio_pci_misc_cfg { >> >> le16 admin_queue_index; /* read-only for driver */ >> >> }; >> >> >> >> Is agreed by all for V3 ? instead of the net and blk AQ index definitions. >> > >> > We need to add it to MMIO and CCW I guess too. >> >> That seems ok for pci. >> >> For ccw, I'd do something like >> >> #define CCW_CMD_READ_MISC_CONF 0x82 >> >> struct virtio_misc_conf { >> be16 admin_queue_index; >> }; >> >> bound to revision 3, which gets a payload data containing the length of >> this structure (for future expansions). >> >> Halil, do you think that would work? >> >> For mmio, I'd need to think a bit more. Any mmio experts around? > > Not an expert but I think we can rely on a feature > bit to be acked since admin vq is only needed > after feature negotiation is complete. You mean a register that is valid conditionally? I don't see an easy way to add some kind of "misc" interface for mmio, unlike for the other transports. So something like: AdminQueueIndex/0x0c4/R If VIRTIO_F_ADMIN_VQ has been negotiated, reading from this register returns the queue index of the administration virtqueue. This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/