Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

[Markus Armbruster <armbru@redhat.com>]

Vladislav Yaroshchuk <yaroshchuk2000@gmail.com> writes:

> вт, 18 янв. 2022 г. в 18:01, Markus Armbruster <armbru@redhat.com>:
>
>> Vladislav Yaroshchuk <yaroshchuk2000@gmail.com> writes:
>>
>> > Create separate netdevs for each vmnet operating mode:
>> > - vmnet-host
>> > - vmnet-shared
>> > - vmnet-bridged
>> >
>> > Signed-off-by: Vladislav Yaroshchuk <yaroshchuk2000@gmail.com>
>>
>> I acked v8 of the QAPI schema part.  You should add Acked-by and
>> Reviewed-by you receive in later revisions, unless you make changes that
>> invalidate them.  When in doubt, drop them.
>>
>>
> Oh ok, I'll do that next time.

Thanks :)

>> > diff --git a/qapi/net.json b/qapi/net.json
>> > index 7fab2e7cd8..b922e2e34f 100644
>> > --- a/qapi/net.json
>> > +++ b/qapi/net.json
>> > @@ -452,6 +452,120 @@
>> >      '*vhostdev':     'str',
>> >      '*queues':       'int' } }
>> >
>> > +##
>> > +# @NetdevVmnetHostOptions:
>> > +#
>> > +# vmnet (host mode) network backend.
>> > +#
>> > +# Allows the vmnet interface to communicate with other vmnet
>> > +# interfaces that are in host mode and also with the host.
>> > +#
>> > +# @start-address: The starting IPv4 address to use for the interface.
>> > +#                 Must be in the private IP range (RFC 1918). Must be
>> > +#                 specified along with @end-address and @subnet-mask.
>> > +#                 This address is used as the gateway address. The
>> > +#                 subsequent address up to and including end-address are
>> > +#                 placed in the DHCP pool.
>> > +#
>> > +# @end-address: The DHCP IPv4 range end address to use for the
>> > +#               interface. Must be in the private IP range (RFC 1918).
>> > +#               Must be specified along with @start-address and
>> > +#               @subnet-mask.
>> > +#
>> > +# @subnet-mask: The IPv4 subnet mask to use on the interface. Must
>> > +#               be specified along with @start-address and @subnet-mask.
>> > +#
>> > +# @isolated: Enable isolation for this interface. Interface isolation
>> > +#            ensures that vmnet interface is not able to communicate
>> > +#            with any other vmnet interfaces. Only communication with
>> > +#            host is allowed. Available since macOS Big Sur 11.0.
>>
>> What happens when the host is too old?
>>
>>
> In this case netdev creation will fail with
> corresponding message (error_setg() used).

"Available" feels slightly misleading.  It's always available, it just
doesn't work unless the host OS is new enough.  Suggest something like
"Requires at least macOS Big Sur 11.0."

Same for the others.

QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>

[...]