From: Thomas Gleixner <tglx@linutronix.de>
To: Alexander Potapenko <glider@google.com>,
"Chang S. Bae" <chang.seok.bae@intel.com>,
Borislav Petkov <bp@suse.de>
Cc: Dmitriy Vyukov <dvyukov@google.com>,
Marco Elver <elver@google.com>,
Taras Madan <tarasmadan@google.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Potential information leak in save_xstate_epilog()
Date: Sat, 27 Nov 2021 21:26:04 +0100 [thread overview]
Message-ID: <87fsrhfiqr.ffs@tglx> (raw)
In-Reply-To: <CAG_fn=V9T6OKPonSjsi9PmWB0hMHFC=yawozdft8i1-MSxrv=w@mail.gmail.com>
On Fri, Nov 26 2021 at 12:06, Alexander Potapenko wrote:
> Hi Chang, Thomas, Borislav,
>
> "x86/fpu/signal: Prepare for variable sigframe length" has presumably
> introduced an information leak to the userspace.
>
> According to https://elixir.bootlin.com/linux/v5.16-rc2/source/arch/x86/kernel/fpu/signal.c#L126,
> save_sw_bytes() only initializes the first 20 bytes of sw_bytes, but
> then the whole struct is copied to the userspace.
Yes, that clearly lacks a memset(0).
Thanks,
tglx
next prev parent reply other threads:[~2021-11-27 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 11:06 Potential information leak in save_xstate_epilog() Alexander Potapenko
2021-11-27 20:26 ` Thomas Gleixner [this message]
2021-12-06 18:35 ` Bae, Chang Seok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsrhfiqr.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bp@suse.de \
--cc=chang.seok.bae@intel.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tarasmadan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.