From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACAAAC433F5 for ; Wed, 24 Nov 2021 09:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DTeGgMom/eI5+/xYPBbDXE9X14oee7DC/792hu25nOk=; b=qlL51hSvH2hgVa 2CoJ2SxKQePpSMSHIZH49SpVR//9/YPm3UWO33ptQEtiy/Lw2ESXedU81sHGJ6MknLVlLT9HrJ5J4 DZVxNLtX0pKGkVjxR7VW6Vv7jNgagN3bGbqZ+SJAmwDh78ndII0bGI0G3v8Mj6u5bB4DKZhtZpLSV /hN1hT6Lidct22zGYQeS417lEzxGkaEUswud1fyq5ncR3AFFogZvdY58i4sExSnsIZM9hI3+u/OZD sWHhRznrI2hS2khltMEisJ77JW2hVd2l3DxO2Who4xzZDdjinXO6U05KWvoxtPaROyMFQCMUVzH3f Ix/bMym1yuQHOeNveP9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpop6-004PyY-DS; Wed, 24 Nov 2021 09:44:16 +0000 Received: from m43-7.mailgun.net ([69.72.43.7]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpop3-004Ppk-IV for ath11k@lists.infradead.org; Wed, 24 Nov 2021 09:44:15 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1637747053; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=41o6sS1MLx/lIjXZseK5m7ONkaKla+cYhstE3GPbMAU=; b=c/eOSXKCUfhNnkQQkGyI9d/b8HWUxRnNuwDTfyh+KB1MGyftLtwD3gGSPZ+OyEbcMbE3TK2Q hEdahYkgx6hfuueTttT766zb+2nquZKmifnxGJCmiAvUifgTiYyPVe56J48xGBEvW9YT5MxW dGcRiR9tdcR74kzsStE0JypMoRs= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJmOGQ2ZiIsICJhdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 619e096d6bacc185a53678b4 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 24 Nov 2021 09:44:13 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 59C74C4360D; Wed, 24 Nov 2021 09:44:12 +0000 (UTC) Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D936EC4338F; Wed, 24 Nov 2021 09:44:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org D936EC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Mark Herbert Cc: Wen Gong , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2] ath11k: add read variant from SMBIOS for download board data References: <20211118100033.8384-1-quic_wgong@quicinc.com> <163759171706.17469.3004620526954131593.kvalo@codeaurora.org> <871r3883q9.fsf@codeaurora.org> Date: Wed, 24 Nov 2021 11:44:09 +0200 In-Reply-To: <871r3883q9.fsf@codeaurora.org> (Kalle Valo's message of "Mon, 22 Nov 2021 20:06:22 +0200") Message-ID: <87fsrl6g7q.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211124_014413_698566_9C72C7FD X-CRM114-Status: GOOD ( 13.94 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org S2FsbGUgVmFsbyA8a3ZhbG9AY29kZWF1cm9yYS5vcmc+IHdyaXRlczoKCj4gTWFyayBIZXJiZXJ0 IDxtYXJrLmhlcmJlcnQ0MkBnbWFpbC5jb20+IHdyaXRlczoKPgo+PiBUcmllZCB0aGlzIG9uIERl bGwgWFBTIDEzIDkzMTAKPj4KPj4gTWF5YmUgdGhpcyBwYXRjaCBpcyBnb29kIGZvciA2ODU1LCBi dXQgNjM5MCBpbiBEZWxsIHNlZW1zIHRvIGJlIGtpbGxlZAo+PiBjb21wbGV0ZWx5IHdpdGggaXQu IFJldmVydGluZyBpdCBtYWtlcyB0aGluZ3Mgd29yayBhZ2Fpbi4KPj4KPj4gW8KgwqDCoCA1LjUz NzAzNF0gYXRoMTFrX3BjaSAwMDAwOjcyOjAwLjA6IGNoaXBfaWQgMHgwIGNoaXBfZmFtaWx5IDB4 Ygo+PiBib2FyZF9pZCAweGZmIHNvY19pZCAweGZmZmZmZmZmCj4+IFvCoMKgwqAgNS41MzcwMzhd IGF0aDExa19wY2kgMDAwMDo3MjowMC4wOiBmd192ZXJzaW9uIDB4MTAxYzA2Y2MKPj4gZndfYnVp bGRfdGltZXN0YW1wIDIwMjAtMDYtMjQgMTk6NTAgZndfYnVpbGRfaWQKPj4gW8KgwqDCoCA1LjUz NzIzNl0gYXRoMTFrX3BjaSAwMDAwOjcyOjAwLjA6IGZhaWxlZCB0byBmZXRjaCBib2FyZCBkYXRh IGZvcgo+PiBidXM9cGNpLHFtaS1jaGlwLWlkPTAscW1pLWJvYXJkLWlkPTI1NSx2YXJpYW50PURF XzE5MDEgZnJvbQo+PiBhdGgxMWsvUUNBNjM5MC9odzIuMC9ib2FyZC0yLmJpbgo+PiBbwqDCoMKg IDUuNTM3MjU1XSBhdGgxMWtfcGNpIDAwMDA6NzI6MDAuMDogZmFpbGVkIHRvIGZldGNoIGJvYXJk LTIuYmluIG9yCj4+IGJvYXJkLmJpbiBmcm9tIFFDQTYzOTAvaHcyLjAKPj4gW8KgwqDCoCA1LjUz NzI1N10gYXRoMTFrX3BjaSAwMDAwOjcyOjAwLjA6IHFtaSBmYWlsZWQgdG8gZmV0Y2ggYm9hcmQg ZmlsZTogLTIKPj4gW8KgwqDCoCA1LjUzNzI1OF0gYXRoMTFrX3BjaSAwMDAwOjcyOjAwLjA6IGZh aWxlZCB0byBsb2FkIGJvYXJkIGRhdGEgZmlsZTogLTIKPgo+IERvaCwgSSBkaWRuJ3QgcmVhbGlz ZSB0aGF0LiBJIG9ubHkgdGVzdGVkIHRoaXMgb24gbXkgTlVDIHRlc3Rib3gsIEkKPiBzaG91bGQg aGF2ZSB0ZXN0ZWQgdGhpcyBvbiBteSBYUFMgMTMgOTMxMCBhcyB3ZWxsLiBUaGFua3MgZm9yIHRo ZQo+IHJlcG9ydCEKPgo+IEkgdGhpbmsgSSBuZWVkIHRvIHJldmVydCB0aGlzIGFuZCByZXRoaW5r IGhvdyB0byBoYW5kbGUgdGhlIGJhY2t3YXJkcwo+IGNvbXBhdGliaWxpdHkuCgpSZXZlcnQgc2Vu dDoKCmh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJvamVjdC9saW51eC13aXJlbGVzcy9w YXRjaC8yMDIxMTEyNDA5NDMxNi45MDk2LTEta3ZhbG9AY29kZWF1cm9yYS5vcmcvCgotLSAKaHR0 cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L2xpbnV4LXdpcmVsZXNzL2xpc3QvCgpo dHRwczovL3dpcmVsZXNzLndpa2kua2VybmVsLm9yZy9lbi9kZXZlbG9wZXJzL2RvY3VtZW50YXRp b24vc3VibWl0dGluZ3BhdGNoZXMKCi0tIAphdGgxMWsgbWFpbGluZyBsaXN0CmF0aDExa0BsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vYXRoMTFrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60BBAC433EF for ; Wed, 24 Nov 2021 09:44:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238370AbhKXJr0 (ORCPT ); Wed, 24 Nov 2021 04:47:26 -0500 Received: from m43-7.mailgun.net ([69.72.43.7]:51352 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238060AbhKXJrY (ORCPT ); Wed, 24 Nov 2021 04:47:24 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1637747055; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=41o6sS1MLx/lIjXZseK5m7ONkaKla+cYhstE3GPbMAU=; b=tVPJuSJl8fWTuz5eSaMxfyBIGO5eTgKhu9WYUvhLm0NrgekTbl7u9R+xE2f8CnkEeYW/L1nj O0uxjX/iCPKMNr3v661ABoWd/u0JkDLqdGh0FOFKzYAyIVOYaBY2YBjT+dQiCUwhaiKPVHOc Je8si5rP/VFKA8EbDVJY108R5yM= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 619e096c1abc6f02d09ac385 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 24 Nov 2021 09:44:12 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 95904C4360C; Wed, 24 Nov 2021 09:44:12 +0000 (UTC) Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D936EC4338F; Wed, 24 Nov 2021 09:44:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org D936EC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Mark Herbert Cc: Wen Gong , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2] ath11k: add read variant from SMBIOS for download board data References: <20211118100033.8384-1-quic_wgong@quicinc.com> <163759171706.17469.3004620526954131593.kvalo@codeaurora.org> <871r3883q9.fsf@codeaurora.org> Date: Wed, 24 Nov 2021 11:44:09 +0200 In-Reply-To: <871r3883q9.fsf@codeaurora.org> (Kalle Valo's message of "Mon, 22 Nov 2021 20:06:22 +0200") Message-ID: <87fsrl6g7q.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kalle Valo writes: > Mark Herbert writes: > >> Tried this on Dell XPS 13 9310 >> >> Maybe this patch is good for 6855, but 6390 in Dell seems to be killed >> completely with it. Reverting it makes things work again. >> >> [=C2=A0=C2=A0=C2=A0 5.537034] ath11k_pci 0000:72:00.0: chip_id 0x0 chip_= family 0xb >> board_id 0xff soc_id 0xffffffff >> [=C2=A0=C2=A0=C2=A0 5.537038] ath11k_pci 0000:72:00.0: fw_version 0x101c= 06cc >> fw_build_timestamp 2020-06-24 19:50 fw_build_id >> [=C2=A0=C2=A0=C2=A0 5.537236] ath11k_pci 0000:72:00.0: failed to fetch b= oard data for >> bus=3Dpci,qmi-chip-id=3D0,qmi-board-id=3D255,variant=3DDE_1901 from >> ath11k/QCA6390/hw2.0/board-2.bin >> [=C2=A0=C2=A0=C2=A0 5.537255] ath11k_pci 0000:72:00.0: failed to fetch b= oard-2.bin or >> board.bin from QCA6390/hw2.0 >> [=C2=A0=C2=A0=C2=A0 5.537257] ath11k_pci 0000:72:00.0: qmi failed to fet= ch board file: -2 >> [=C2=A0=C2=A0=C2=A0 5.537258] ath11k_pci 0000:72:00.0: failed to load bo= ard data file: -2 > > Doh, I didn't realise that. I only tested this on my NUC testbox, I > should have tested this on my XPS 13 9310 as well. Thanks for the > report! > > I think I need to revert this and rethink how to handle the backwards > compatibility. Revert sent: https://patchwork.kernel.org/project/linux-wireless/patch/20211124094316.90= 96-1-kvalo@codeaurora.org/ --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes