From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: chunkuang.hu@kernel.org, igt-dev@lists.freedesktop.org,
seanpaul@chromium.org, p.zabel@pengutronix.de,
matthias.bgg@gmail.com, Mark Yacoub <markyacoub@google.com>
Subject: Re: [igt-dev] [PATCH] tests/kms_cursor_legacy: Use igt_require_intel before get_reloc_ahnd
Date: Wed, 03 Nov 2021 18:42:58 -0700 [thread overview]
Message-ID: <87fsscd7bx.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <YYJjlvTGU25WMT2E@platvala-desk.ger.corp.intel.com>
On Wed, 03 Nov 2021 03:25:26 -0700, Petri Latvala wrote:
>
> > @@ -1327,6 +1333,7 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
> > igt_pipe_t *pipe_connected = &display->pipes[pipe];
> > igt_plane_t *plane_primary = igt_pipe_get_plane_type(pipe_connected, DRM_PLANE_TYPE_PRIMARY);
> > igt_crc_t crcs[2], test_crc;
> > + igt_require_intel(display->drm_fd);
> > uint64_t ahnd = get_reloc_ahnd(display->drm_fd, 0);
[76/1123] Compiling C object 'tests/59830eb@@kms_cursor_legacy@exe/kms_cursor_legacy.c.o'.
../tests/kms_cursor_legacy.c: In function ‘flip_vs_cursor_busy_crc’:
../tests/kms_cursor_legacy.c:1337:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
uint64_t ahnd = get_reloc_ahnd(display->drm_fd, 0);
^~~~~~~~
Should compile without warnings before merging.
prev parent reply other threads:[~2021-11-04 1:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 16:58 [igt-dev] [PATCH] tests/kms_cursor_legacy: Use igt_require_intel before get_reloc_ahnd Mark Yacoub
2021-11-01 17:18 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2021-11-01 17:43 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2021-11-01 19:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-11-03 10:25 ` [igt-dev] [PATCH] " Petri Latvala
2021-11-04 1:42 ` Dixit, Ashutosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsscd7bx.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=chunkuang.hu@kernel.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=markyacoub@google.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=petri.latvala@intel.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.