From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 46F9389FE8
 for <igt-dev@lists.freedesktop.org>; Mon, 18 Oct 2021 22:11:52 +0000 (UTC)
Date: Mon, 18 Oct 2021 15:11:31 -0700
Message-ID: <87fssy7zl8.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <784e8917-05cc-c5ed-ef98-dc21edda789b@linux.intel.com>
References: <20211015233845.12272-1-ashutosh.dixit@intel.com>
 <7fee0739-2ef5-f6c7-84fd-e73c9a8085f2@intel.com>
 <877deddfhs.wl-ashutosh.dixit@intel.com>
 <8d13e90a-04e8-47df-c2f5-a3afce04711a@intel.com>
 <784e8917-05cc-c5ed-ef98-dc21edda789b@linux.intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [PATCH i-g-t] lib/i915: Fix gem_has_execlists to
 match description
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: John Harrison <john.c.harrison@intel.com>, igt-dev@lists.freedesktop.org, Zbigniew Kempczynski <zbigniew.kempczynski@intel.com>
List-ID: <igt-dev@lists.freedesktop.org>

On Mon, 18 Oct 2021 00:43:10 -0700, Tvrtko Ursulin wrote:
>
> >>> Don't we use ring submission on older platforms?
> >> Hmm, I wasn't aware that there was yet another submission method :/
> >>
> >> So execlist submission is only available for gen >= 8 as the code says,
> >> in
> >> case anyone knows?
> > Yes. Execlists was new feature of the hardware not all that long ago
> > (ELSP and all that). Gen8 sounds plausible.
>
> Yes Gen8+.
>
> > Of course, it all depends why the code is asking the question? Does it
> > really need to know what the submission hardware is? Or is it actually
> > asking about the scheduling algorithm (as is the case for
> > gem_exec_fair). Or something else entirely? The scheduler question is
> > going to change again when we move to using the DRM scheduler instead of
> > our own private one in the execlist code. Currently though, I would
> > assume we use the execlist scheduler for ring submission but certainly
> > not for GuC submission (because the scheduler is in the hardware).
>
> Nope, no scheduling with ringbuffer backend.
>
> There is I915_PARAM_HAS_SCHEDULER and respective IGT helpers to query what
> kind of scheduling is supported on the device in question.
>
> It will be on a test per test basis why it is asking the question and what
> would be the appropriate test.

This patch is abandoned in favor of:

https://patchwork.freedesktop.org/series/95906/

Would it be possible to get a review on that? Thanks.