diff for duplicates of <87fswa2k93.fsf@linux.ibm.com> diff --git a/a/1.txt b/N1/1.txt index 15c6e02..0e17be7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -33,7 +33,7 @@ What about the pg.name from the previous iterations? > + > + pgs[idx].pg.name = kasprintf(GFP_KERNEL, "%lld", > + be64_to_cpu(esi_attrs[idx].id)); -> + if (pgs[idx].pg.name = NULL) { +> + if (pgs[idx].pg.name == NULL) { > + for (i = idx; i >= 0; i--) > + kfree(pgs[i].pg.attrs); @@ -45,7 +45,7 @@ You could just 'goto out_pgattrs' in both cases. > + } > + /* Do not add the value description if it does not exist */ > + if (strnlen(esi_attrs[idx].value_desc, -> + sizeof(esi_attrs[idx].value_desc)) = 0) +> + sizeof(esi_attrs[idx].value_desc)) == 0) > + show_val_desc = false; > + > + if (add_attr_group(be64_to_cpu(esi_attrs[idx].id), &pgs[idx], diff --git a/a/content_digest b/N1/content_digest index cb0eb00..be6f81c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020210719093250.41405-2-psampat@linux.ibm.com\0" "From\0Fabiano Rosas <farosas@linux.ibm.com>\0" "Subject\0Re: [PATCH v5 1/1] powerpc/pseries: Interface to represent PAPR firmware attributes\0" - "Date\0Mon, 19 Jul 2021 19:09:44 +0000\0" + "Date\0Mon, 19 Jul 2021 16:09:44 -0300\0" "To\0Pratik R. Sampat <psampat@linux.ibm.com>" mpe@ellerman.id.au benh@kernel.crashing.org @@ -49,7 +49,7 @@ "> +\n" "> +\t\tpgs[idx].pg.name = kasprintf(GFP_KERNEL, \"%lld\",\n" "> +\t\t\t\t\t be64_to_cpu(esi_attrs[idx].id));\n" - "> +\t\tif (pgs[idx].pg.name = NULL) {\n" + "> +\t\tif (pgs[idx].pg.name == NULL) {\n" "> +\t\t\tfor (i = idx; i >= 0; i--)\n" "> +\t\t\t\tkfree(pgs[i].pg.attrs);\n" "\n" @@ -61,7 +61,7 @@ "> +\t\t}\n" "> +\t\t/* Do not add the value description if it does not exist */\n" "> +\t\tif (strnlen(esi_attrs[idx].value_desc,\n" - "> +\t\t\t sizeof(esi_attrs[idx].value_desc)) = 0)\n" + "> +\t\t\t sizeof(esi_attrs[idx].value_desc)) == 0)\n" "> +\t\t\tshow_val_desc = false;\n" "> +\n" "> +\t\tif (add_attr_group(be64_to_cpu(esi_attrs[idx].id), &pgs[idx],\n" @@ -94,4 +94,4 @@ "> +\n" > +machine_device_initcall(pseries, papr_init); -fabdd4a7daf5aa723a6214c8c915d591374ed2480d796aa16d683ace2af86324 +be7b8b6e0b011d7f16be0903f01fe0afa54f26a454617e9fd62882906fd26c2c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.