All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: tytso@mit.edu, jaegeuk@kernel.org, dlatypov@google.com,
	kernel@collabora.com, linux-fsdevel@vger.kernel.org,
	kunit-dev@googlegroups.com
Subject: Re: [PATCH v2] unicode: Implement UTF-8 tests as a KUnit test
Date: Thu, 03 Jun 2021 13:55:05 -0400	[thread overview]
Message-ID: <87fsxyj0jq.fsf@collabora.com> (raw)
In-Reply-To: <20210602123234.3009423-1-ricardo.canuelo@collabora.com> ("Ricardo Cañuelo"'s message of "Wed, 2 Jun 2021 14:32:34 +0200")

Ricardo Cañuelo <ricardo.canuelo@collabora.com> writes:

> This translates the existing UTF-8 unit test module into a
> KUnit-compliant test suite. No functionality has been added or removed.
>
> Some names changed to make the file name, the Kconfig option and test
> suite name less specific, since this source file might hold more UTF-8
> tests in the future.
>
> Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
> [Fix checkpatch's complaint. Fix module build.
>  Add KUNIT_ALL_TESTS to kconfig]
> Co-developed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
> Acked-by: Daniel Latypov <dlatypov@google.com>
> ---
> Thanks for the review, Daniel.

Thanks for picking this up again Ricardo.

Acked-by: Gabriel Krisman Bertazi <krisman@collabora.com>

Ted, once ready, can you pick this up directly through your tree?

-- 
Gabriel Krisman Bertazi

      reply	other threads:[~2021-06-03 17:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 12:32 [PATCH v2] unicode: Implement UTF-8 tests as a KUnit test Ricardo Cañuelo
2021-06-03 17:55 ` Gabriel Krisman Bertazi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsxyj0jq.fsf@collabora.com \
    --to=krisman@collabora.com \
    --cc=dlatypov@google.com \
    --cc=jaegeuk@kernel.org \
    --cc=kernel@collabora.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ricardo.canuelo@collabora.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.