From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9B7CC47082 for ; Wed, 26 May 2021 14:38:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D6206108D for ; Wed, 26 May 2021 14:38:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D6206108D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B5FA6EDBE; Wed, 26 May 2021 14:38:04 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 22EE36EDA3; Wed, 26 May 2021 14:38:01 +0000 (UTC) IronPort-SDR: KWNmkJ1CM7Zmg8P2Lkwxr4o2gruB2eJVXF0B/1Uytb5VdX3IjDFxCvuInPuaUN6MmpjUg0EVln tM8dZw3sCDdw== X-IronPort-AV: E=McAfee;i="6200,9189,9996"; a="189857485" X-IronPort-AV: E=Sophos;i="5.82,331,1613462400"; d="scan'208";a="189857485" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2021 07:38:01 -0700 IronPort-SDR: 71E0ovy/GqX7eJCY2VdooB68HT3FQCbFmfiezQn9gjK2jtrNXaw6/RwMPiy8Fj/uxvgwxaMGQf HYwe7MJMOKBA== X-IronPort-AV: E=Sophos;i="5.82,331,1613462400"; d="scan'208";a="476968841" Received: from astiegle-mobl.ger.corp.intel.com (HELO localhost) ([10.252.54.167]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2021 07:37:58 -0700 From: Jani Nikula To: Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org In-Reply-To: <20210526141946.2347085-1-tvrtko.ursulin@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210526100006.2205062-1-tvrtko.ursulin@linux.intel.com> <20210526141946.2347085-1-tvrtko.ursulin@linux.intel.com> Date: Wed, 26 May 2021 17:37:54 +0300 Message-ID: <87fsy9blx9.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/params: Align visibility of device level and global modparams X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gV2VkLCAyNiBNYXkgMjAyMSwgVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGlu QGludGVsLmNvbT4KPgo+IFdlIGhhdmUgYSBmZXcgbW9kcGFyYW1zIHdoaWNoIGdldCBjb25kaXRp b25hbHkgZXhwb3NlZCBiYXNlZCBvbiBhIEtjb25maWcKPiBvcHRpb25zIGFuZCBpbiBtb3N0IGNh c2VzIHRoaXMgYWxzbyBtZWFucyBwb3J0aW9ucyBvZiB0aGUgZHJpdmVyCj4gaW1wbGVtZW50aW5n IHRoZSByZXNwZWN0aXZlIGZlYXR1cmUgYXJlIGFsc28gbGVmdCBvdXQuCj4KPiBBbGlnbiB0aGUg dmlzaWJpbGl0eSBvZiBkZXZpY2UgbGV2ZWwgYW5kIGdsb2JhbCBtb2RwYXJhbXMgdG8gbWFrZSB0 aGVtCj4gY29uc2lzdGVudCBpbiB0aGlzIHJlc3BlY3QuCj4KPiB2MjoKPiAgKiBGaXggbWlzcGxh Y2VkIHBhcmVudGhlc2VzLgo+Cj4gU2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRr by51cnN1bGluQGludGVsLmNvbT4KPiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVs LmNvbT4KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKSSdk IGhhcHBpbHkgYWNjZXB0IHBhdGNoZXMgcmVtb3Zpbmcgc29tZSBvZiB0aGUgbW9kdWxlIHBhcmFt cywgYW5kIGp1c3QKbGVhdmluZyB0aGUgZGVidWdmcyBkZXZpY2UgcGFyYW1zIGluIHBsYWNlLiA7 KQoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wYXJhbXMuaCB8IDggKysrKy0t LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BhcmFtcy5oIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9wYXJhbXMuaAo+IGluZGV4IDE0Y2Q2NGNjNjFkMC4uNGExMTRh NWFkMDAwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGFyYW1zLmgK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BhcmFtcy5oCj4gQEAgLTcxLDE4ICs3 MSwxOCBAQCBzdHJ1Y3QgZHJtX3ByaW50ZXI7Cj4gIAlwYXJhbShpbnQsIGZhc3Rib290LCAtMSwg MDYwMCkgXAo+ICAJcGFyYW0oaW50LCBlbmFibGVfZHBjZF9iYWNrbGlnaHQsIC0xLCAwNjAwKSBc Cj4gIAlwYXJhbShjaGFyICosIGZvcmNlX3Byb2JlLCBDT05GSUdfRFJNX0k5MTVfRk9SQ0VfUFJP QkUsIDA0MDApIFwKPiAtCXBhcmFtKHVuc2lnbmVkIGxvbmcsIGZha2VfbG1lbV9zdGFydCwgMCwg MDQwMCkgXAo+IC0JcGFyYW0odW5zaWduZWQgaW50LCByZXF1ZXN0X3RpbWVvdXRfbXMsIENPTkZJ R19EUk1fSTkxNV9SRVFVRVNUX1RJTUVPVVQsIDA2MDApIFwKPiArCXBhcmFtKHVuc2lnbmVkIGxv bmcsIGZha2VfbG1lbV9zdGFydCwgMCwgSVNfRU5BQkxFRChDT05GSUdfRFJNX0k5MTVfVU5TVEFC TEVfRkFLRV9MTUVNKSA/IDA0MDAgOiAwKSBcCj4gKwlwYXJhbSh1bnNpZ25lZCBpbnQsIHJlcXVl c3RfdGltZW91dF9tcywgQ09ORklHX0RSTV9JOTE1X1JFUVVFU1RfVElNRU9VVCwgQ09ORklHX0RS TV9JOTE1X1JFUVVFU1RfVElNRU9VVCA/IDA2MDAgOiAwKSBcCj4gIAkvKiBsZWF2ZSBib29scyBh dCB0aGUgZW5kIHRvIG5vdCBjcmVhdGUgaG9sZXMgKi8gXAo+ICAJcGFyYW0oYm9vbCwgZW5hYmxl X2hhbmdjaGVjaywgdHJ1ZSwgMDYwMCkgXAo+ICAJcGFyYW0oYm9vbCwgbG9hZF9kZXRlY3RfdGVz dCwgZmFsc2UsIDA2MDApIFwKPiAgCXBhcmFtKGJvb2wsIGZvcmNlX3Jlc2V0X21vZGVzZXRfdGVz dCwgZmFsc2UsIDA2MDApIFwKPiAtCXBhcmFtKGJvb2wsIGVycm9yX2NhcHR1cmUsIHRydWUsIDA2 MDApIFwKPiArCXBhcmFtKGJvb2wsIGVycm9yX2NhcHR1cmUsIHRydWUsIElTX0VOQUJMRUQoQ09O RklHX0RSTV9JOTE1X0NBUFRVUkVfRVJST1IpID8gMDYwMCA6IDApIFwKPiAgCXBhcmFtKGJvb2ws IGRpc2FibGVfZGlzcGxheSwgZmFsc2UsIDA0MDApIFwKPiAgCXBhcmFtKGJvb2wsIHZlcmJvc2Vf c3RhdGVfY2hlY2tzLCB0cnVlLCAwKSBcCj4gIAlwYXJhbShib29sLCBudWNsZWFyX3BhZ2VmbGlw LCBmYWxzZSwgMDQwMCkgXAo+ICAJcGFyYW0oYm9vbCwgZW5hYmxlX2RwX21zdCwgdHJ1ZSwgMDYw MCkgXAo+IC0JcGFyYW0oYm9vbCwgZW5hYmxlX2d2dCwgZmFsc2UsIDA0MDApCj4gKwlwYXJhbShi b29sLCBlbmFibGVfZ3Z0LCBmYWxzZSwgSVNfRU5BQkxFRChDT05GSUdfRFJNX0k5MTVfR1ZUKSA/ IDA0MDAgOiAwKQo+ICAKPiAgI2RlZmluZSBNRU1CRVIoVCwgbWVtYmVyLCAuLi4pIFQgbWVtYmVy Owo+ICBzdHJ1Y3QgaTkxNV9wYXJhbXMgewoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNv dXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B1F6C47088 for ; Wed, 26 May 2021 14:38:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FB866108D for ; Wed, 26 May 2021 14:38:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FB866108D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2ABBD6EDA3; Wed, 26 May 2021 14:38:04 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 22EE36EDA3; Wed, 26 May 2021 14:38:01 +0000 (UTC) IronPort-SDR: KWNmkJ1CM7Zmg8P2Lkwxr4o2gruB2eJVXF0B/1Uytb5VdX3IjDFxCvuInPuaUN6MmpjUg0EVln tM8dZw3sCDdw== X-IronPort-AV: E=McAfee;i="6200,9189,9996"; a="189857485" X-IronPort-AV: E=Sophos;i="5.82,331,1613462400"; d="scan'208";a="189857485" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2021 07:38:01 -0700 IronPort-SDR: 71E0ovy/GqX7eJCY2VdooB68HT3FQCbFmfiezQn9gjK2jtrNXaw6/RwMPiy8Fj/uxvgwxaMGQf HYwe7MJMOKBA== X-IronPort-AV: E=Sophos;i="5.82,331,1613462400"; d="scan'208";a="476968841" Received: from astiegle-mobl.ger.corp.intel.com (HELO localhost) ([10.252.54.167]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2021 07:37:58 -0700 From: Jani Nikula To: Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org Subject: Re: [PATCH v2] drm/i915/params: Align visibility of device level and global modparams In-Reply-To: <20210526141946.2347085-1-tvrtko.ursulin@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210526100006.2205062-1-tvrtko.ursulin@linux.intel.com> <20210526141946.2347085-1-tvrtko.ursulin@linux.intel.com> Date: Wed, 26 May 2021 17:37:54 +0300 Message-ID: <87fsy9blx9.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Tvrtko Ursulin Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 26 May 2021, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > We have a few modparams which get conditionaly exposed based on a Kconfig > options and in most cases this also means portions of the driver > implementing the respective feature are also left out. > > Align the visibility of device level and global modparams to make them > consistent in this respect. > > v2: > * Fix misplaced parentheses. > > Signed-off-by: Tvrtko Ursulin > Cc: Jani Nikula > Cc: Ville Syrj=C3=A4l=C3=A4 Reviewed-by: Jani Nikula I'd happily accept patches removing some of the module params, and just leaving the debugfs device params in place. ;) > --- > drivers/gpu/drm/i915/i915_params.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i9= 15_params.h > index 14cd64cc61d0..4a114a5ad000 100644 > --- a/drivers/gpu/drm/i915/i915_params.h > +++ b/drivers/gpu/drm/i915/i915_params.h > @@ -71,18 +71,18 @@ struct drm_printer; > param(int, fastboot, -1, 0600) \ > param(int, enable_dpcd_backlight, -1, 0600) \ > param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE, 0400) \ > - param(unsigned long, fake_lmem_start, 0, 0400) \ > - param(unsigned int, request_timeout_ms, CONFIG_DRM_I915_REQUEST_TIMEOUT= , 0600) \ > + param(unsigned long, fake_lmem_start, 0, IS_ENABLED(CONFIG_DRM_I915_UNS= TABLE_FAKE_LMEM) ? 0400 : 0) \ > + param(unsigned int, request_timeout_ms, CONFIG_DRM_I915_REQUEST_TIMEOUT= , CONFIG_DRM_I915_REQUEST_TIMEOUT ? 0600 : 0) \ > /* leave bools at the end to not create holes */ \ > param(bool, enable_hangcheck, true, 0600) \ > param(bool, load_detect_test, false, 0600) \ > param(bool, force_reset_modeset_test, false, 0600) \ > - param(bool, error_capture, true, 0600) \ > + param(bool, error_capture, true, IS_ENABLED(CONFIG_DRM_I915_CAPTURE_ERR= OR) ? 0600 : 0) \ > param(bool, disable_display, false, 0400) \ > param(bool, verbose_state_checks, true, 0) \ > param(bool, nuclear_pageflip, false, 0400) \ > param(bool, enable_dp_mst, true, 0600) \ > - param(bool, enable_gvt, false, 0400) > + param(bool, enable_gvt, false, IS_ENABLED(CONFIG_DRM_I915_GVT) ? 0400 := 0) >=20=20 > #define MEMBER(T, member, ...) T member; > struct i915_params { --=20 Jani Nikula, Intel Open Source Graphics Center