From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 904E0C2B9F8 for ; Tue, 25 May 2021 06:23:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 656AD610FC for ; Tue, 25 May 2021 06:23:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230224AbhEYGYy (ORCPT ); Tue, 25 May 2021 02:24:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22751 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230334AbhEYGYx (ORCPT ); Tue, 25 May 2021 02:24:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621923804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kJI9B3UDrsS5ZG82dGOTDBKrm8/JabWsy+34uznhI0Y=; b=NK4XKEtIoB2nQX1dfF0CIKAzeZ+eyIbLX6Rqztqwlq2GmEzKfM+xCluCSoF9nGAeJlBF7I 7sDBITSX9ydjgdKtvreFz6tLi8qXeRwNrSm4Qu8MOVCIByiuD9UANBMQFQXkNq1eNj79cs oe/VflAD+125acE63wx8G1tefobt/Lg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-f3EZyRjQMr-wEhQuqd_mYA-1; Tue, 25 May 2021 02:23:22 -0400 X-MC-Unique: f3EZyRjQMr-wEhQuqd_mYA-1 Received: by mail-wr1-f71.google.com with SMTP id g3-20020adfd1e30000b02901122a4b850aso6100411wrd.20 for ; Mon, 24 May 2021 23:23:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=kJI9B3UDrsS5ZG82dGOTDBKrm8/JabWsy+34uznhI0Y=; b=Sp2L5KMbLLQpy8idfATbFmqANJ+6rBdb4SOjt5uIV4/pvmPT/BGmX+o9G/ctBp0XXs 7Lt8G/MClLSanvsvuRTIowm3tgYQe9kRRNXmJJlNGYkh5HCNlb+HSpOOQukV6u6PPXYr vbCyOz+W9/aUOWf8oGTbwQNC/fvSHcUxhg5qWsOWCr/VzYg0g/3ln8FF1qWe0RdGMibg krJpG2K3JQ9cgzXsetgXPh+2rZlbXEvxM48RdJX9nw/sFDX9L53nVyp49lONSQMYZ2/k mg+F6Po7xgnPYeLRx/zMvLrEzeCxolj6ZO9vRkkSxFLHZQ6sgKn+aDLWhaFm6qW3zYix MFOg== X-Gm-Message-State: AOAM531Bk7wxq3UYPlX4Xk0mAax+YmVUkbldtASIwA+tlzC9IazkZvH0 VLBujhcscaWmzK6fL5a4tb1naeFHMQFlkHLWNGSaIznhmZ91R+ayR5YX+mWAGGKu/cJUOEue3n8 M7u7zvApHICCS X-Received: by 2002:adf:fd81:: with SMTP id d1mr25720244wrr.37.1621923801599; Mon, 24 May 2021 23:23:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5iZuU+Q62kXzDBukK4J7FbYpVjOGZNWnlJDEeNvhevYharSYKA5CYOQitXD6QBTBf/I26hA== X-Received: by 2002:adf:fd81:: with SMTP id d1mr25720236wrr.37.1621923801480; Mon, 24 May 2021 23:23:21 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id 61sm15690877wrm.52.2021.05.24.23.23.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 May 2021 23:23:20 -0700 (PDT) From: Vitaly Kuznetsov To: Paolo Bonzini , kvm@vger.kernel.org Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Maxim Levitsky , Kechen Lu , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] KVM: x86: hyper-v: Deactivate APICv only when AutoEOI feature is in use In-Reply-To: <82e2a6a0-337a-4b92-2271-493344a38960@redhat.com> References: <20210518144339.1987982-1-vkuznets@redhat.com> <20210518144339.1987982-6-vkuznets@redhat.com> <82e2a6a0-337a-4b92-2271-493344a38960@redhat.com> Date: Tue, 25 May 2021 08:23:19 +0200 Message-ID: <87fsyb8h7s.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Paolo Bonzini writes: > On 18/05/21 16:43, Vitaly Kuznetsov wrote: >> APICV_INHIBIT_REASON_HYPERV is currently unconditionally forced upon >> SynIC activation as SynIC's AutoEOI is incompatible with APICv/AVIC. It is, >> however, possible to track whether the feature was actually used by the >> guest and only inhibit APICv/AVIC when needed. >> >> TLFS suggests a dedicated 'HV_DEPRECATING_AEOI_RECOMMENDED' flag to let >> Windows know that AutoEOI feature should be avoided. While it's up to >> KVM userspace to set the flag, KVM can help a bit by exposing global >> APICv/AVIC enablement: in case APICv/AVIC usage is impossible, AutoEOI >> is still preferred. >> >> Signed-off-by: Vitaly Kuznetsov > > Should it also disable APICv unconditionally if > HV_DEPRECATING_AEOI_RECOMMENDED is not in the guest CPUID? That should > avoid ping-pong between enabled and disabled APICv even in pathological > cases that we cannot think about. When you run Hyper-V on KVM it doesn't use SynIC (let alone AutoEOI) but we still inhibit APICv unconditionally. The patch as-is improves this without any userspace changes required and I see it as a benefit. Going forward, we will definitely add something like 'hv-synic-noaeoi' to QEMU to make non-nesting setups benefit too but it'll take a while for this option to propagate to real world configurations (sigh). -- Vitaly