From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C92C433B4 for ; Wed, 28 Apr 2021 16:47:08 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 7689561412 for ; Wed, 28 Apr 2021 16:47:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7689561412 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DF4E24B26A; Wed, 28 Apr 2021 12:47:06 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FfUqHjMO7aEe; Wed, 28 Apr 2021 12:47:05 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 33C144B26D; Wed, 28 Apr 2021 12:47:05 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 323564B26A for ; Wed, 28 Apr 2021 12:47:03 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l1ZjDFQtRUrZ for ; Wed, 28 Apr 2021 12:47:01 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 2E8864B25D for ; Wed, 28 Apr 2021 12:47:01 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C79CA61412; Wed, 28 Apr 2021 16:46:59 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lbnKz-009tmL-H6; Wed, 28 Apr 2021 17:46:57 +0100 Date: Wed, 28 Apr 2021 17:46:56 +0100 Message-ID: <87fszanypr.wl-maz@kernel.org> From: Marc Zyngier To: Alex =?UTF-8?B?QmVubsOpZQ==?= Subject: Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants In-Reply-To: <87czues90k.fsf@linaro.org> References: <20210428101844.22656-1-alex.bennee@linaro.org> <20210428101844.22656-2-alex.bennee@linaro.org> <87fszasjdg.fsf@linaro.org> <996210ae-9c63-54ff-1a65-6dbd63da74d2@arm.com> <87k0omo4rr.wl-maz@kernel.org> <87czues90k.fsf@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: alex.bennee@linaro.org, alexandru.elisei@arm.com, kvm@vger.kernel.org, shashi.mallela@linaro.org, eric.auger@redhat.com, qemu-arm@nongnu.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, shashi.mallela@linaro.org, qemu-arm@nongnu.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gV2VkLCAyOCBBcHIgMjAyMSAxNjozNzo0NSArMDEwMCwKQWxleCBCZW5uw6llIDxhbGV4LmJl bm5lZUBsaW5hcm8ub3JnPiB3cm90ZToKPiAKPiAKPiBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwu b3JnPiB3cml0ZXM6Cj4gCj4gPiBPbiBXZWQsIDI4IEFwciAyMDIxIDE1OjAwOjE1ICswMTAwLAo+ ID4gQWxleGFuZHJ1IEVsaXNlaSA8YWxleGFuZHJ1LmVsaXNlaUBhcm0uY29tPiB3cm90ZToKPiA+ PiAKPiA+PiBJIGludGVycHJldCB0aGF0IGFzIHRoYXQgYW4gSU5WQUxMIGd1YXJhbnRlZXMgdGhh dCBhIGNoYW5nZSBpcwo+ID4+IHZpc2libGUsIGJ1dCBpdCB0aGUgY2hhbmdlIGNhbiBiZWNvbWUg dmlzaWJsZSBldmVuIHdpdGhvdXQgdGhlCj4gPj4gSU5WQUxMLgo+ID4KPiA+IFllcy4gRXhwZWN0 aW5nIHRoZSBMUEkgdG8gYmUgZGVsaXZlcmVkIG9yIG5vdCBpbiB0aGUgYWJzZW5jZSBvZiBhbgo+ ID4gaW52YWxpZGF0ZSB3aGVuIGl0cyBjb25maWd1cmF0aW9uIGhhcyBiZWVuIGFsdGVyZWQgaXMg d3JvbmcuIFRoZQo+ID4gYXJjaGl0ZWN0dXJlIGRvZXNuJ3QgZ3VhcmFudGVlIGFueXRoaW5nIG9m IHRoZSBzb3J0Lgo+IAo+IElzIHRoZSB1bmRlcmx5aW5nIGh5cGVydmlzb3IgYWxsb3dlZCB0byBp bnZhbGlkYXRlIGFuZCByZWxvYWQgdGhlCj4gY29uZmlndXJhdGlvbiB3aGVuZXZlciBpdCB3YW50 cyBvciBzaG91bGQgaXQgb25seSBiZSBkcml2ZW4gYnkgdGhlCj4gZ3Vlc3RzIHJlcXVlc3RzPwoK VGhlIEhXIGNhbiBkbyBpdCBhdCBhbnkgdGltZS4gSXQgYWxsIGRlcGVuZHMgb24gd2hldGhlciB0 aGUgUkQgaGFzCmNhY2hlZCB0aGlzIExQSSBjb25maWd1cmF0aW9uIG9yIG5vdC4gS1ZNIHJlbGll cyBvbiB0aGUgcmVxdWlyZWQKaW52YWxpZGF0aW9uIGFzIGEgaG9vayB0byByZWxvYWQgdGhlIGNh Y2hlZCBzdGF0ZSwgYXMgaXQgaGFzIGFuCmluZmluaXRlIExQSSBjb25maWd1cmF0aW9uIGNhY2hl LCB3aGlsZSBUQ0cgZG9lc24ndCBoYXZlIGEgY2FjaGUgYXQKYWxsLiBCb3RoIGFwcHJvYWNoZXMg YXJlIHZhbGlkIGltcGxlbWVudGF0aW9ucy4KCj4gSSBkaWQgY29uc2lkZXIgYSBtb3JlIG51YW5j ZWQgdmFyaWFudCBvZiB0aGUgdGVzdCB0aGF0IGFsbG93ZWQgZm9yIGEKPiBkZWxpdmVyeSBwcmUt aW52YWwgYW5kIGEgcGFzcyBmb3IgcG9zdC1pbnZhbCBhcyBsb25nIGFzIGl0IGhhZCBiZWVuCj4g ZGVsaXZlcmVkIG9uZSB3YXkgb3IgYW5vdGhlcjoKPiAKPiAtLTg8LS0tLS0tLS0tLS0tLS0tY3V0 IGhlcmUtLS0tLS0tLS0tLS0tLS1zdGFydC0tLS0tLS0tLS0tLS0+OC0tLQo+IG1vZGlmaWVkICAg YXJtL2dpYy5jCj4gQEAgLTM2LDYgKzM2LDcgQEAgc3RhdGljIHN0cnVjdCBnaWMgKmdpYzsKPiAg c3RhdGljIGludCBhY2tlZFtOUl9DUFVTXSwgc3B1cmlvdXNbTlJfQ1BVU107Cj4gIHN0YXRpYyBp bnQgaXJxX3NlbmRlcltOUl9DUFVTXSwgaXJxX251bWJlcltOUl9DUFVTXTsKPiAgc3RhdGljIGNw dW1hc2tfdCByZWFkeTsKPiArc3RhdGljIGJvb2wgdW5kZXJfdGNnOwo+ICAKPiAgc3RhdGljIHZv aWQgbnJfY3B1X2NoZWNrKGludCBucikKPiAgewo+IEBAIC02ODcsNiArNjg4LDcgQEAgc3RhdGlj IHZvaWQgdGVzdF9pdHNfdHJpZ2dlcih2b2lkKQo+ICAJc3RydWN0IGl0c19jb2xsZWN0aW9uICpj b2wzOwo+ICAJc3RydWN0IGl0c19kZXZpY2UgKmRldjIsICpkZXY3Owo+ICAJY3B1bWFza190IG1h c2s7Cj4gKwlib29sIGJlZm9yZSwgYWZ0ZXI7Cj4gIAo+ICAJaWYgKGl0c19zZXR1cDEoKSkKPiAg CQlyZXR1cm47Cj4gQEAgLTczNCwxNSArNzM2LDE3IEBAIHN0YXRpYyB2b2lkIHRlc3RfaXRzX3Ry aWdnZXIodm9pZCkKPiAgCS8qCj4gIAkgKiByZS1lbmFibGUgdGhlIExQSSBidXQgd2lsbGluZ2x5 IGRvIG5vdCBjYWxsIGludmFsbAo+ICAJICogc28gdGhlIGNoYW5nZSBpbiBjb25maWcgaXMgbm90 IHRha2VuIGludG8gYWNjb3VudC4KPiAtCSAqIFRoZSBMUEkgc2hvdWxkIG5vdCBoaXQKPiArCSAq IFRoZSBMUEkgc2hvdWxkIG5vdCBoaXQuIFRoaXMgZG9lcyBob3dldmVyIGRlcGVuZCBvbgoKVGhp cyBmaXJzdCBwb2ludCBpcyAqd3JvbmcqLiBGcm9tIHRoZSBhcmNoaXRlY3R1cmUgc3BlYzoKCjxx dW90ZT4KKiBBIGNoYW5nZSB0byB0aGUgTFBJIGNvbmZpZ3VyYXRpb24gaXMgbm90IGd1YXJhbnRl ZWQgdG8gYmUgdmlzaWJsZQogIHVudGlsIGFuIGFwcHJvcHJpYXRlIGludmFsaWRhdGlvbiBvcGVy YXRpb24gaGFzIGNvbXBsZXRlZDoKCiAgLSBJZiBvbmUgb3IgbW9yZSBJVFMgaXMgaW1wbGVtZW50 ZWQsIGludmFsaWRhdGlvbiBpcyBwZXJmb3JtZWQgdXNpbmcKICAgIHRoZSBJTlYgb3IgSU5WQUxM IGNvbW1hbmQuIEEgU1lOQyBjb21tYW5kIGNvbXBsZXRlcyB0aGUgSU5WIGFuZAogICAgSU5WQUxM IGNvbW1hbmRzLgo8L3F1b3RlPgoKKm5vdCBndWFyYW50ZWVkKiBtZWFucyB0aGF0IGl0IG1heSBm aXJlLCBpdCBtYXkgbm90LgoKPiArCSAqIGltcGxlbWVudGF0aW9uIGRlZmluZWQgYmVoYXZpb3Vy IC0gdW5kZXIgUUVNVSBUQ0cgZW11bGF0aW9uCj4gKwkgKiBpdCBjYW4gcXVpdGUgY29ycmVjdGx5 IHByb2Nlc3MgdGhlIGV2ZW50IGRpcmVjdGx5LgoKSSByZWFsbHkgZG9uJ3Qgc2VlIHRoZSBwb2lu dCBpbiB0ZXN0aW5nIElNUERFRiBiZWhhdmlvdXJzLiBXZSBzaG91bGQKdGVzdCBmb3IgYXJjaGl0 ZWN0dXJhbCBjb21wbGlhbmNlLCBub3QgZm9yIGltcGxlbWVudGF0aW9uIGNob2ljZXMuCgoJTS4K Ci0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9z c2libGUuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2 bWFybSBtYWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xp c3RzLmNzLmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:ee0d:0:0:0:0:0 with SMTP id g13csp796663lfb; Wed, 28 Apr 2021 09:47:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZlUAPot5DFAwU2nGbRBCKf9AL3D51NBL3XTUS5zuJb6Ut2gQSrAthhPPz0GNI/PU0F2Sk X-Received: by 2002:a17:90a:7d02:: with SMTP id g2mr4788799pjl.153.1619628420621; Wed, 28 Apr 2021 09:47:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619628420; cv=none; d=google.com; s=arc-20160816; b=1BKeD/jOxmQoYxoQcmV+IOvj+qBbpsdpzma5RLUleWfh/Wf6vSKalY9Kofk6ZV3JFX 3fGxaBMFOhWUuIzEkacw7prXYD8fP/u3bSJjVJi7VbspZ6N2tCqXuUMX2UmUr5UTFUWM VRMZTQ8KbNbgWAS/Yjd4uue3GST+qy5w3XGtvpE+/7So2CpT4IJahzYZUDAoZT9R3JEk 5wqPj3CRLnflNKdRTZ8p6TujsZLWfgCAMh6l5+CiAUAU4hfNnYDEi4wLVd13S87fO/A/ b/wiqZjbmUAyHL1JPQCoOO0O2xh8NO/wsfWSNx39vNHcxGOXVE3jQUmi8d9UotiJhcNH 2nzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date; bh=ZQg32vd6xhe/Pr7KqocU86t9K1HOkUnnXcb6VCCEMpg=; b=o/b20vvIAaYYaBKakGVVFOBvWWHgUYpGzvqYToUpjWg2yDFwsaFwzUt2sENHnFP43/ FOJwj2ZEhPHes0WPQ349Y4XdXDi5B455CM5CVk1eoVMZikINlojJDxM1PE6S+g7gNUEi f0iWs5WFM/rvpD4+EADnjyEpRLZt9qwhmaLI4CTpOyXdLbeSoA9m+we1kcAnP2TdZ/Tj gjhLfjoLTwxeVpCGaA5mO2EP4UA7tooeovPxuzEiGD8MW6yjUTML3fYKCCmPeMN79su5 uAjl8/AVvl8S+6w/df5BDyZL4wtOPZwlNgR8zBVNvpqisfVBKNHMWNGWpv7YI9Rt9ft/ HmKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of maz@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from mail.kernel.org (mail.kernel.org. [198.145.29.99]) by mx.google.com with ESMTPS id u13si103163plg.351.2021.04.28.09.47.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Apr 2021 09:47:00 -0700 (PDT) Received-SPF: pass (google.com: domain of maz@kernel.org designates 198.145.29.99 as permitted sender) client-ip=198.145.29.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of maz@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C79CA61412; Wed, 28 Apr 2021 16:46:59 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lbnKz-009tmL-H6; Wed, 28 Apr 2021 17:46:57 +0100 Date: Wed, 28 Apr 2021 17:46:56 +0100 Message-ID: <87fszanypr.wl-maz@kernel.org> From: Marc Zyngier To: Alex =?UTF-8?B?QmVubsOpZQ==?= Cc: Alexandru Elisei , kvm@vger.kernel.org, shashi.mallela@linaro.org, eric.auger@redhat.com, qemu-arm@nongnu.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@arm.com Subject: Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants In-Reply-To: <87czues90k.fsf@linaro.org> References: <20210428101844.22656-1-alex.bennee@linaro.org> <20210428101844.22656-2-alex.bennee@linaro.org> <87fszasjdg.fsf@linaro.org> <996210ae-9c63-54ff-1a65-6dbd63da74d2@arm.com> <87k0omo4rr.wl-maz@kernel.org> <87czues90k.fsf@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: alex.bennee@linaro.org, alexandru.elisei@arm.com, kvm@vger.kernel.org, shashi.mallela@linaro.org, eric.auger@redhat.com, qemu-arm@nongnu.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-TUID: sXFPAIT/sUke On Wed, 28 Apr 2021 16:37:45 +0100, Alex Benn=C3=A9e wrote: >=20 >=20 > Marc Zyngier writes: >=20 > > On Wed, 28 Apr 2021 15:00:15 +0100, > > Alexandru Elisei wrote: > >>=20 > >> I interpret that as that an INVALL guarantees that a change is > >> visible, but it the change can become visible even without the > >> INVALL. > > > > Yes. Expecting the LPI to be delivered or not in the absence of an > > invalidate when its configuration has been altered is wrong. The > > architecture doesn't guarantee anything of the sort. >=20 > Is the underlying hypervisor allowed to invalidate and reload the > configuration whenever it wants or should it only be driven by the > guests requests? The HW can do it at any time. It all depends on whether the RD has cached this LPI configuration or not. KVM relies on the required invalidation as a hook to reload the cached state, as it has an infinite LPI configuration cache, while TCG doesn't have a cache at all. Both approaches are valid implementations. > I did consider a more nuanced variant of the test that allowed for a > delivery pre-inval and a pass for post-inval as long as it had been > delivered one way or another: >=20 > --8<---------------cut here---------------start------------->8--- > modified arm/gic.c > @@ -36,6 +36,7 @@ static struct gic *gic; > static int acked[NR_CPUS], spurious[NR_CPUS]; > static int irq_sender[NR_CPUS], irq_number[NR_CPUS]; > static cpumask_t ready; > +static bool under_tcg; > =20 > static void nr_cpu_check(int nr) > { > @@ -687,6 +688,7 @@ static void test_its_trigger(void) > struct its_collection *col3; > struct its_device *dev2, *dev7; > cpumask_t mask; > + bool before, after; > =20 > if (its_setup1()) > return; > @@ -734,15 +736,17 @@ static void test_its_trigger(void) > /* > * re-enable the LPI but willingly do not call invall > * so the change in config is not taken into account. > - * The LPI should not hit > + * The LPI should not hit. This does however depend on This first point is *wrong*. From the architecture spec: * A change to the LPI configuration is not guaranteed to be visible until an appropriate invalidation operation has completed: - If one or more ITS is implemented, invalidation is performed using the INV or INVALL command. A SYNC command completes the INV and INVALL commands. *not guaranteed* means that it may fire, it may not. > + * implementation defined behaviour - under QEMU TCG emulation > + * it can quite correctly process the event directly. I really don't see the point in testing IMPDEF behaviours. We should test for architectural compliance, not for implementation choices. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35DA2C433B4 for ; Wed, 28 Apr 2021 16:50:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 876D26105A for ; Wed, 28 Apr 2021 16:50:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 876D26105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mrHWCeAx4LcBH+5RkYDT5KiWDKsrjLkUT9I8w8+YXhY=; b=QyNPBjYkSXM5iJ0ofPFL3++xM 25DQrywxydpU2tF7c4O84UXbMHe+AK2Eggwl31ZXoYTWDg9dbxkCKdTwlLUT+XXyaNgSGaCAmMpvy Y2xclDqsJLa3Tfb0JBj9cdp9f5ArqW/QffZcDsWiyYEtwVVzNLA5WUgbY8n71mYtLU3iHuyqvnYSm mTrQcVf1tfyZm9mjaE1JGmXFhHRb23rmAMAlX9FpIwpuxE+UNx8YcaXStGTIzr01Dw7ZN7vnfQwIq LENVU0938exMxXTzvxdce/sfaEj+Io3KN5oUdrnxCzl/UAhnORpWm2n5BEw/FKnjZfN+TzUhmxj9e vZxVJ6DOA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbnMI-003tJn-FB; Wed, 28 Apr 2021 16:48:19 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnL4-003swQ-Vj for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 16:47:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Subject:Cc:To:From: Message-ID:Date:Sender:Reply-To:Content-ID:Content-Description; bh=ZQg32vd6xhe/Pr7KqocU86t9K1HOkUnnXcb6VCCEMpg=; b=eOwqu/n1iC7UgKRoQtrCGT0z2b ByO45zuIbQFeAoqmUhUKjNdwpnCLCbMxBddVmx22Hkgb/ya9vNtSbVh+y6uY3cRZUoeqpO9b43la4 ECrcXmhLrHQHE4BtcFUPmew8RX+ercbS0YAfWbsn+g3dpnrWuxlr5pA9uQrGTfYYjaTKOrFe9lt8C MA8T5eUeplFspUlrxYrhvxg3hrwYtmHIqvpPYjvFf2RB2hnYt776wedDaKUWEUS1j5FOvywZJxZ+2 4SOK5lSI11vHd33Hx2zHnkaefMP2vY+nntFl4IIaTGfifbsE1noe6iD3H9hQS39JQ/ovLURXDJ3+y YYwEhfZw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbnL2-00020L-Ab for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 16:47:01 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C79CA61412; Wed, 28 Apr 2021 16:46:59 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lbnKz-009tmL-H6; Wed, 28 Apr 2021 17:46:57 +0100 Date: Wed, 28 Apr 2021 17:46:56 +0100 Message-ID: <87fszanypr.wl-maz@kernel.org> From: Marc Zyngier To: Alex =?UTF-8?B?QmVubsOpZQ==?= Cc: Alexandru Elisei , kvm@vger.kernel.org, shashi.mallela@linaro.org, eric.auger@redhat.com, qemu-arm@nongnu.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@arm.com Subject: Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants In-Reply-To: <87czues90k.fsf@linaro.org> References: <20210428101844.22656-1-alex.bennee@linaro.org> <20210428101844.22656-2-alex.bennee@linaro.org> <87fszasjdg.fsf@linaro.org> <996210ae-9c63-54ff-1a65-6dbd63da74d2@arm.com> <87k0omo4rr.wl-maz@kernel.org> <87czues90k.fsf@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: alex.bennee@linaro.org, alexandru.elisei@arm.com, kvm@vger.kernel.org, shashi.mallela@linaro.org, eric.auger@redhat.com, qemu-arm@nongnu.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_094700_463627_291714EE X-CRM114-Status: GOOD ( 30.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyOCBBcHIgMjAyMSAxNjozNzo0NSArMDEwMCwKQWxleCBCZW5uw6llIDxhbGV4LmJl bm5lZUBsaW5hcm8ub3JnPiB3cm90ZToKPiAKPiAKPiBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwu b3JnPiB3cml0ZXM6Cj4gCj4gPiBPbiBXZWQsIDI4IEFwciAyMDIxIDE1OjAwOjE1ICswMTAwLAo+ ID4gQWxleGFuZHJ1IEVsaXNlaSA8YWxleGFuZHJ1LmVsaXNlaUBhcm0uY29tPiB3cm90ZToKPiA+ PiAKPiA+PiBJIGludGVycHJldCB0aGF0IGFzIHRoYXQgYW4gSU5WQUxMIGd1YXJhbnRlZXMgdGhh dCBhIGNoYW5nZSBpcwo+ID4+IHZpc2libGUsIGJ1dCBpdCB0aGUgY2hhbmdlIGNhbiBiZWNvbWUg dmlzaWJsZSBldmVuIHdpdGhvdXQgdGhlCj4gPj4gSU5WQUxMLgo+ID4KPiA+IFllcy4gRXhwZWN0 aW5nIHRoZSBMUEkgdG8gYmUgZGVsaXZlcmVkIG9yIG5vdCBpbiB0aGUgYWJzZW5jZSBvZiBhbgo+ ID4gaW52YWxpZGF0ZSB3aGVuIGl0cyBjb25maWd1cmF0aW9uIGhhcyBiZWVuIGFsdGVyZWQgaXMg d3JvbmcuIFRoZQo+ID4gYXJjaGl0ZWN0dXJlIGRvZXNuJ3QgZ3VhcmFudGVlIGFueXRoaW5nIG9m IHRoZSBzb3J0Lgo+IAo+IElzIHRoZSB1bmRlcmx5aW5nIGh5cGVydmlzb3IgYWxsb3dlZCB0byBp bnZhbGlkYXRlIGFuZCByZWxvYWQgdGhlCj4gY29uZmlndXJhdGlvbiB3aGVuZXZlciBpdCB3YW50 cyBvciBzaG91bGQgaXQgb25seSBiZSBkcml2ZW4gYnkgdGhlCj4gZ3Vlc3RzIHJlcXVlc3RzPwoK VGhlIEhXIGNhbiBkbyBpdCBhdCBhbnkgdGltZS4gSXQgYWxsIGRlcGVuZHMgb24gd2hldGhlciB0 aGUgUkQgaGFzCmNhY2hlZCB0aGlzIExQSSBjb25maWd1cmF0aW9uIG9yIG5vdC4gS1ZNIHJlbGll cyBvbiB0aGUgcmVxdWlyZWQKaW52YWxpZGF0aW9uIGFzIGEgaG9vayB0byByZWxvYWQgdGhlIGNh Y2hlZCBzdGF0ZSwgYXMgaXQgaGFzIGFuCmluZmluaXRlIExQSSBjb25maWd1cmF0aW9uIGNhY2hl LCB3aGlsZSBUQ0cgZG9lc24ndCBoYXZlIGEgY2FjaGUgYXQKYWxsLiBCb3RoIGFwcHJvYWNoZXMg YXJlIHZhbGlkIGltcGxlbWVudGF0aW9ucy4KCj4gSSBkaWQgY29uc2lkZXIgYSBtb3JlIG51YW5j ZWQgdmFyaWFudCBvZiB0aGUgdGVzdCB0aGF0IGFsbG93ZWQgZm9yIGEKPiBkZWxpdmVyeSBwcmUt aW52YWwgYW5kIGEgcGFzcyBmb3IgcG9zdC1pbnZhbCBhcyBsb25nIGFzIGl0IGhhZCBiZWVuCj4g ZGVsaXZlcmVkIG9uZSB3YXkgb3IgYW5vdGhlcjoKPiAKPiAtLTg8LS0tLS0tLS0tLS0tLS0tY3V0 IGhlcmUtLS0tLS0tLS0tLS0tLS1zdGFydC0tLS0tLS0tLS0tLS0+OC0tLQo+IG1vZGlmaWVkICAg YXJtL2dpYy5jCj4gQEAgLTM2LDYgKzM2LDcgQEAgc3RhdGljIHN0cnVjdCBnaWMgKmdpYzsKPiAg c3RhdGljIGludCBhY2tlZFtOUl9DUFVTXSwgc3B1cmlvdXNbTlJfQ1BVU107Cj4gIHN0YXRpYyBp bnQgaXJxX3NlbmRlcltOUl9DUFVTXSwgaXJxX251bWJlcltOUl9DUFVTXTsKPiAgc3RhdGljIGNw dW1hc2tfdCByZWFkeTsKPiArc3RhdGljIGJvb2wgdW5kZXJfdGNnOwo+ICAKPiAgc3RhdGljIHZv aWQgbnJfY3B1X2NoZWNrKGludCBucikKPiAgewo+IEBAIC02ODcsNiArNjg4LDcgQEAgc3RhdGlj IHZvaWQgdGVzdF9pdHNfdHJpZ2dlcih2b2lkKQo+ICAJc3RydWN0IGl0c19jb2xsZWN0aW9uICpj b2wzOwo+ICAJc3RydWN0IGl0c19kZXZpY2UgKmRldjIsICpkZXY3Owo+ICAJY3B1bWFza190IG1h c2s7Cj4gKwlib29sIGJlZm9yZSwgYWZ0ZXI7Cj4gIAo+ICAJaWYgKGl0c19zZXR1cDEoKSkKPiAg CQlyZXR1cm47Cj4gQEAgLTczNCwxNSArNzM2LDE3IEBAIHN0YXRpYyB2b2lkIHRlc3RfaXRzX3Ry aWdnZXIodm9pZCkKPiAgCS8qCj4gIAkgKiByZS1lbmFibGUgdGhlIExQSSBidXQgd2lsbGluZ2x5 IGRvIG5vdCBjYWxsIGludmFsbAo+ICAJICogc28gdGhlIGNoYW5nZSBpbiBjb25maWcgaXMgbm90 IHRha2VuIGludG8gYWNjb3VudC4KPiAtCSAqIFRoZSBMUEkgc2hvdWxkIG5vdCBoaXQKPiArCSAq IFRoZSBMUEkgc2hvdWxkIG5vdCBoaXQuIFRoaXMgZG9lcyBob3dldmVyIGRlcGVuZCBvbgoKVGhp cyBmaXJzdCBwb2ludCBpcyAqd3JvbmcqLiBGcm9tIHRoZSBhcmNoaXRlY3R1cmUgc3BlYzoKCjxx dW90ZT4KKiBBIGNoYW5nZSB0byB0aGUgTFBJIGNvbmZpZ3VyYXRpb24gaXMgbm90IGd1YXJhbnRl ZWQgdG8gYmUgdmlzaWJsZQogIHVudGlsIGFuIGFwcHJvcHJpYXRlIGludmFsaWRhdGlvbiBvcGVy YXRpb24gaGFzIGNvbXBsZXRlZDoKCiAgLSBJZiBvbmUgb3IgbW9yZSBJVFMgaXMgaW1wbGVtZW50 ZWQsIGludmFsaWRhdGlvbiBpcyBwZXJmb3JtZWQgdXNpbmcKICAgIHRoZSBJTlYgb3IgSU5WQUxM IGNvbW1hbmQuIEEgU1lOQyBjb21tYW5kIGNvbXBsZXRlcyB0aGUgSU5WIGFuZAogICAgSU5WQUxM IGNvbW1hbmRzLgo8L3F1b3RlPgoKKm5vdCBndWFyYW50ZWVkKiBtZWFucyB0aGF0IGl0IG1heSBm aXJlLCBpdCBtYXkgbm90LgoKPiArCSAqIGltcGxlbWVudGF0aW9uIGRlZmluZWQgYmVoYXZpb3Vy IC0gdW5kZXIgUUVNVSBUQ0cgZW11bGF0aW9uCj4gKwkgKiBpdCBjYW4gcXVpdGUgY29ycmVjdGx5 IHByb2Nlc3MgdGhlIGV2ZW50IGRpcmVjdGx5LgoKSSByZWFsbHkgZG9uJ3Qgc2VlIHRoZSBwb2lu dCBpbiB0ZXN0aW5nIElNUERFRiBiZWhhdmlvdXJzLiBXZSBzaG91bGQKdGVzdCBmb3IgYXJjaGl0 ZWN0dXJhbCBjb21wbGlhbmNlLCBub3QgZm9yIGltcGxlbWVudGF0aW9uIGNob2ljZXMuCgoJTS4K Ci0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9z c2libGUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==