From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E93CC433E0 for ; Mon, 8 Feb 2021 21:09:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C88AE64E45 for ; Mon, 8 Feb 2021 21:09:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C88AE64E45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9DmY-0003sy-Of for qemu-devel@archiver.kernel.org; Mon, 08 Feb 2021 16:09:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l97Xe-0002eC-NM for qemu-devel@nongnu.org; Mon, 08 Feb 2021 09:29:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l97XN-00016E-PN for qemu-devel@nongnu.org; Mon, 08 Feb 2021 09:29:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612794551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Sfrl72HJNGh+a3RbfrAZXJPbve18Oy1IQBpqcjEqzx8=; b=Ixtal8T87cWynmIJKHFHP451OVoM0nV98Rx/tR7izZ1ae4Vo/y4fPQRMMQn1dEdwfgTVk4 arNxUviR6DaphbAe05fRlI43Dt7Xhvqo/R9rDDUFRMRaqYAH/Xo1mR0NIM8hoLDQQjC/Az td/2It9UOc03BudpjDf8m5lQNUG2gOI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-536-hKEc3u6uNlCdt5wYOvffNA-1; Mon, 08 Feb 2021 09:29:09 -0500 X-MC-Unique: hKEc3u6uNlCdt5wYOvffNA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F30C1803638 for ; Mon, 8 Feb 2021 14:29:05 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-115-51.ams2.redhat.com [10.36.115.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C436C60C04; Mon, 8 Feb 2021 14:29:05 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 43F65113865F; Mon, 8 Feb 2021 15:29:04 +0100 (CET) From: Markus Armbruster To: John Snow Subject: Re: [PATCH v5 08/15] qapi/introspect.py: Introduce preliminary tree typing References: <20210204003207.2856909-1-jsnow@redhat.com> <20210204003207.2856909-9-jsnow@redhat.com> Date: Mon, 08 Feb 2021 15:29:04 +0100 In-Reply-To: <20210204003207.2856909-9-jsnow@redhat.com> (John Snow's message of "Wed, 3 Feb 2021 19:32:00 -0500") Message-ID: <87ft264or3.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.57, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cleber Rosa , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > The types will be used in forthcoming patches to add typing. These types > describe the layout and structure of the objects passed to > _tree_to_qlit, but lack the power to describe annotations until the next > commit. > > Signed-off-by: John Snow > --- > scripts/qapi/introspect.py | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py > index 45231d2abc3..8e019b4a26a 100644 > --- a/scripts/qapi/introspect.py > +++ b/scripts/qapi/introspect.py > @@ -10,7 +10,13 @@ > See the COPYING file in the top-level directory. > """ > > -from typing import Optional > +from typing import ( > + Any, > + Dict, > + List, > + Optional, > + Union, > +) > > from .common import ( > c_name, > @@ -26,6 +32,28 @@ > ) > > > +# This module constructs a tree data structure that is used to > +# generate the introspection information for QEMU. It behaves similarly > +# to a JSON value. > +# > +# A complexity over JSON is that our values may or may not be annotated. > +# > +# Un-annotated values may be: > +# Scalar: str, bool, None. > +# Non-scalar: List, Dict > +# _value = Union[str, bool, None, Dict[str, TreeValue], List[TreeValue]] > +# > +# With optional annotations, the type of all values is: > +# TreeValue = Union[_value, Annotated[_value]] > +# > +# Sadly, mypy does not support recursive types, so we must approximate this. > +_stub = Any > +_scalar = Union[str, bool, None] > +_nonscalar = Union[Dict[str, _stub], List[_stub]] > +_value = Union[_scalar, _nonscalar] > +# TreeValue = TODO, in a forthcoming commit. > + > + > def _make_tree(obj, ifcond, comment=None): > extra = { > 'if': ifcond, We discussed the naming of these type aliases review of v4. v5 arrived before we reached a conclusion. That's okay. I'm still interested in finishing the discussion, of course.