From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33B7FC433E0 for ; Mon, 11 Jan 2021 13:34:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A8D321744 for ; Mon, 11 Jan 2021 13:34:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A8D321744 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyxLN-0007un-90 for qemu-devel@archiver.kernel.org; Mon, 11 Jan 2021 08:34:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyxKe-0007Nw-66 for qemu-devel@nongnu.org; Mon, 11 Jan 2021 08:34:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28321) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kyxKc-0006iV-4U for qemu-devel@nongnu.org; Mon, 11 Jan 2021 08:34:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610372040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NMXIS1K2iOC/PhMqYCGqywHNZf2ZrLkpiKr9kszRe1k=; b=ST2ZAiaKDiEU5yfr6yYuiQib8EYtpjgsW/aqT/GTciCfiaN0xK4hsXjv597CHW7sjo4qgm H2GTiq1eP7xYeVhUViI91a2VSfNGp588Ih9G4Oipq5N8UfozqLSXpFxSgsSGsIRrzQ8wrg hGsseszufc2VnClqlScWwfLj+CfRz0c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-259-riqN_cS3P-m8iXpgxsdsFg-1; Mon, 11 Jan 2021 08:33:59 -0500 X-MC-Unique: riqN_cS3P-m8iXpgxsdsFg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3E948144E1; Mon, 11 Jan 2021 13:33:57 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-172.ams2.redhat.com [10.36.112.172]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6AE3B10023AC; Mon, 11 Jan 2021 13:33:57 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 002CA11386A7; Mon, 11 Jan 2021 14:33:55 +0100 (CET) From: Markus Armbruster To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Subject: Re: [PATCH v14 1/7] Introduce yank feature References: <69934ceacfd33a7dfe53db145ecc630ad39ee47c.1609167865.git.lukasstraub2@web.de> Date: Mon, 11 Jan 2021 14:33:55 +0100 In-Reply-To: (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Mon, 4 Jan 2021 17:56:20 +0400") Message-ID: <87ft374myk.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Lukas Straub , "Daniel P. =?utf-8?Q?Berrang=C3=A9=5C?=" , qemu-block , Juan Quintela , qemu-devel , Max Reitz , Paolo Bonzini , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Marc-Andr=C3=A9 Lureau writes: > Hi > > On Mon, Dec 28, 2020 at 7:08 PM Lukas Straub wrote: > >> The yank feature allows to recover from hanging qemu by "yanking" >> at various parts. Other qemu systems can register themselves and >> multiple yank functions. Then all yank functions for selected >> instances can be called by the 'yank' out-of-band qmp command. >> Available instances can be queried by a 'query-yank' oob command. >> > > Looking at the changes and API usage, I wonder if it wouldn't have been > simpler to associate the yank function directly with the YankInstance > (removing the need for register/unregister functions - tracking the state > left to the callback). Have you tried that approach? If not, I could chec= k > if this idea would work. Considering we're at v14... would it make sense to commit the current approach, then explore the alternative approach on top? If yes, is v14 committable as is?