From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Phillip Wood <phillip.wood123@gmail.com>
Subject: Re: [PATCH v2 2/5] mailmap: switch to opaque struct
Date: Mon, 04 Jan 2021 16:17:16 +0100 [thread overview]
Message-ID: <87ft3gviir.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20210103211849.2691287-3-sandals@crustytoothpaste.net>
On Sun, Jan 03 2021, brian m. carlson wrote:
> -void clear_mailmap(struct string_list *map)
> +void clear_mailmap(struct mailmap *mailmap)
> {
> + struct string_list *map = mailmap->mailmap;
> debug_mm("mailmap: clearing %d entries...\n", map->nr);
Re my comment on 1/5 wouldn't it make more sense to use the new API
here:
- debug_mm("mailmap: clearing %d entries...\n", map->nr);
+ debug_mm("mailmap: clearing %u entries...\n", mailmap_entries(mailmap));
I changed %d to %u here, maybe we'd also want to do that earlier while
we're at it (not code you're changing):
- debug_mm("mailmap: removing entries for <%s>, with %d sub-entries\n",
+ debug_mm("mailmap: removing entries for <%s>, with %u sub-entries\n",
next prev parent reply other threads:[~2021-01-04 15:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 21:18 [PATCH v2 0/5] Hashed mailmap brian m. carlson
2021-01-03 21:18 ` [PATCH v2 1/5] mailmap: add a function to inspect the number of entries brian m. carlson
2021-01-04 15:14 ` Ævar Arnfjörð Bjarmason
2021-01-04 17:04 ` René Scharfe
2021-01-03 21:18 ` [PATCH v2 2/5] mailmap: switch to opaque struct brian m. carlson
2021-01-04 15:17 ` Ævar Arnfjörð Bjarmason [this message]
2021-01-03 21:18 ` [PATCH v2 3/5] t4203: add failing test for case-sensitive local-parts and names brian m. carlson
2021-01-03 21:18 ` [PATCH v2 4/5] mailmap: use case-sensitive comparisons for " brian m. carlson
2021-01-04 16:10 ` Ævar Arnfjörð Bjarmason
2021-01-06 0:46 ` Junio C Hamano
2021-01-12 14:08 ` Ævar Arnfjörð Bjarmason
2021-01-03 21:18 ` [PATCH v2 5/5] mailmap: support hashed entries in mailmaps brian m. carlson
2021-01-05 14:21 ` Ævar Arnfjörð Bjarmason
2021-01-06 0:24 ` brian m. carlson
2021-01-10 19:24 ` Ævar Arnfjörð Bjarmason
2021-01-10 21:26 ` brian m. carlson
2021-01-05 20:05 ` Junio C Hamano
2021-01-06 0:28 ` brian m. carlson
2021-01-06 1:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft3gviir.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.