From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85EF5C64E7B for ; Tue, 1 Dec 2020 13:29:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20B8220770 for ; Tue, 1 Dec 2020 13:29:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="QkkZneQ8"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="gn3xJ3yi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391127AbgLAN3h (ORCPT ); Tue, 1 Dec 2020 08:29:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391125AbgLAN3h (ORCPT ); Tue, 1 Dec 2020 08:29:37 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58919C0613CF; Tue, 1 Dec 2020 05:28:56 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1606829334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1YJRW59Yy59fUBwrYfLxtsF+fz7y5/bsfKwLhEMMwLw=; b=QkkZneQ8xwGX3u1ADdvLDl+jTbrRiew2RoZhQfnP2RV/XPHCyLM8IJ5uHBUgtGBK9TnYx5 4FaQ5XFpkNhDyG5N0g9d6ydepGNxMm5LiCQN0i9wWLBBTlFZfjVDbVm2XiqLj4sbn7soPl yWtKy92JfyaCsxW6ttUQChMf5IPEVOj4NMuiQw2CNMNtjLG9oeKbngCwB/ZMLuFRqqHsuc hjhfXHSICJHvHEf+YVlJ7Cxi84xCcuDd9QfmAaOXHVTF3XOHEIHjGMJY3X4x1MJiYs7mpd tk+8dB6WRxyJ2JG5DgAa03+cr3KVC5pIfGr0X+iZ6lUXOCImgYa7zC3aG8Ncag== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1606829334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1YJRW59Yy59fUBwrYfLxtsF+fz7y5/bsfKwLhEMMwLw=; b=gn3xJ3yiG4kyabDU1Ak6NGZPA+InzSnHjXocPnttQulDD8/gasYGRPjBl6VaUQtbSpZGkq iSAPphxGbQTt/mAA== To: Corentin Labbe , herbert@gondor.apana.org.au, mripard@kernel.org, wens@csie.org Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: crypto: sun4i-ss: error with kmap In-Reply-To: <20201201130102.GA23461@Red> References: <20201201130102.GA23461@Red> Date: Tue, 01 Dec 2020 14:28:54 +0100 Message-ID: <87ft4phcyx.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Dec 01 2020 at 14:01, Corentin Labbe wrote: > +[ 213.050152] ------------[ cut here ]------------ > +[ 213.050207] WARNING: CPU: 0 PID: 18430 at mm/highmem.c:581 kunmap_local_indexed+0x194/0x1d4 > +[ 213.050214] Modules linked in: sm4_generic authenc vmac xcbc hmac streebog_generic sm3_generic sha3_generic crct10dif_generic crct10dif_common seed rmd320 rmd256 rmd160 rmd128 cts lzo lzo_compress salsa20_generic camellia_generic fcrypt pcbc tgr192 anubis wp512 khazad tea michael_mic arc4 cast6_generic cast5_generic cast_common deflate zlib_deflate sha512_generic cfb ofb serpent_generic lrw twofish_generic twofish_common blowfish_generic blowfish_common md4 > +[ 213.050410] CPU: 0 PID: 18430 Comm: cryptsetup Not tainted 5.10.0-rc5-next-20201130-00059-gf7ecf0611042-dirty #242 > +[ 213.050416] Hardware name: Allwinner sun7i (A20) Family > +[ 213.050448] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > +[ 213.050465] [] (show_stack) from [] (dump_stack+0x98/0xac) > +[ 213.050479] [] (dump_stack) from [] (__warn+0xc0/0xd8) > +[ 213.050491] [] (__warn) from [] (warn_slowpath_fmt+0x64/0xc0) > +[ 213.050505] [] (warn_slowpath_fmt) from [] (kunmap_local_indexed+0x194/0x1d4) > +[ 213.050525] [] (kunmap_local_indexed) from [] (sg_miter_stop+0xb4/0x164) > +[ 213.050541] [] (sg_miter_stop) from [] (sg_miter_next+0xc/0xe4) > +[ 213.050560] [] (sg_miter_next) from [] (sun4i_ss_opti_poll+0x278/0x40c) > +[ 213.050575] [] (sun4i_ss_opti_poll) from [] (sun4i_ss_cipher_poll+0x4f4/0x5e4) > +[ 213.050590] [] (sun4i_ss_cipher_poll) from [] (crypto_skcipher_encrypt+0x38/0x5c) > +[ 213.050604] [] (crypto_skcipher_encrypt) from [] (xts_encrypt+0x8c/0xd4) > +[ 213.050617] [] (xts_encrypt) from [] (crypto_skcipher_encrypt+0x38/0x5c) > +[ 213.050631] [] (crypto_skcipher_encrypt) from [] (skcipher_recvmsg+0x364/0x43c) > +[ 213.050646] [] (skcipher_recvmsg) from [] (sock_read_iter+0xa8/0xf8) > +[ 213.050663] [] (sock_read_iter) from [] (vfs_read+0x2b8/0x2d8) > +[ 213.050676] [] (vfs_read) from [] (ksys_read+0xb0/0xe4) > +[ 213.050688] [] (ksys_read) from [] (ret_fast_syscall+0x0/0x58) > +[ 213.050695] Exception stack(0xc4d13fa8 to 0xc4d13ff0) > +[ 213.050707] 3fa0: 00000006 b6f084d0 00000006 b47ff000 00010000 00000000 > +[ 213.050718] 3fc0: 00000006 b6f084d0 00010000 00000003 00000030 beb6e9bc 00000010 beb6e9fc > +[ 213.050727] 3fe0: b6e3609c beb6e958 b6cc8504 b6cc851c > +[ 213.050735] ---[ end trace 915906e6b0e8a55d ]--- Hmm. No registers there. Can you apply the patch below so we can see the address? Thanks, tglx --- diff --git a/mm/highmem.c b/mm/highmem.c index b49364a306b8..240fc6e5bfb4 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -571,8 +571,10 @@ void kunmap_local_indexed(void *vaddr) * PAGE_OFFSET. Warn for all other addresses which are in * the user space part of the virtual address space. */ - if (!kmap_high_unmap_local(addr)) + if (!kmap_high_unmap_local(addr)) { + pr_err("kunmap_local: vaddr %lx\n", (unsigned long) vaddr); WARN_ON_ONCE(addr < PAGE_OFFSET); + } return; } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A26A8C64E7B for ; Tue, 1 Dec 2020 13:30:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FDC820770 for ; Tue, 1 Dec 2020 13:30:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TuxDW8b7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="QkkZneQ8"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="gn3xJ3yi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FDC820770 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7O2fHHHn4GeearZMzHMuNhvTUi8MhQhH/DH8c+LFHfw=; b=TuxDW8b773e/y1LFRaDfV8jSi uQGDIxcpC/gD8rxr8ggd8xZIxH+odI/Z5vMaHr1I9KZD66Xy2l8Q8SCOYoxToyoBj9jTUklOBigt+ zpASVAFySHga2eDSVvOHVJTpvjKKbwu5OVGFaI1fN5s+d4dU22LBmnyWmSIaHt1ySz4zzjNjbKx/g y7MzemoDI2eEYJXdHcokv3KcEorKf/xqJj+IKpCiUegi4TKJF3qbksJReL7Ept5kqBTAC1XNIMDUT ST6P21JdFW9U2QGn25A+hW7ks9Odxa0wf3iKTnFmGYX1VX5CWyLoL0PAkSQcJbARDvHYuO4MgxXJo 3M9hn3/RQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk5iG-0005I4-7o; Tue, 01 Dec 2020 13:29:00 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk5iD-0005H9-BB for linux-arm-kernel@lists.infradead.org; Tue, 01 Dec 2020 13:28:58 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1606829334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1YJRW59Yy59fUBwrYfLxtsF+fz7y5/bsfKwLhEMMwLw=; b=QkkZneQ8xwGX3u1ADdvLDl+jTbrRiew2RoZhQfnP2RV/XPHCyLM8IJ5uHBUgtGBK9TnYx5 4FaQ5XFpkNhDyG5N0g9d6ydepGNxMm5LiCQN0i9wWLBBTlFZfjVDbVm2XiqLj4sbn7soPl yWtKy92JfyaCsxW6ttUQChMf5IPEVOj4NMuiQw2CNMNtjLG9oeKbngCwB/ZMLuFRqqHsuc hjhfXHSICJHvHEf+YVlJ7Cxi84xCcuDd9QfmAaOXHVTF3XOHEIHjGMJY3X4x1MJiYs7mpd tk+8dB6WRxyJ2JG5DgAa03+cr3KVC5pIfGr0X+iZ6lUXOCImgYa7zC3aG8Ncag== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1606829334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1YJRW59Yy59fUBwrYfLxtsF+fz7y5/bsfKwLhEMMwLw=; b=gn3xJ3yiG4kyabDU1Ak6NGZPA+InzSnHjXocPnttQulDD8/gasYGRPjBl6VaUQtbSpZGkq iSAPphxGbQTt/mAA== To: Corentin Labbe , herbert@gondor.apana.org.au, mripard@kernel.org, wens@csie.org Subject: Re: crypto: sun4i-ss: error with kmap In-Reply-To: <20201201130102.GA23461@Red> References: <20201201130102.GA23461@Red> Date: Tue, 01 Dec 2020 14:28:54 +0100 Message-ID: <87ft4phcyx.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201201_082857_540443_F4C28029 X-CRM114-Status: GOOD ( 10.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 01 2020 at 14:01, Corentin Labbe wrote: > +[ 213.050152] ------------[ cut here ]------------ > +[ 213.050207] WARNING: CPU: 0 PID: 18430 at mm/highmem.c:581 kunmap_local_indexed+0x194/0x1d4 > +[ 213.050214] Modules linked in: sm4_generic authenc vmac xcbc hmac streebog_generic sm3_generic sha3_generic crct10dif_generic crct10dif_common seed rmd320 rmd256 rmd160 rmd128 cts lzo lzo_compress salsa20_generic camellia_generic fcrypt pcbc tgr192 anubis wp512 khazad tea michael_mic arc4 cast6_generic cast5_generic cast_common deflate zlib_deflate sha512_generic cfb ofb serpent_generic lrw twofish_generic twofish_common blowfish_generic blowfish_common md4 > +[ 213.050410] CPU: 0 PID: 18430 Comm: cryptsetup Not tainted 5.10.0-rc5-next-20201130-00059-gf7ecf0611042-dirty #242 > +[ 213.050416] Hardware name: Allwinner sun7i (A20) Family > +[ 213.050448] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > +[ 213.050465] [] (show_stack) from [] (dump_stack+0x98/0xac) > +[ 213.050479] [] (dump_stack) from [] (__warn+0xc0/0xd8) > +[ 213.050491] [] (__warn) from [] (warn_slowpath_fmt+0x64/0xc0) > +[ 213.050505] [] (warn_slowpath_fmt) from [] (kunmap_local_indexed+0x194/0x1d4) > +[ 213.050525] [] (kunmap_local_indexed) from [] (sg_miter_stop+0xb4/0x164) > +[ 213.050541] [] (sg_miter_stop) from [] (sg_miter_next+0xc/0xe4) > +[ 213.050560] [] (sg_miter_next) from [] (sun4i_ss_opti_poll+0x278/0x40c) > +[ 213.050575] [] (sun4i_ss_opti_poll) from [] (sun4i_ss_cipher_poll+0x4f4/0x5e4) > +[ 213.050590] [] (sun4i_ss_cipher_poll) from [] (crypto_skcipher_encrypt+0x38/0x5c) > +[ 213.050604] [] (crypto_skcipher_encrypt) from [] (xts_encrypt+0x8c/0xd4) > +[ 213.050617] [] (xts_encrypt) from [] (crypto_skcipher_encrypt+0x38/0x5c) > +[ 213.050631] [] (crypto_skcipher_encrypt) from [] (skcipher_recvmsg+0x364/0x43c) > +[ 213.050646] [] (skcipher_recvmsg) from [] (sock_read_iter+0xa8/0xf8) > +[ 213.050663] [] (sock_read_iter) from [] (vfs_read+0x2b8/0x2d8) > +[ 213.050676] [] (vfs_read) from [] (ksys_read+0xb0/0xe4) > +[ 213.050688] [] (ksys_read) from [] (ret_fast_syscall+0x0/0x58) > +[ 213.050695] Exception stack(0xc4d13fa8 to 0xc4d13ff0) > +[ 213.050707] 3fa0: 00000006 b6f084d0 00000006 b47ff000 00010000 00000000 > +[ 213.050718] 3fc0: 00000006 b6f084d0 00010000 00000003 00000030 beb6e9bc 00000010 beb6e9fc > +[ 213.050727] 3fe0: b6e3609c beb6e958 b6cc8504 b6cc851c > +[ 213.050735] ---[ end trace 915906e6b0e8a55d ]--- Hmm. No registers there. Can you apply the patch below so we can see the address? Thanks, tglx --- diff --git a/mm/highmem.c b/mm/highmem.c index b49364a306b8..240fc6e5bfb4 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -571,8 +571,10 @@ void kunmap_local_indexed(void *vaddr) * PAGE_OFFSET. Warn for all other addresses which are in * the user space part of the virtual address space. */ - if (!kmap_high_unmap_local(addr)) + if (!kmap_high_unmap_local(addr)) { + pr_err("kunmap_local: vaddr %lx\n", (unsigned long) vaddr); WARN_ON_ONCE(addr < PAGE_OFFSET); + } return; } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel