From: Jakub Sitnicki <jakub@cloudflare.com>
To: John Fastabend <john.fastabend@gmail.com>
Cc: daniel@iogearbox.net, netdev@vger.kernel.org,
bpf@vger.kernel.org, ast@kernel.org
Subject: Re: [PATCH 0/2] sockmap, fix for some error paths with helpers
Date: Tue, 05 May 2020 11:30:14 +0200 [thread overview]
Message-ID: <87ftcevie1.fsf@cloudflare.com> (raw)
In-Reply-To: <158861271707.14306.15853815339036099229.stgit@john-Precision-5820-Tower>
On Mon, May 04, 2020 at 07:21 PM CEST, John Fastabend wrote:
> In these two cases sk_msg layout was getting confused with some helper
> sequences.
>
> I found these while cleaning up test_sockmap to do a better job covering
> the different scenarios. Those patches will go to bpf-next and include
> tests that cover these two cases.
>
> ---
>
> John Fastabend (2):
> bpf: sockmap, msg_pop_data can incorrecty set an sge length
> bpf: sockmap, bpf_tcp_ingress needs to subtract bytes from sg.size
Both of these LGTM. Looking forward to revamped test_sockmap.
For the series:
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
next prev parent reply other threads:[~2020-05-05 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 17:21 [PATCH 0/2] sockmap, fix for some error paths with helpers John Fastabend
2020-05-04 17:21 ` [PATCH 1/2] bpf: sockmap, msg_pop_data can incorrecty set an sge length John Fastabend
2020-05-05 18:59 ` Martin KaFai Lau
2020-05-04 17:21 ` [PATCH 2/2] bpf: sockmap, bpf_tcp_ingress needs to subtract bytes from sg.size John Fastabend
2020-05-05 19:05 ` Martin KaFai Lau
2020-05-05 9:30 ` Jakub Sitnicki [this message]
2020-05-05 22:28 ` [PATCH 0/2] sockmap, fix for some error paths with helpers Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftcevie1.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.