From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v13 01/11] drm/i915: Use 64-bit division macro Date: Fri, 24 Apr 2020 09:17:58 +0300 Message-ID: <87ftctbe5l.fsf@intel.com> References: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: Received: from mga02.intel.com ([134.134.136.20]:24165 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbgDXGSF (ORCPT ); Fri, 24 Apr 2020 02:18:05 -0400 In-Reply-To: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: linux-pwm@vger.kernel.org Cc: Guru Das Srinagesh , David Collins , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Wilson , Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6ni?= =?utf-8?Q?g?= , Subbaraman Narayanamurthy On Tue, 21 Apr 2020, Guru Das Srinagesh wrote: > Since the PWM framework is switching struct pwm_state.duty_cycle's > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL > to handle a 64-bit dividend. > > To: Jani Nikula > Cc: Joonas Lahtinen > Cc: David Airlie > Cc: Daniel Vetter > Cc: Chris Wilson > Cc: "Ville Syrjälä" > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Superfluous blank line. Anyway, please preserve the existing acks and reviews [1] so people don't have to do it again. BR, Jani. [1] http://lore.kernel.org/r/87h7yleb0i.fsf@intel.com > Signed-off-by: Guru Das Srinagesh > --- > drivers/gpu/drm/i915/display/intel_panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c > index 276f438..81547a0 100644 > --- a/drivers/gpu/drm/i915/display/intel_panel.c > +++ b/drivers/gpu/drm/i915/display/intel_panel.c > @@ -1920,7 +1920,7 @@ static int pwm_setup_backlight(struct intel_connector *connector, > return retval; > } > > - level = DIV_ROUND_UP(pwm_get_duty_cycle(panel->backlight.pwm) * 100, > + level = DIV_ROUND_UP_ULL(pwm_get_duty_cycle(panel->backlight.pwm) * 100, > CRC_PMIC_PWM_PERIOD_NS); > panel->backlight.level = > intel_panel_compute_brightness(connector, level); -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 376EBC5518A for ; Fri, 24 Apr 2020 06:18:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1935120700 for ; Fri, 24 Apr 2020 06:18:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1935120700 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1469C6E43F; Fri, 24 Apr 2020 06:18:07 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B1436E42F; Fri, 24 Apr 2020 06:18:06 +0000 (UTC) IronPort-SDR: IUbAsSqGloiCzdYb4mIfBDQXbJ8yDBm+AkZ01n34GoS4g0hNPzeS3EeDwyJ4BE5xCPWRw7Qa1o OjJ7ASSSZm8g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 23:18:05 -0700 IronPort-SDR: CMMh7MOlW2PHOf69i2rCxZUoGQjBYXzGWUKRrghXshWnbMa4J890SrsF0POzKmQwBnpobtHclZ 6P4wnWvYB6hA== X-IronPort-AV: E=Sophos;i="5.73,310,1583222400"; d="scan'208";a="430652200" Received: from khelzel-mobl.ger.corp.intel.com (HELO localhost) ([10.252.52.65]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 23:18:00 -0700 From: Jani Nikula To: Guru Das Srinagesh , linux-pwm@vger.kernel.org Subject: Re: [PATCH v13 01/11] drm/i915: Use 64-bit division macro In-Reply-To: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> Date: Fri, 24 Apr 2020 09:17:58 +0300 Message-ID: <87ftctbe5l.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guru Das Srinagesh , David Collins , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Wilson , Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6ni?= =?utf-8?Q?g?= , Subbaraman Narayanamurthy Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCAyMSBBcHIgMjAyMCwgR3VydSBEYXMgU3JpbmFnZXNoIDxndXJ1c0Bjb2RlYXVyb3Jh Lm9yZz4gd3JvdGU6Cj4gU2luY2UgdGhlIFBXTSBmcmFtZXdvcmsgaXMgc3dpdGNoaW5nIHN0cnVj dCBwd21fc3RhdGUuZHV0eV9jeWNsZSdzCj4gZGF0YXR5cGUgdG8gdTY0LCBwcmVwYXJlIGZvciB0 aGlzIHRyYW5zaXRpb24gYnkgdXNpbmcgRElWX1JPVU5EX1VQX1VMTAo+IHRvIGhhbmRsZSBhIDY0 LWJpdCBkaXZpZGVuZC4KPgo+IFRvOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGludXguaW50 ZWwuY29tPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRl bC5jb20+Cj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiBDYzogRGFuaWVs IFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPiBDYzogIlZpbGxlIFN5cmrDpGzDpCIgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+IENjOiBpbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6 IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPgoKU3VwZXJmbHVvdXMgYmxhbmsgbGlu ZS4KCkFueXdheSwgcGxlYXNlIHByZXNlcnZlIHRoZSBleGlzdGluZyBhY2tzIGFuZCByZXZpZXdz IFsxXSBzbyBwZW9wbGUKZG9uJ3QgaGF2ZSB0byBkbyBpdCBhZ2Fpbi4KCkJSLApKYW5pLgoKWzFd IGh0dHA6Ly9sb3JlLmtlcm5lbC5vcmcvci84N2g3eWxlYjBpLmZzZkBpbnRlbC5jb20KCj4gU2ln bmVkLW9mZi1ieTogR3VydSBEYXMgU3JpbmFnZXNoIDxndXJ1c0Bjb2RlYXVyb3JhLm9yZz4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9wYW5lbC5jIHwgMiArLQo+ ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3BhbmVsLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3BhbmVsLmMKPiBpbmRleCAyNzZmNDM4Li44 MTU0N2EwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf cGFuZWwuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfcGFuZWwu Ywo+IEBAIC0xOTIwLDcgKzE5MjAsNyBAQCBzdGF0aWMgaW50IHB3bV9zZXR1cF9iYWNrbGlnaHQo c3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCXJldHVybiByZXR2YWw7Cj4g IAl9Cj4gIAo+IC0JbGV2ZWwgPSBESVZfUk9VTkRfVVAocHdtX2dldF9kdXR5X2N5Y2xlKHBhbmVs LT5iYWNrbGlnaHQucHdtKSAqIDEwMCwKPiArCWxldmVsID0gRElWX1JPVU5EX1VQX1VMTChwd21f Z2V0X2R1dHlfY3ljbGUocGFuZWwtPmJhY2tsaWdodC5wd20pICogMTAwLAo+ICAJCQkgICAgIENS Q19QTUlDX1BXTV9QRVJJT0RfTlMpOwo+ICAJcGFuZWwtPmJhY2tsaWdodC5sZXZlbCA9Cj4gIAkJ aW50ZWxfcGFuZWxfY29tcHV0ZV9icmlnaHRuZXNzKGNvbm5lY3RvciwgbGV2ZWwpOwoKLS0gCkph bmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74A50C55186 for ; Fri, 24 Apr 2020 06:18:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5074C20700 for ; Fri, 24 Apr 2020 06:18:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5074C20700 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E02F06E42F; Fri, 24 Apr 2020 06:18:06 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B1436E42F; Fri, 24 Apr 2020 06:18:06 +0000 (UTC) IronPort-SDR: IUbAsSqGloiCzdYb4mIfBDQXbJ8yDBm+AkZ01n34GoS4g0hNPzeS3EeDwyJ4BE5xCPWRw7Qa1o OjJ7ASSSZm8g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 23:18:05 -0700 IronPort-SDR: CMMh7MOlW2PHOf69i2rCxZUoGQjBYXzGWUKRrghXshWnbMa4J890SrsF0POzKmQwBnpobtHclZ 6P4wnWvYB6hA== X-IronPort-AV: E=Sophos;i="5.73,310,1583222400"; d="scan'208";a="430652200" Received: from khelzel-mobl.ger.corp.intel.com (HELO localhost) ([10.252.52.65]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 23:18:00 -0700 From: Jani Nikula To: Guru Das Srinagesh , linux-pwm@vger.kernel.org In-Reply-To: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> Date: Fri, 24 Apr 2020 09:17:58 +0300 Message-ID: <87ftctbe5l.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v13 01/11] drm/i915: Use 64-bit division macro X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guru Das Srinagesh , David Collins , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Wilson , Uwe =?utf-8?Q?Kleine-K=C3=B6ni?= =?utf-8?Q?g?= , Subbaraman Narayanamurthy Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gVHVlLCAyMSBBcHIgMjAyMCwgR3VydSBEYXMgU3JpbmFnZXNoIDxndXJ1c0Bjb2RlYXVyb3Jh Lm9yZz4gd3JvdGU6Cj4gU2luY2UgdGhlIFBXTSBmcmFtZXdvcmsgaXMgc3dpdGNoaW5nIHN0cnVj dCBwd21fc3RhdGUuZHV0eV9jeWNsZSdzCj4gZGF0YXR5cGUgdG8gdTY0LCBwcmVwYXJlIGZvciB0 aGlzIHRyYW5zaXRpb24gYnkgdXNpbmcgRElWX1JPVU5EX1VQX1VMTAo+IHRvIGhhbmRsZSBhIDY0 LWJpdCBkaXZpZGVuZC4KPgo+IFRvOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGludXguaW50 ZWwuY29tPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRl bC5jb20+Cj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiBDYzogRGFuaWVs IFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPiBDYzogIlZpbGxlIFN5cmrDpGzDpCIgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+IENjOiBpbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6 IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPgoKU3VwZXJmbHVvdXMgYmxhbmsgbGlu ZS4KCkFueXdheSwgcGxlYXNlIHByZXNlcnZlIHRoZSBleGlzdGluZyBhY2tzIGFuZCByZXZpZXdz IFsxXSBzbyBwZW9wbGUKZG9uJ3QgaGF2ZSB0byBkbyBpdCBhZ2Fpbi4KCkJSLApKYW5pLgoKWzFd IGh0dHA6Ly9sb3JlLmtlcm5lbC5vcmcvci84N2g3eWxlYjBpLmZzZkBpbnRlbC5jb20KCj4gU2ln bmVkLW9mZi1ieTogR3VydSBEYXMgU3JpbmFnZXNoIDxndXJ1c0Bjb2RlYXVyb3JhLm9yZz4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9wYW5lbC5jIHwgMiArLQo+ ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3BhbmVsLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3BhbmVsLmMKPiBpbmRleCAyNzZmNDM4Li44 MTU0N2EwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf cGFuZWwuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfcGFuZWwu Ywo+IEBAIC0xOTIwLDcgKzE5MjAsNyBAQCBzdGF0aWMgaW50IHB3bV9zZXR1cF9iYWNrbGlnaHQo c3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCXJldHVybiByZXR2YWw7Cj4g IAl9Cj4gIAo+IC0JbGV2ZWwgPSBESVZfUk9VTkRfVVAocHdtX2dldF9kdXR5X2N5Y2xlKHBhbmVs LT5iYWNrbGlnaHQucHdtKSAqIDEwMCwKPiArCWxldmVsID0gRElWX1JPVU5EX1VQX1VMTChwd21f Z2V0X2R1dHlfY3ljbGUocGFuZWwtPmJhY2tsaWdodC5wd20pICogMTAwLAo+ICAJCQkgICAgIENS Q19QTUlDX1BXTV9QRVJJT0RfTlMpOwo+ICAJcGFuZWwtPmJhY2tsaWdodC5sZXZlbCA9Cj4gIAkJ aW50ZWxfcGFuZWxfY29tcHV0ZV9icmlnaHRuZXNzKGNvbm5lY3RvciwgbGV2ZWwpOwoKLS0gCkph bmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41D1AC2BA1A for ; Fri, 24 Apr 2020 06:18:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23A8120700 for ; Fri, 24 Apr 2020 06:18:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726494AbgDXGSG convert rfc822-to-8bit (ORCPT ); Fri, 24 Apr 2020 02:18:06 -0400 Received: from mga02.intel.com ([134.134.136.20]:24165 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbgDXGSF (ORCPT ); Fri, 24 Apr 2020 02:18:05 -0400 IronPort-SDR: XsfrEoUXBWMjuIa+yga4mJn1c+hKQE3rrK6ZUTN/E+oQifx6BCa8r1tRIIRrzbiTD3/ZOOyIAX LRHv4MUsehSA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 23:18:05 -0700 IronPort-SDR: CMMh7MOlW2PHOf69i2rCxZUoGQjBYXzGWUKRrghXshWnbMa4J890SrsF0POzKmQwBnpobtHclZ 6P4wnWvYB6hA== X-IronPort-AV: E=Sophos;i="5.73,310,1583222400"; d="scan'208";a="430652200" Received: from khelzel-mobl.ger.corp.intel.com (HELO localhost) ([10.252.52.65]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 23:18:00 -0700 From: Jani Nikula To: Guru Das Srinagesh , linux-pwm@vger.kernel.org Cc: Guru Das Srinagesh , David Collins , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Wilson , Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6ni?= =?utf-8?Q?g?= , Subbaraman Narayanamurthy Subject: Re: [PATCH v13 01/11] drm/i915: Use 64-bit division macro In-Reply-To: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> Date: Fri, 24 Apr 2020 09:17:58 +0300 Message-ID: <87ftctbe5l.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Apr 2020, Guru Das Srinagesh wrote: > Since the PWM framework is switching struct pwm_state.duty_cycle's > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL > to handle a 64-bit dividend. > > To: Jani Nikula > Cc: Joonas Lahtinen > Cc: David Airlie > Cc: Daniel Vetter > Cc: Chris Wilson > Cc: "Ville Syrjälä" > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Superfluous blank line. Anyway, please preserve the existing acks and reviews [1] so people don't have to do it again. BR, Jani. [1] http://lore.kernel.org/r/87h7yleb0i.fsf@intel.com > Signed-off-by: Guru Das Srinagesh > --- > drivers/gpu/drm/i915/display/intel_panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c > index 276f438..81547a0 100644 > --- a/drivers/gpu/drm/i915/display/intel_panel.c > +++ b/drivers/gpu/drm/i915/display/intel_panel.c > @@ -1920,7 +1920,7 @@ static int pwm_setup_backlight(struct intel_connector *connector, > return retval; > } > > - level = DIV_ROUND_UP(pwm_get_duty_cycle(panel->backlight.pwm) * 100, > + level = DIV_ROUND_UP_ULL(pwm_get_duty_cycle(panel->backlight.pwm) * 100, > CRC_PMIC_PWM_PERIOD_NS); > panel->backlight.level = > intel_panel_compute_brightness(connector, level); -- Jani Nikula, Intel Open Source Graphics Center