From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D93C43331 for ; Tue, 31 Mar 2020 13:10:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35477206F5 for ; Tue, 31 Mar 2020 13:10:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35477206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC7D96E326; Tue, 31 Mar 2020 13:10:34 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 089626E326 for ; Tue, 31 Mar 2020 13:10:34 +0000 (UTC) IronPort-SDR: zd1Ro/7gXsmaiGVR4c/sIkMqIf9RQtfl5E4ntTjTvD07JxdOH/8yngWef9N6m7MmqAbgCXMsCK FWzdUNfarflw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2020 06:10:33 -0700 IronPort-SDR: hTWfFcqZ9rVWa7p/a+nRnrYCx+5PV2RwvlUTU1xzk9Jpi75s92H9/l1fCYIixiQmQ//e9p/W9q /LASDfg0LjAQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,327,1580803200"; d="scan'208";a="422290534" Received: from gaia.fi.intel.com ([10.237.72.192]) by orsmga005.jf.intel.com with ESMTP; 31 Mar 2020 06:10:32 -0700 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id 9CBD65C0D7B; Tue, 31 Mar 2020 16:08:54 +0300 (EEST) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20200331091459.29179-2-chris@chris-wilson.co.uk> References: <20200331091459.29179-1-chris@chris-wilson.co.uk> <20200331091459.29179-2-chris@chris-wilson.co.uk> Date: Tue, 31 Mar 2020 16:08:54 +0300 Message-ID: <87ftdopt7d.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 2/4] drm/i915/execlists: Pause CS flow before reset X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > Since we may be attempting to reset an active engine, we try to freeze > it in place before resetting -- to be on the safe side. We can go one > step further if we are using the CS flow semaphore to prevent the > context switching into the next. > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > index 9fff4e02cee6..9e18c0896a83 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > @@ -3669,6 +3669,7 @@ static void execlists_reset_prepare(struct intel_engine_cs *engine) > * > * FIXME: Wa for more modern gens needs to be validated > */ > + ring_set_paused(engine, 1); > intel_engine_stop_cs(engine); > } > > -- > 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx