From: Jakub Sitnicki <jakub@cloudflare.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: lmb@cloudflare.com, daniel@iogearbox.net,
john.fastabend@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next] bpf: tcp: Fix unused function warnings
Date: Thu, 19 Mar 2020 18:00:24 +0100 [thread overview]
Message-ID: <87fte4xot3.fsf@cloudflare.com> (raw)
In-Reply-To: <20200319124631.58432-1-yuehaibing@huawei.com>
On Thu, Mar 19, 2020 at 01:46 PM CET, YueHaibing wrote:
> If BPF_STREAM_PARSER is not set, gcc warns:
>
> net/ipv4/tcp_bpf.c:483:12: warning: 'tcp_bpf_sendpage' defined but not used [-Wunused-function]
> net/ipv4/tcp_bpf.c:395:12: warning: 'tcp_bpf_sendmsg' defined but not used [-Wunused-function]
> net/ipv4/tcp_bpf.c:13:13: warning: 'tcp_bpf_stream_read' defined but not used [-Wunused-function]
>
> Moves the unused functions into the #ifdef
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
In addition to this fix, looks like tcp_bpf_recvmsg can be static and
also conditional on CONFIG_BPF_STREAM_PARSER.
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
next prev parent reply other threads:[~2020-03-19 17:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 12:46 [PATCH bpf-next] bpf: tcp: Fix unused function warnings YueHaibing
2020-03-19 15:38 ` Lorenz Bauer
2020-03-19 17:00 ` Jakub Sitnicki [this message]
2020-03-19 17:38 ` Andrii Nakryiko
2020-03-20 2:33 ` Yuehaibing
2020-03-20 2:34 ` [PATCH bpf-next 0/2] minor cleanups YueHaibing
2020-03-20 2:34 ` [PATCH bpf-next 1/2] bpf: tcp: Fix unused function warnings YueHaibing
2020-03-20 4:21 ` Yonghong Song
2020-03-20 15:01 ` Daniel Borkmann
2020-03-20 2:34 ` [PATCH bpf-next 2/2] bpf: tcp: Make tcp_bpf_recvmsg static YueHaibing
2020-03-20 4:23 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fte4xot3.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lmb@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.