From: Michael Ellerman <mpe@ellerman.id.au>
To: Daniel Axtens <dja@axtens.net>,
Christophe Leroy <christophe.leroy@c-s.fr>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linuxppc-dev@lists.ozlabs.org, kasan-dev@googlegroups.com,
aneesh.kumar@linux.ibm.com, bsingharora@gmail.com
Subject: Re: [PATCH v4 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support
Date: Thu, 19 Dec 2019 22:25:32 +1100 [thread overview]
Message-ID: <87fthgmuab.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <87bls4tzjn.fsf@dja-thinkpad.axtens.net>
Daniel Axtens <dja@axtens.net> writes:
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>> On 12/19/2019 12:36 AM, Daniel Axtens wrote:
>>> KASAN support on Book3S is a bit tricky to get right:
...
>>> diff --git a/arch/powerpc/include/asm/kasan.h b/arch/powerpc/include/asm/kasan.h
>>> index 296e51c2f066..f18268cbdc33 100644
>>> --- a/arch/powerpc/include/asm/kasan.h
>>> +++ b/arch/powerpc/include/asm/kasan.h
>>> @@ -2,6 +2,9 @@
>>> #ifndef __ASM_KASAN_H
>>> #define __ASM_KASAN_H
>>>
>>> +#include <asm/page.h>
>>> +#include <asm/pgtable.h>
>>
>> What do you need asm/pgtable.h for ?
>>
>> Build failure due to circular inclusion of asm/pgtable.h:
>
> I see there's a lot of ppc32 stuff, I clearly need to bite the bullet
> and get a ppc32 toolchain so I can squash these without chewing up any
> more of your time. I'll sort that out and send a new spin.
I think you run Ubuntu, in which case it should just be:
$ apt install gcc-powerpc-linux-gnu
cheers
prev parent reply other threads:[~2019-12-19 11:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 0:36 [PATCH v4 0/4] KASAN for powerpc64 radix Daniel Axtens
2019-12-19 0:36 ` [PATCH v4 1/4] kasan: define and use MAX_PTRS_PER_* for early shadow tables Daniel Axtens
2019-12-19 0:36 ` [PATCH v4 2/4] kasan: Document support on 32-bit powerpc Daniel Axtens
2019-12-19 0:36 ` [PATCH v4 3/4] powerpc/mm/kasan: rename kasan_init_32.c to init_32.c Daniel Axtens
2019-12-19 0:36 ` [PATCH v4 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support Daniel Axtens
2019-12-19 0:36 ` Daniel Axtens
2019-12-19 7:53 ` Christophe Leroy
2019-12-19 7:53 ` Christophe Leroy
2019-12-19 9:50 ` Daniel Axtens
2019-12-19 9:50 ` Daniel Axtens
2019-12-19 10:05 ` Christophe Leroy
2019-12-19 10:05 ` Christophe Leroy
2019-12-19 10:07 ` Christophe Leroy
2019-12-19 12:21 ` Daniel Axtens
2019-12-19 12:21 ` Daniel Axtens
2019-12-19 11:25 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fthgmuab.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aneesh.kumar@linux.ibm.com \
--cc=bsingharora@gmail.com \
--cc=christophe.leroy@c-s.fr \
--cc=dja@axtens.net \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.