From: Baruch Siach <baruch@tkos.co.il>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
netdev@vger.kernel.org,
Denis Odintsov <d.odintsov@traviangames.com>,
Hubert Feurstein <h.feurstein@gmail.com>
Subject: Re: [BUG] mv88e6xxx: tx regression in v5.3
Date: Wed, 11 Dec 2019 19:07:29 +0200 [thread overview]
Message-ID: <87fthqu6y6.fsf@tarshish> (raw)
In-Reply-To: <20191211131111.GK16369@lunn.ch>
Hi Andrew,
On Wed, Dec 11 2019, Andrew Lunn wrote:
> On Wed, Dec 11, 2019 at 11:48:57AM +0200, Baruch Siach wrote:
>> Hi Andrew, Vivien,
>>
>> Since kernel v5.3 (tested v5.3.15), the 88E6141 switch on SolidRun
>> Clearfog GT-8K stopped transmitting packets on switch connected
>> ports. Kernel v5.2 works fine (tested v5.2.21).
>>
>> Here are the relevant kernel v5.3 log lines:
>>
>> [ 2.867424] mv88e6085 f412a200.mdio-mii:04: switch 0x3400 detected: Marvell 88E6141, revision 0
>> [ 2.927445] libphy: mdio: probed
>> [ 3.578496] mv88e6085 f412a200.mdio-mii:04 lan2 (uninitialized): PHY [!cp1!config-space@f4000000!mdio@12a200!switch0@4!mdio:11] driver [Marvell 88E6390]
>> [ 3.595674] mv88e6085 f412a200.mdio-mii:04 lan1 (uninitialized): PHY [!cp1!config-space@f4000000!mdio@12a200!switch0@4!mdio:12] driver [Marvell 88E6390]
>> [ 3.612797] mv88e6085 f412a200.mdio-mii:04 lan4 (uninitialized): PHY [!cp1!config-space@f4000000!mdio@12a200!switch0@4!mdio:13] driver [Marvell 88E6390]
>> [ 3.629910] mv88e6085 f412a200.mdio-mii:04 lan3 (uninitialized): PHY [!cp1!config-space@f4000000!mdio@12a200!switch0@4!mdio:14] driver [Marvell 88E6390]
>> [ 3.646049] mv88e6085 f412a200.mdio-mii:04: configuring for phy/ link mode
>> [ 3.654451] DSA: tree 0 setup
>> ...
>> [ 10.784521] mvpp2 f4000000.ethernet eth2: configuring for fixed/2500base-x link mode
>> [ 10.792401] mvpp2 f4000000.ethernet eth2: Link is Up - 2.5Gbps/Full - flow control off
>> [ 19.817981] mv88e6085 f412a200.mdio-mii:04 lan1: configuring for phy/ link mode
>> [ 19.827083] 8021q: adding VLAN 0 to HW filter on device lan1
>> [ 21.577276] mv88e6085 f412a200.mdio-mii:04 lan1: Link is Up - 100Mbps/Full - flow control rx/tx
>> [ 21.586030] IPv6: ADDRCONF(NETDEV_CHANGE): lan1: link becomes ready
>>
>> The Tx count on the lan1 interface increments, but the ARP packets don't
>> show on the network.
>
> Hi Baruch
>
> I don't know of an issues.
>
> If the MAC TX counter increases, it sounds like it is a PHY issue?
> Does 100Mbps/Full make sense for this link?
100Mbps switch is what I have at the other side of the link. Works
perfectly with v5.2.
> Probably your best bet is to do a git bisect to find which commit
> broke it.
Bisect points at 7fb5a711545d ("net: dsa: mv88e6xxx: drop adjust_link to
enabled phylink"). Reverting this commit on top of v5.3.15 fixes the
issue (and brings the warning back). As I understand, this basically
reverts the driver migration to phylink. What might be the issue with
phylink?
Thanks,
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2019-12-11 17:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 9:48 [BUG] mv88e6xxx: tx regression in v5.3 Baruch Siach
2019-12-11 13:11 ` Andrew Lunn
2019-12-11 17:07 ` Baruch Siach [this message]
2019-12-11 17:49 ` Andrew Lunn
2019-12-12 8:50 ` Baruch Siach
2019-12-12 13:14 ` Andrew Lunn
2019-12-12 14:19 ` Andreas Tobler
2019-12-12 15:08 ` Baruch Siach
2019-12-12 15:13 ` Andrew Lunn
2019-12-12 15:23 ` Baruch Siach
2019-12-12 18:17 ` Baruch Siach
2019-12-12 18:32 ` Marek Behun
2019-12-12 18:48 ` Baruch Siach
2019-12-12 18:36 ` Marek Behun
2019-12-12 19:06 ` Baruch Siach
2019-12-12 19:31 ` Andrew Lunn
2019-12-12 19:41 ` Marek Behun
2019-12-12 20:49 ` Andrew Lunn
2019-12-15 10:13 ` Baruch Siach
2019-12-15 11:10 ` Baruch Siach
2019-12-15 14:53 ` Andrew Lunn
2019-12-15 15:08 ` Baruch Siach
2019-12-15 16:14 ` Andrew Lunn
2019-12-17 18:26 ` Baruch Siach
2019-12-18 14:30 ` Marek Behún
2019-12-18 16:04 ` Baruch Siach
2019-12-19 9:04 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fthqu6y6.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=andrew@lunn.ch \
--cc=d.odintsov@traviangames.com \
--cc=h.feurstein@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.