From: Felipe Balbi <balbi@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-usb@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] usb: dwc3: Remove dev_err() on platform_get_irq() failure
Date: Mon, 07 Oct 2019 08:39:06 +0300 [thread overview]
Message-ID: <87ftk5ru6d.fsf@gmail.com> (raw)
In-Reply-To: <20191005210449.3926-4-hdegoede@redhat.com>
Hi,
Hans de Goede <hdegoede@redhat.com> writes:
> Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to
> platform_get_irq*()"), platform_get_irq() will call dev_err() itself on
> failure, so there is no need for the driver to also do this.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
--
balbi
next prev parent reply other threads:[~2019-10-07 5:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 21:04 [PATCH 0/3] Add platform_get_irq_byname_optional() and use it in the dwc3 driver Hans de Goede
2019-10-05 21:04 ` [PATCH 1/3] driver core: platform: Add platform_get_irq_byname_optional() Hans de Goede
2019-10-07 8:53 ` Rafael J. Wysocki
2019-10-07 15:30 ` Stephen Boyd
2019-10-05 21:04 ` [PATCH 2/3] usb: dwc3: Switch to platform_get_irq_byname_optional() Hans de Goede
2019-10-07 5:38 ` Felipe Balbi
2019-10-07 15:31 ` Stephen Boyd
2019-10-05 21:04 ` [PATCH 3/3] usb: dwc3: Remove dev_err() on platform_get_irq() failure Hans de Goede
2019-10-07 5:39 ` Felipe Balbi [this message]
2019-10-07 15:31 ` Stephen Boyd
2019-10-07 10:54 ` [PATCH 0/3] Add platform_get_irq_byname_optional() and use it in the dwc3 driver Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftk5ru6d.fsf@gmail.com \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.