From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29FA6C432C1 for ; Tue, 24 Sep 2019 20:32:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F23042146E for ; Tue, 24 Sep 2019 20:31:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F23042146E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCrTa-0007kQ-Dv for qemu-devel@archiver.kernel.org; Tue, 24 Sep 2019 16:31:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49520) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCrH1-0002iS-Lp for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:19:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCrH0-0007es-Pj for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:18:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49354) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCrH0-0007ei-Kk for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:18:58 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E74C630820C9; Tue, 24 Sep 2019 20:18:57 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-117-142.ams2.redhat.com [10.36.117.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1D5C319C58; Tue, 24 Sep 2019 20:18:55 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E51C7113864E; Tue, 24 Sep 2019 22:18:53 +0200 (CEST) From: Markus Armbruster To: Eric Blake Subject: Re: [PATCH 03/25] qapi: New QAPISourceInfo, replacing dict References: <20190924132830.15835-1-armbru@redhat.com> <20190924132830.15835-4-armbru@redhat.com> <4ff086cb-7c96-a25a-be19-d78af40afd9b@redhat.com> Date: Tue, 24 Sep 2019 22:18:53 +0200 In-Reply-To: <4ff086cb-7c96-a25a-be19-d78af40afd9b@redhat.com> (Eric Blake's message of "Tue, 24 Sep 2019 09:51:40 -0500") Message-ID: <87ftkla1n6.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 24 Sep 2019 20:18:57 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com, marcandre.lureau@redhat.com, Markus Armbruster , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eric Blake writes: > On 9/24/19 8:28 AM, Markus Armbruster wrote: >> We track source locations with a dict of the form >> >> {'file': FNAME, 'line': LINENO, parent': PARENT} > > Missing ' on parent > >> >> where PARENT is None for the main file, and the include directive's >> source location for included files. >> >> This is servicable enough, but the next commit will add information, > > serviceable Will fix both. >> and that's going to come out cleaner if we turn this into a class. So >> do that. >> >> Signed-off-by: Markus Armbruster >> --- >> scripts/qapi/common.py | 69 +++++++++++++++++++++++++----------------- >> 1 file changed, 41 insertions(+), 28 deletions(-) >> > Reviewed-by: Eric Blake Thanks!