From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBdft-0000pg-0z for ath10k@lists.infradead.org; Sat, 21 Sep 2019 11:35:39 +0000 Received: by mail-ed1-f72.google.com with SMTP id l5so2758840edr.10 for ; Sat, 21 Sep 2019 04:35:32 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH 2/4] mac80211: defer txqs removal from rbtree In-Reply-To: <198124204167325252fcfcd65e3f2733@codeaurora.org> References: <1568639388-27291-1-git-send-email-yiboz@codeaurora.org> <1568639388-27291-2-git-send-email-yiboz@codeaurora.org> <87pnjyiq7o.fsf@toke.dk> <87sgothmpy.fsf@toke.dk> <8cdece5c030fd95817fb099021c38613@codeaurora.org> <87tv98fu6l.fsf@toke.dk> <1b4ab006d9b5c88035845aaac193ef48@codeaurora.org> <8736gre3bm.fsf@toke.dk> <198124204167325252fcfcd65e3f2733@codeaurora.org> Date: Sat, 21 Sep 2019 13:27:00 +0200 Message-ID: <87ftkp7uuz.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Yibo Zhao Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org WWlibyBaaGFvIDx5aWJvekBjb2RlYXVyb3JhLm9yZz4gd3JpdGVzOgoKPiBPbiAyMDE5LTA5LTIw IDE3OjE1LCBUb2tlIEjDuGlsYW5kLUrDuHJnZW5zZW4gd3JvdGU6Cj4+IFlpYm8gWmhhbyA8eWli b3pAY29kZWF1cm9yYS5vcmc+IHdyaXRlczoKPj4gCj4+PiBPbiAyMDE5LTA5LTE5IDE4OjM3LCBU b2tlIEjDuGlsYW5kLUrDuHJnZW5zZW4gd3JvdGU6Cj4+Pj4gWWlibyBaaGFvIDx5aWJvekBjb2Rl YXVyb3JhLm9yZz4gd3JpdGVzOgo+Pj4+IAo+Pj4+PiBPbiAyMDE5LTA5LTE4IDE5OjIzLCBUb2tl IEjDuGlsYW5kLUrDuHJnZW5zZW4gd3JvdGU6Cj4+Pj4+PiBZaWJvIFpoYW8gPHlpYm96QGNvZGVh dXJvcmEub3JnPiB3cml0ZXM6Cj4+Pj4+PiAKPj4+Pj4+PiBPbiAyMDE5LTA5LTE4IDA1OjEwLCBU b2tlIEjDuGlsYW5kLUrDuHJnZW5zZW4gd3JvdGU6Cj4+Pj4+Pj4+IFlpYm8gWmhhbyA8eWlib3pA Y29kZWF1cm9yYS5vcmc+IHdyaXRlczoKPj4+Pj4+Pj4gCj4+Pj4+Pj4+PiBJbiBhIGxvb3AgdHhx cyBkZXF1ZXVlIHNjZW5hcmlvLCBpZiB0aGUgZmlyc3QgdHhxIGluIHRoZSByYnRyZWUKPj4+Pj4+ Pj4+IGdldHMKPj4+Pj4+Pj4+IHJlbW92ZWQgZnJvbSByYnRyZWUgaW1tZWRpYXRlbHkgaW4gdGhl IGllZWU4MDIxMV9yZXR1cm5fdHhxKCksIAo+Pj4+Pj4+Pj4gdGhlCj4+Pj4+Pj4+PiBsb29wIHdp bGwgYnJlYWsgc29vbiBpbiB0aGUgaWVlZTgwMjExX25leHRfdHhxKCkgZHVlIHRvCj4+Pj4+Pj4+ PiBzY2hlZHVsZV9wb3MKPj4+Pj4+Pj4+IG5vdCBsZWFkaW5nIHRvIHRoZSBzZWNvbmQgdHhxIGlu IHRoZSByYnRyZWUuIFRodXMsIGRlZmVyaW5nIHRoZQo+Pj4+Pj4+Pj4gcmVtb3ZhbCByaWdodCBi ZWZvcmUgdGhlIGVuZCBvZiB0aGlzIHNjaGVkdWxlIHJvdW5kLgo+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+ PiBDby1kZXZlbG9wZWQtYnk6IFlpYm8gWmhhbyA8eWlib3pAY29kZWF1cm9yYS5vcmc+Cj4+Pj4+ Pj4+PiBTaWduZWQtb2ZmLWJ5OiBZaWJvIFpoYW8gPHlpYm96QGNvZGVhdXJvcmEub3JnPgo+Pj4+ Pj4+Pj4gU2lnbmVkLW9mZi1ieTogVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHRva2Uu ZGs+Cj4+Pj4+Pj4+IAo+Pj4+Pj4+PiBJIGRpZG4ndCB3cml0ZSB0aGlzIHBhdGNoLCBzbyBwbGVh c2UgZG9uJ3QgdXNlIG15IHNpZ24tb2ZmLiBJJ2xsCj4+Pj4+Pj4+IGFkZAo+Pj4+Pj4+PiBhY2sg b3IgcmV2aWV3IHRhZ3MgYXMgYXBwcm9wcmlhdGUgaW4gcmVwbHk7IGJ1dCBhIGZldyBjb21tZW50 cwo+Pj4+Pj4+PiBmaXJzdDoKPj4+Pj4+Pj4gCj4+Pj4+Pj4+PiAtLS0KPj4+Pj4+Pj4+ICBpbmNs dWRlL25ldC9tYWM4MDIxMS5oICAgICB8IDE2ICsrKysrKysrKystLQo+Pj4+Pj4+Pj4gIG5ldC9t YWM4MDIxMS9pZWVlODAyMTFfaS5oIHwgIDMgKysrCj4+Pj4+Pj4+PiAgbmV0L21hYzgwMjExL21h aW4uYyAgICAgICAgfCAgNiArKysrKwo+Pj4+Pj4+Pj4gIG5ldC9tYWM4MDIxMS90eC5jICAgICAg ICAgIHwgNjMKPj4+Pj4+Pj4+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKystLS0KPj4+Pj4+Pj4+ICA0IGZpbGVzIGNoYW5nZWQsIDgzIGluc2VydGlvbnMoKyksIDUg ZGVsZXRpb25zKC0pCj4+Pj4+Pj4+PiAKPj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL25l dC9tYWM4MDIxMS5oIGIvaW5jbHVkZS9uZXQvbWFjODAyMTEuaAo+Pj4+Pj4+Pj4gaW5kZXggYWMy ZWQ4ZS4uYmE1YTM0NSAxMDA2NDQKPj4+Pj4+Pj4+IC0tLSBhL2luY2x1ZGUvbmV0L21hYzgwMjEx LmgKPj4+Pj4+Pj4+ICsrKyBiL2luY2x1ZGUvbmV0L21hYzgwMjExLmgKPj4+Pj4+Pj4+IEBAIC05 MjUsNiArOTI1LDggQEAgc3RydWN0IGllZWU4MDIxMV90eF9yYXRlIHsKPj4+Pj4+Pj4+IAo+Pj4+ Pj4+Pj4gICNkZWZpbmUgSUVFRTgwMjExX01BWF9UWF9SRVRSWQkJMzEKPj4+Pj4+Pj4+IAo+Pj4+ Pj4+Pj4gKyNkZWZpbmUgSUVFRTgwMjExX0FJUlRJTUVfVFhRX1JNX0NIS19JTlRWX0lOX01TIDEw MAo+Pj4+Pj4+Pj4gKwo+Pj4+Pj4+Pj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBpZWVlODAyMTFfcmF0 ZV9zZXRfdmh0KHN0cnVjdAo+Pj4+Pj4+Pj4gaWVlZTgwMjExX3R4X3JhdGUKPj4+Pj4+Pj4+ICpy YXRlLAo+Pj4+Pj4+Pj4gIAkJCQkJICB1OCBtY3MsIHU4IG5zcykKPj4+Pj4+Pj4+ICB7Cj4+Pj4+ Pj4+PiBAQCAtNjIzMiw3ICs2MjM0LDggQEAgc3RydWN0IHNrX2J1ZmYgCj4+Pj4+Pj4+PiAqaWVl ZTgwMjExX3R4X2RlcXVldWUoc3RydWN0Cj4+Pj4+Pj4+PiBpZWVlODAyMTFfaHcgKmh3LAo+Pj4+ Pj4+Pj4gICAqIEBhYzogQUMgbnVtYmVyIHRvIHJldHVybiBwYWNrZXRzIGZyb20uCj4+Pj4+Pj4+ PiAgICoKPj4+Pj4+Pj4+ICAgKiBTaG91bGQgb25seSBiZSBjYWxsZWQgYmV0d2VlbiBjYWxscyB0 bwo+Pj4+Pj4+Pj4gaWVlZTgwMjExX3R4cV9zY2hlZHVsZV9zdGFydCgpCj4+Pj4+Pj4+PiAtICog YW5kIGllZWU4MDIxMV90eHFfc2NoZWR1bGVfZW5kKCkuCj4+Pj4+Pj4+PiArICogYW5kIGllZWU4 MDIxMV90eHFfc2NoZWR1bGVfZW5kKCkuIElmIHRoZSB0eHEgaXMgZW1wdHksIGl0IAo+Pj4+Pj4+ Pj4gd2lsbAo+Pj4+Pj4+Pj4gYmUKPj4+Pj4+Pj4+IGFkZGVkCj4+Pj4+Pj4+PiArICogdG8gYSBy ZW1vdmUgbGlzdCBhbmQgZ2V0IHJlbW92ZWQgbGF0ZXIuCj4+Pj4+Pj4+PiAgICogUmV0dXJucyB0 aGUgbmV4dCB0eHEgaWYgc3VjY2Vzc2Z1bCwgJU5VTEwgaWYgbm8gcXVldWUgaXMKPj4+Pj4+Pj4+ IGVsaWdpYmxlLgo+Pj4+Pj4+Pj4gSWYgYSB0eHEKPj4+Pj4+Pj4+ICAgKiBpcyByZXR1cm5lZCwg aXQgc2hvdWxkIGJlIHJldHVybmVkIHdpdGggCj4+Pj4+Pj4+PiBpZWVlODAyMTFfcmV0dXJuX3R4 cSgpCj4+Pj4+Pj4+PiBhZnRlciB0aGUKPj4+Pj4+Pj4+ICAgKiBkcml2ZXIgaGFzIGZpbmlzaGVk IHNjaGVkdWxpbmcgaXQuCj4+Pj4+Pj4+PiBAQCAtNjI2OCw3ICs2MjcxLDggQEAgdm9pZCBpZWVl ODAyMTFfdHhxX3NjaGVkdWxlX3N0YXJ0KHN0cnVjdAo+Pj4+Pj4+Pj4gaWVlZTgwMjExX2h3ICpo dywgdTggYWMpCj4+Pj4+Pj4+PiAgICogQGh3OiBwb2ludGVyIGFzIG9idGFpbmVkIGZyb20gaWVl ZTgwMjExX2FsbG9jX2h3KCkKPj4+Pj4+Pj4+ICAgKiBAYWM6IEFDIG51bWJlciB0byBhY3F1aXJl IGxvY2tzIGZvcgo+Pj4+Pj4+Pj4gICAqCj4+Pj4+Pj4+PiAtICogUmVsZWFzZSBsb2NrcyBwcmV2 aW91c2x5IGFjcXVpcmVkIGJ5Cj4+Pj4+Pj4+PiBpZWVlODAyMTFfdHhxX3NjaGVkdWxlX2VuZCgp Lgo+Pj4+Pj4+Pj4gKyAqIFJlbGVhc2UgbG9ja3MgcHJldmlvdXNseSBhY3F1aXJlZCBieQo+Pj4+ Pj4+Pj4gaWVlZTgwMjExX3R4cV9zY2hlZHVsZV9lbmQoKS4KPj4+Pj4+Pj4+IENoZWNrCj4+Pj4+ Pj4+PiArICogYW5kIHJlbW92ZSB0aGUgZW1wdHkgdHhxIGZyb20gcmItdHJlZS4KPj4+Pj4+Pj4+ ICAgKi8KPj4+Pj4+Pj4+ICB2b2lkIGllZWU4MDIxMV90eHFfc2NoZWR1bGVfZW5kKHN0cnVjdCBp ZWVlODAyMTFfaHcgKmh3LCB1OCBhYykKPj4+Pj4+Pj4+ICAJX19yZWxlYXNlcyh0eHFfbG9jayk7 Cj4+Pj4+Pj4+PiBAQCAtNjI4Nyw2ICs2MjkxLDE0IEBAIHZvaWQgaWVlZTgwMjExX3NjaGVkdWxl X3R4cShzdHJ1Y3QKPj4+Pj4+Pj4+IGllZWU4MDIxMV9odwo+Pj4+Pj4+Pj4gKmh3LCBzdHJ1Y3Qg aWVlZTgwMjExX3R4cSAqdHhxKQo+Pj4+Pj4+Pj4gIAlfX2FjcXVpcmVzKHR4cV9sb2NrKSBfX3Jl bGVhc2VzKHR4cV9sb2NrKTsKPj4+Pj4+Pj4+IAo+Pj4+Pj4+Pj4gIC8qKgo+Pj4+Pj4+Pj4gKyAq IGllZWU4MDIxMV90eHFzX2NoZWNrIC0gQ2hlY2sgdHhxcyB3YWl0aW5nIGZvciByZW1vdmFsCj4+ Pj4+Pj4+PiArICoKPj4+Pj4+Pj4+ICsgKiBAdG1yOiBwb2ludGVyIGFzIG9idGFpbmVkIGZyb20g bG9jYWwKPj4+Pj4+Pj4+ICsgKgo+Pj4+Pj4+Pj4gKyAqLwo+Pj4+Pj4+Pj4gK3ZvaWQgaWVlZTgw MjExX3R4cXNfY2hlY2soc3RydWN0IHRpbWVyX2xpc3QgKnRtcik7Cj4+Pj4+Pj4+PiArCj4+Pj4+ Pj4+PiArLyoqCj4+Pj4+Pj4+PiAgICogaWVlZTgwMjExX3R4cV9tYXlfdHJhbnNtaXQgLSBjaGVj ayB3aGV0aGVyIFRYUSBpcyBhbGxvd2VkIHRvCj4+Pj4+Pj4+PiB0cmFuc21pdAo+Pj4+Pj4+Pj4g ICAqCj4+Pj4+Pj4+PiAgICogVGhpcyBmdW5jdGlvbiBpcyB1c2VkIHRvIGNoZWNrIHdoZXRoZXIg Z2l2ZW4gdHhxIGlzIGFsbG93ZWQgCj4+Pj4+Pj4+PiB0bwo+Pj4+Pj4+Pj4gdHJhbnNtaXQgYnkK Pj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS9uZXQvbWFjODAyMTEvaWVlZTgwMjExX2kuaAo+Pj4+Pj4+ Pj4gYi9uZXQvbWFjODAyMTEvaWVlZTgwMjExX2kuaAo+Pj4+Pj4+Pj4gaW5kZXggYTQ1NTZmOS4u NDlhYTE0M2UgMTAwNjQ0Cj4+Pj4+Pj4+PiAtLS0gYS9uZXQvbWFjODAyMTEvaWVlZTgwMjExX2ku aAo+Pj4+Pj4+Pj4gKysrIGIvbmV0L21hYzgwMjExL2llZWU4MDIxMV9pLmgKPj4+Pj4+Pj4+IEBA IC04NDcsNiArODQ3LDcgQEAgc3RydWN0IHR4cV9pbmZvIHsKPj4+Pj4+Pj4+ICAJc3RydWN0IGNv ZGVsX3N0YXRzIGNzdGF0czsKPj4+Pj4+Pj4+ICAJc3RydWN0IHNrX2J1ZmZfaGVhZCBmcmFnczsK Pj4+Pj4+Pj4+ICAJc3RydWN0IHJiX25vZGUgc2NoZWR1bGVfb3JkZXI7Cj4+Pj4+Pj4+PiArCXN0 cnVjdCBsaXN0X2hlYWQgY2FuZGlkYXRlOwo+Pj4+Pj4+Pj4gIAl1bnNpZ25lZCBsb25nIGZsYWdz Owo+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+PiAgCS8qIGtlZXAgbGFzdCEgKi8KPj4+Pj4+Pj4+IEBAIC0x MTQ1LDYgKzExNDYsOCBAQCBzdHJ1Y3QgaWVlZTgwMjExX2xvY2FsIHsKPj4+Pj4+Pj4+ICAJdTY0 IGFpcnRpbWVfdl90W0lFRUU4MDIxMV9OVU1fQUNTXTsKPj4+Pj4+Pj4+ICAJdTY0IGFpcnRpbWVf d2VpZ2h0X3N1bVtJRUVFODAyMTFfTlVNX0FDU107Cj4+Pj4+Pj4+PiAKPj4+Pj4+Pj4+ICsJc3Ry dWN0IGxpc3RfaGVhZCByZW1vdmVfbGlzdFtJRUVFODAyMTFfTlVNX0FDU107Cj4+Pj4+Pj4+PiAr CXN0cnVjdCB0aW1lcl9saXN0IHJlbW92ZV90aW1lcjsKPj4+Pj4+Pj4+ICAJdTE2IGFpcnRpbWVf ZmxhZ3M7Cj4+Pj4+Pj4+PiAKPj4+Pj4+Pj4+ICAJY29uc3Qgc3RydWN0IGllZWU4MDIxMV9vcHMg Km9wczsKPj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS9uZXQvbWFjODAyMTEvbWFpbi5jIGIvbmV0L21h YzgwMjExL21haW4uYwo+Pj4+Pj4+Pj4gaW5kZXggZTlmZmE4ZS4uNzhmZTI0YSAxMDA2NDQKPj4+ Pj4+Pj4+IC0tLSBhL25ldC9tYWM4MDIxMS9tYWluLmMKPj4+Pj4+Pj4+ICsrKyBiL25ldC9tYWM4 MDIxMS9tYWluLmMKPj4+Pj4+Pj4+IEBAIC02NjcsMTAgKzY2NywxNSBAQCBzdHJ1Y3QgaWVlZTgw MjExX2h3Cj4+Pj4+Pj4+PiAqaWVlZTgwMjExX2FsbG9jX2h3X25tKHNpemVfdCBwcml2X2RhdGFf bGVuLAo+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+PiAgCWZvciAoaSA9IDA7IGkgPCBJRUVFODAyMTFfTlVN X0FDUzsgaSsrKSB7Cj4+Pj4+Pj4+PiAgCQlsb2NhbC0+YWN0aXZlX3R4cXNbaV0gPSBSQl9ST09U X0NBQ0hFRDsKPj4+Pj4+Pj4+ICsJCUlOSVRfTElTVF9IRUFEKCZsb2NhbC0+cmVtb3ZlX2xpc3Rb aV0pOwo+Pj4+Pj4+Pj4gIAkJc3Bpbl9sb2NrX2luaXQoJmxvY2FsLT5hY3RpdmVfdHhxX2xvY2tb aV0pOwo+Pj4+Pj4+Pj4gIAl9Cj4+Pj4+Pj4+PiAgCWxvY2FsLT5haXJ0aW1lX2ZsYWdzID0gQUlS VElNRV9VU0VfVFggfCBBSVJUSU1FX1VTRV9SWDsKPj4+Pj4+Pj4+IAo+Pj4+Pj4+Pj4gKwl0aW1l cl9zZXR1cCgmbG9jYWwtPnJlbW92ZV90aW1lciwgaWVlZTgwMjExX3R4cXNfY2hlY2ssIDApOwo+ Pj4+Pj4+Pj4gKwltb2RfdGltZXIoJmxvY2FsLT5yZW1vdmVfdGltZXIsCj4+Pj4+Pj4+PiArCQkg IGppZmZpZXMgKwo+Pj4+Pj4+Pj4gbXNlY3NfdG9famlmZmllcyhJRUVFODAyMTFfQUlSVElNRV9U WFFfUk1fQ0hLX0lOVFZfSU5fTVMpKTsKPj4+Pj4+Pj4+ICsKPj4+Pj4+Pj4+ICAJSU5JVF9MSVNU X0hFQUQoJmxvY2FsLT5jaGFuY3R4X2xpc3QpOwo+Pj4+Pj4+Pj4gIAltdXRleF9pbml0KCZsb2Nh bC0+Y2hhbmN0eF9tdHgpOwo+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+PiBAQCAtMTMwNSw2ICsxMzEwLDcg QEAgdm9pZCBpZWVlODAyMTFfdW5yZWdpc3Rlcl9odyhzdHJ1Y3QKPj4+Pj4+Pj4+IGllZWU4MDIx MV9odwo+Pj4+Pj4+Pj4gKmh3KQo+Pj4+Pj4+Pj4gIAl0YXNrbGV0X2tpbGwoJmxvY2FsLT50eF9w ZW5kaW5nX3Rhc2tsZXQpOwo+Pj4+Pj4+Pj4gIAl0YXNrbGV0X2tpbGwoJmxvY2FsLT50YXNrbGV0 KTsKPj4+Pj4+Pj4+IAo+Pj4+Pj4+Pj4gKwlkZWxfdGltZXJfc3luYygmbG9jYWwtPnJlbW92ZV90 aW1lcik7Cj4+Pj4+Pj4+PiAgI2lmZGVmIENPTkZJR19JTkVUCj4+Pj4+Pj4+PiAgCXVucmVnaXN0 ZXJfaW5ldGFkZHJfbm90aWZpZXIoJmxvY2FsLT5pZmFfbm90aWZpZXIpOwo+Pj4+Pj4+Pj4gICNl bmRpZgo+Pj4+Pj4+Pj4gZGlmZiAtLWdpdCBhL25ldC9tYWM4MDIxMS90eC5jIGIvbmV0L21hYzgw MjExL3R4LmMKPj4+Pj4+Pj4+IGluZGV4IGQwMGJhYWEuLjQyY2EwMTAgMTAwNjQ0Cj4+Pj4+Pj4+ PiAtLS0gYS9uZXQvbWFjODAyMTEvdHguYwo+Pj4+Pj4+Pj4gKysrIGIvbmV0L21hYzgwMjExL3R4 LmMKPj4+Pj4+Pj4+IEBAIC0xNDUwLDYgKzE0NTAsNyBAQCB2b2lkIGllZWU4MDIxMV90eHFfaW5p dChzdHJ1Y3QKPj4+Pj4+Pj4+IGllZWU4MDIxMV9zdWJfaWZfZGF0YSAqc2RhdGEsCj4+Pj4+Pj4+ PiAgCWNvZGVsX3N0YXRzX2luaXQoJnR4cWktPmNzdGF0cyk7Cj4+Pj4+Pj4+PiAgCV9fc2tiX3F1 ZXVlX2hlYWRfaW5pdCgmdHhxaS0+ZnJhZ3MpOwo+Pj4+Pj4+Pj4gIAlSQl9DTEVBUl9OT0RFKCZ0 eHFpLT5zY2hlZHVsZV9vcmRlcik7Cj4+Pj4+Pj4+PiArCUlOSVRfTElTVF9IRUFEKCZ0eHFpLT5j YW5kaWRhdGUpOwo+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+PiAgCXR4cWktPnR4cS52aWYgPSAmc2RhdGEt PnZpZjsKPj4+Pj4+Pj4+IAo+Pj4+Pj4+Pj4gQEAgLTM3MjQsNiArMzcyNSw5IEBAIHZvaWQgaWVl ZTgwMjExX3NjaGVkdWxlX3R4cShzdHJ1Y3QKPj4+Pj4+Pj4+IGllZWU4MDIxMV9odwo+Pj4+Pj4+ Pj4gKmh3LAo+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+PiAgCXNwaW5fbG9ja19iaCgmbG9jYWwtPmFjdGl2 ZV90eHFfbG9ja1thY10pOwo+Pj4+Pj4+Pj4gCj4+Pj4+Pj4+PiArCWlmICghbGlzdF9lbXB0eSgm dHhxaS0+Y2FuZGlkYXRlKSkKPj4+Pj4+Pj4+ICsJCWxpc3RfZGVsX2luaXQoJnR4cWktPmNhbmRp ZGF0ZSk7Cj4+Pj4+Pj4+PiArCj4+Pj4+Pj4+PiAgCWlmICghUkJfRU1QVFlfTk9ERSgmdHhxaS0+ c2NoZWR1bGVfb3JkZXIpKQo+Pj4+Pj4+Pj4gIAkJZ290byBvdXQ7Cj4+Pj4+Pj4+PiAKPj4+Pj4+ Pj4+IEBAIC0zNzgzLDYgKzM3ODcsMjAgQEAgc3RhdGljIHZvaWQKPj4+Pj4+Pj4+IF9faWVlZTgw MjExX3Vuc2NoZWR1bGVfdHhxKHN0cnVjdAo+Pj4+Pj4+Pj4gaWVlZTgwMjExX2h3ICpodywKPj4+ Pj4+Pj4+ICAJUkJfQ0xFQVJfTk9ERSgmdHhxaS0+c2NoZWR1bGVfb3JkZXIpOwo+Pj4+Pj4+Pj4g IH0KPj4+Pj4+Pj4+IAo+Pj4+Pj4+Pj4gK3ZvaWQgaWVlZTgwMjExX3JlbW92ZV90eHEoc3RydWN0 IGllZWU4MDIxMV9odyAqaHcsCj4+Pj4+Pj4+PiArCQkJICBzdHJ1Y3QgaWVlZTgwMjExX3R4cSAq dHhxKQo+Pj4+Pj4+Pj4gK3sKPj4+Pj4+Pj4+ICsJc3RydWN0IGllZWU4MDIxMV9sb2NhbCAqbG9j YWwgPSBod190b19sb2NhbChodyk7Cj4+Pj4+Pj4+PiArCXN0cnVjdCB0eHFfaW5mbyAqdHhxaSA9 IHRvX3R4cV9pbmZvKHR4cSk7Cj4+Pj4+Pj4+PiArCj4+Pj4+Pj4+PiArCWxvY2tkZXBfYXNzZXJ0 X2hlbGQoJmxvY2FsLT5hY3RpdmVfdHhxX2xvY2tbdHhxLT5hY10pOwo+Pj4+Pj4+Pj4gKwo+Pj4+ Pj4+Pj4gKwlpZiAoIVJCX0VNUFRZX05PREUoJnR4cWktPnNjaGVkdWxlX29yZGVyKSkgewo+Pj4+ Pj4+Pj4gKwkJX19pZWVlODAyMTFfdW5zY2hlZHVsZV90eHEoaHcsIHR4cSk7Cj4+Pj4+Pj4+PiAr CQlsaXN0X2RlbF9pbml0KCZ0eHFpLT5jYW5kaWRhdGUpOwo+Pj4+Pj4+Pj4gKwl9Cj4+Pj4+Pj4+ PiArfQo+Pj4+Pj4+Pj4gKwo+Pj4+Pj4+Pj4gIHZvaWQgaWVlZTgwMjExX3Vuc2NoZWR1bGVfdHhx KHN0cnVjdCBpZWVlODAyMTFfaHcgKmh3LAo+Pj4+Pj4+Pj4gIAkJCSAgICAgIHN0cnVjdCBpZWVl ODAyMTFfdHhxICp0eHEpCj4+Pj4+Pj4+PiAgCV9fYWNxdWlyZXModHhxX2xvY2spIF9fcmVsZWFz ZXModHhxX2xvY2spCj4+Pj4+Pj4+PiBAQCAtMzc5MCw3ICszODA4LDcgQEAgdm9pZCBpZWVlODAy MTFfdW5zY2hlZHVsZV90eHEoc3RydWN0Cj4+Pj4+Pj4+PiBpZWVlODAyMTFfaHcgKmh3LAo+Pj4+ Pj4+Pj4gIAlzdHJ1Y3QgaWVlZTgwMjExX2xvY2FsICpsb2NhbCA9IGh3X3RvX2xvY2FsKGh3KTsK Pj4+Pj4+Pj4+IAo+Pj4+Pj4+Pj4gIAlzcGluX2xvY2tfYmgoJmxvY2FsLT5hY3RpdmVfdHhxX2xv Y2tbdHhxLT5hY10pOwo+Pj4+Pj4+Pj4gLQlfX2llZWU4MDIxMV91bnNjaGVkdWxlX3R4cShodywg dHhxKTsKPj4+Pj4+Pj4+ICsJaWVlZTgwMjExX3JlbW92ZV90eHEoaHcsIHR4cSk7Cj4+Pj4+Pj4+ PiAgCXNwaW5fdW5sb2NrX2JoKCZsb2NhbC0+YWN0aXZlX3R4cV9sb2NrW3R4cS0+YWNdKTsKPj4+ Pj4+Pj4+ICB9Cj4+Pj4+Pj4+PiAKPj4+Pj4+Pj4+IEBAIC0zODAzLDExICszODIxLDQ4IEBAIHZv aWQgaWVlZTgwMjExX3JldHVybl90eHEoc3RydWN0Cj4+Pj4+Pj4+PiBpZWVlODAyMTFfaHcKPj4+ Pj4+Pj4+ICpodywKPj4+Pj4+Pj4+ICAJbG9ja2RlcF9hc3NlcnRfaGVsZCgmbG9jYWwtPmFjdGl2 ZV90eHFfbG9ja1t0eHEtPmFjXSk7Cj4+Pj4+Pj4+PiAKPj4+Pj4+Pj4+ICAJaWYgKCFSQl9FTVBU WV9OT0RFKCZ0eHFpLT5zY2hlZHVsZV9vcmRlcikgJiYKPj4+Pj4+Pj4+IC0JICAgIChza2JfcXVl dWVfZW1wdHkoJnR4cWktPmZyYWdzKSAmJgo+Pj4+Pj4+Pj4gIXR4cWktPnRpbi5iYWNrbG9nX3Bh Y2tldHMpKQo+Pj4+Pj4+Pj4gLQkJX19pZWVlODAyMTFfdW5zY2hlZHVsZV90eHEoaHcsIHR4cSk7 Cj4+Pj4+Pj4+PiArCQkhdHhxX2hhc19xdWV1ZSgmdHhxaS0+dHhxKSAmJgo+Pj4+Pj4+Pj4gKwkJ bGlzdF9lbXB0eSgmdHhxaS0+Y2FuZGlkYXRlKSkKPj4+Pj4+Pj4+ICsJCWxpc3RfYWRkX3RhaWwo JnR4cWktPmNhbmRpZGF0ZSwgCj4+Pj4+Pj4+PiAmbG9jYWwtPnJlbW92ZV9saXN0W3R4cS0+YWNd KTsKPj4+Pj4+Pj4+ICsKPj4+Pj4+Pj4+ICB9Cj4+Pj4+Pj4+PiAgRVhQT1JUX1NZTUJPTChpZWVl ODAyMTFfcmV0dXJuX3R4cSk7Cj4+Pj4+Pj4+PiAKPj4+Pj4+Pj4+ICt2b2lkIF9faWVlZTgwMjEx X2NoZWNrX3R4cXMoc3RydWN0IGllZWU4MDIxMV9sb2NhbCAqbG9jYWwsIGludAo+Pj4+Pj4+Pj4g YWMpCj4+Pj4+Pj4+PiArewo+Pj4+Pj4+Pj4gKwlzdHJ1Y3QgdHhxX2luZm8gKml0ZXIsICp0bXA7 Cj4+Pj4+Pj4+PiArCXN0cnVjdCBzdGFfaW5mbyAqc3RhOwo+Pj4+Pj4+Pj4gKwo+Pj4+Pj4+Pj4g Kwlsb2NrZGVwX2Fzc2VydF9oZWxkKCZsb2NhbC0+YWN0aXZlX3R4cV9sb2NrW2FjXSk7Cj4+Pj4+ Pj4+PiArCj4+Pj4+Pj4+PiArCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShpdGVyLCB0bXAsICZs b2NhbC0+cmVtb3ZlX2xpc3RbYWNdLAo+Pj4+Pj4+Pj4gKwkJCQkgY2FuZGlkYXRlKSB7Cj4+Pj4+ Pj4+PiArCQlzdGEgPSBjb250YWluZXJfb2YoaXRlci0+dHhxLnN0YSwgc3RydWN0IHN0YV9pbmZv LCBzdGEpOwo+Pj4+Pj4+Pj4gKwo+Pj4+Pj4+Pj4gKwkJaWYgKHR4cV9oYXNfcXVldWUoJml0ZXIt PnR4cSkpCj4+Pj4+Pj4+PiArCQkJbGlzdF9kZWxfaW5pdCgmaXRlci0+Y2FuZGlkYXRlKTsKPj4+ Pj4+Pj4+ICsJCWVsc2UKPj4+Pj4+Pj4+ICsJCQlpZWVlODAyMTFfcmVtb3ZlX3R4cSgmbG9jYWwt Pmh3LCAmaXRlci0+dHhxKTsKPj4+Pj4+Pj4+ICsJfQo+Pj4+Pj4+Pj4gK30KPj4+Pj4+Pj4+ICsK Pj4+Pj4+Pj4+ICt2b2lkIGllZWU4MDIxMV90eHFzX2NoZWNrKHN0cnVjdCB0aW1lcl9saXN0ICp0 KQo+Pj4+Pj4+Pj4gK3sKPj4+Pj4+Pj4+ICsJc3RydWN0IGllZWU4MDIxMV9sb2NhbCAqbG9jYWwg PSBmcm9tX3RpbWVyKGxvY2FsLCB0LAo+Pj4+Pj4+Pj4gcmVtb3ZlX3RpbWVyKTsKPj4+Pj4+Pj4+ ICsJc3RydWN0IHR4cV9pbmZvICppdGVyLCAqdG1wOwo+Pj4+Pj4+Pj4gKwlzdHJ1Y3Qgc3RhX2lu Zm8gKnN0YTsKPj4+Pj4+Pj4+ICsJaW50IGFjOwo+Pj4+Pj4+Pj4gKwo+Pj4+Pj4+Pj4gKwlmb3Ig KGFjID0gMDsgYWMgPCBJRUVFODAyMTFfTlVNX0FDUzsgYWMrKykgewo+Pj4+Pj4+Pj4gKwkJc3Bp bl9sb2NrX2JoKCZsb2NhbC0+YWN0aXZlX3R4cV9sb2NrW2FjXSk7Cj4+Pj4+Pj4+PiArCQlfX2ll ZWU4MDIxMV9jaGVja190eHFzKGxvY2FsLCBhYyk7Cj4+Pj4+Pj4+PiArCQlzcGluX3VubG9ja19i aCgmbG9jYWwtPmFjdGl2ZV90eHFfbG9ja1thY10pOwo+Pj4+Pj4+Pj4gKwl9Cj4+Pj4+Pj4+PiAr Cj4+Pj4+Pj4+PiArCW1vZF90aW1lcigmbG9jYWwtPnJlbW92ZV90aW1lciwKPj4+Pj4+Pj4+ICsJ CSAgamlmZmllcyArCj4+Pj4+Pj4+PiBtc2Vjc190b19qaWZmaWVzKElFRUU4MDIxMV9BSVJUSU1F X1RYUV9STV9DSEtfSU5UVl9JTl9NUykpOwo+Pj4+Pj4+Pj4gK30KPj4+Pj4+Pj4gCj4+Pj4+Pj4+ IEknbGwgYXNrIHRoZSBzYW1lIGFzIEkgZGlkIGxhc3QgdGltZSAod2hlcmUgeW91IHRvbGQgbWUg dG8gaG9sZCAKPj4+Pj4+Pj4gb2ZmCj4+Pj4+Pj4+IHVudGlsIHRoaXMgcm91bmQpOgo+Pj4+Pj4+ PiAKPj4+Pj4+Pj4gV2h5IGRvIHlvdSBuZWVkIHRoZSB0aW1lciBhbmQgdGhlIHBlcmlvZGljIGNo ZWNrPyBJZiBUWFFzIGFyZSAKPj4+Pj4+Pj4gYWRkZWQKPj4+Pj4+Pj4gdG8KPj4+Pj4+Pj4gdGhl IHJlbW92ZSBsaXN0IGR1cmluZyB0aGUgc2NoZWR1bGluZyBydW4sIGFuZAo+Pj4+Pj4+PiBfX2ll ZWU4MDIxMV9jaGVja190eHFzKCkKPj4+Pj4+Pj4gaXMgcnVuIGZyb20gc2NoZWR1bGVfZW5kKCks IGlzbid0IHRoYXQgc3VmZmljaWVudCB0byBjbGVhciB0aGUKPj4+Pj4+Pj4gbGlzdD8KPj4+Pj4+ PiBJcyBpdCBwb3NzaWJsZSB0aGF0IGEgdHhxIGlzIG5vdCBhZGRlZCB0byB0aGUgcmVtb3ZlIGxp c3QgYnV0IHRoZW4KPj4+Pj4+PiBwYWNrZXRzIGluIGl0IGFyZSBkcm9wcGVkIGJ5IGZxX2NvZGVs IGFsZ28/IExpa2UgdGhlIHN0YXRpb24KPj4+Pj4+PiBkaXNjb25uZWN0cwo+Pj4+Pj4+IHdpdGhv dXQgYW55IG5vdGlmaWNhdGlvbi4KPj4+Pj4+IAo+Pj4+Pj4gV2VsbCBhcyBsb25nIGFzIGFsbCB0 aGUgb3RoZXIgY2xlYW51cCBwYXRocyBjYWxsIGRpcmVjdGx5IGludG8KPj4+Pj4+IF9fdW5zY2hl ZHVsZV90eHEoKSwgdGhhdCBzaG91bGQgcmVtb3ZlIHN0YXRpb25zIGZyb20gdGhlIHNjaGVkdWxl cgo+Pj4+Pj4gd2hlbgo+Pj4+Pj4gdGhleSBkaXNjb25uZWN0IGV0Yy4KPj4+Pj4gWWVzLCB0aGUg ZGlzY29ubmVjdCBzY2VuYXJpbyBpcyBhIGJhZCBleGFtcGxlLiBNeSBjb25jZXJuIGlzLCBzYXks IAo+Pj4+PiB3ZQo+Pj4+PiBoYXZlIDEwIHN0YXRpb25zIGFuZCBvbmx5IG9uZSBvZiB0aGVtIGlz IGFzc2lnbmVkIGEgdmVyeSBzbWFsbCAKPj4+Pj4gd2VpZ2h0Cj4+Pj4+IGNvbXBhcmVkIHdpdGgg dGhhdCBvZiBvdGhlcnMuIFN1cHBvc2UsIGFmdGVyIGl0cyBjaGFuY2Ugb2YgVHgsIGl0IGlzCj4+ Pj4+IG1vc3QgbGlrZWx5IHRvIGJlIHBsYWNlZCBpbiB0aGUgcmlnaHRtb3N0KHN0aWxsIGhhcyBz b21lIHBhY2tldHMgaW4KPj4+Pj4gdGhlCj4+Pj4+IHR4cSkgYW5kIG5vIG1vcmUgaW5jb21pbmcg ZGF0YSBmb3IgaXQuIFRoZSByZW1haW5pbmcgcGFja2V0cyBpbiB0eHEKPj4+Pj4gd2lsbAo+Pj4+ PiBiZSBkcm9wcGVkIGR1ZSB0byB0aW1lb3V0IGFsZ28gaW4gY29kZWwoY29ycmVjdCBtZSBpZiBJ IGFtIHdyb25nKSAKPj4+Pj4gYnV0Cj4+Pj4+IHRoaXMgZW1wdHkgdHhxIHdpbGwgc3RheSBvbiB0 aGUgcmJ0cmVlIHVudGlsIG90aGVyIHR4cXMgZ2V0IGRyYWluZWQgCj4+Pj4+IG9yCj4+Pj4+IGds b2JhbCB2dCBjYXRjaCB1cCB3aXRoIGl0cyB2dC4gVGhlIHN0YXlpbmcgdGltZSBjb3VsZCBiZSBs b25nIGlmCj4+Pj4+IHdlaWdodAo+Pj4+PiBpcyBleHRyZW1lbHkgc21hbGwuIFRoZW4gZG8gd2Ug bmVlZCB0aW1lciB0byBjaGVjayBvciBhbnkgb3RoZXIgCj4+Pj4+IGJldHRlcgo+Pj4+PiBzb2x1 dGlvbj8KPj4+PiAKPj4+PiBBaCwgSSBzZWUgd2hhdCB5b3UgbWVhbi4gTm8sIEkgZG9uJ3QgdGhp bmsgdGhpcyB3aWxsIGJlIGEgcHJvYmxlbTsgCj4+Pj4gdGhlCj4+Pj4gc2NlbmFyaW8geW91J3Jl IGRlc2NyaWJpbmcgd291bGQgcGxheSBvdXQgbGlrZSB0aGlzOgo+Pj4+IAo+Pj4+IDEuIFN0YXRp b24gZW5kcyB0cmFuc21pdHRpbmcsIHN0aWxsIGhhcyBhIHNpbmdsZSBwYWNrZXQgcXVldWVkLCBn ZXRzCj4+Pj4gICAgbW92ZWQgdG8gdGhlIGVuZCBvZiB0aGUgcmJ0cmVlIChhbmQgc3RheXMgdGhl cmUgZm9yIGEgd2hpbGUpLgo+Pj4+IAo+Pj4+IDIuIFdoZW4gd2UgZmluYWxseSBnZXQgdG8gdGhl IHBvaW50IHdoZXJlIHRoaXMgc3RhdGlvbiBnZXRzIGFub3RoZXIKPj4+PiAgICBjaGFuY2UgdG8g dHJhbnNtaXQsIHRoZSBDb0RlbCBkcm9wIHRpbWVyIHRyaWdnZXJzIGFuZCB0aGUgbGFzdAo+Pj4+ IHBhY2tldAo+Pj4+ICAgIGlzIGRyb3BwZWRbMF0uIFRoaXMgbWVhbnMgdGhhdCB0aGUgcXVldWUg d2lsbCBqdXN0IGJlIGVtcHR5Cj4+Pj4gICAgKGFuZCBpZWVlODAyMTFfdHhfZGVxdWV1ZSgpIHdp bGwgcmV0dXJuIE5VTEwpLgo+Pj4+IAo+Pj4+IDMuIEJlY2F1c2UgdGhlIHF1ZXVlIGlzIGVtcHR5 LCBpZWVlODAyMTFfcmV0dXJuX3R4cSgpIHdpbGwgbm90IHB1dCBpdAo+Pj4+ICAgIGJhY2sgb24g dGhlIHJidHJlZS4KPj4+PiAKPj4+PiBDcnVjaWFsbHksIGluIDIuIHRoZSBDb0RlbCBhbGdvcml0 aG0gZG9lc24ndCBraWNrIGluIHVudGlsIHRoZSBwb2ludCAKPj4+PiBvZgo+Pj4+IHBhY2tldCBk ZXF1ZXVlLiBCdXQgZXZlbiBpZiBhbiBlbXB0eSBxdWV1ZSBzdGF5cyBvbiB0aGUgcmJ0cmVlIGZv ciBhCj4+Pj4gd2hpbGUsIHRoZXJlIGlzIG5vIGhhcm0gaW4gdGhhdDogZXZlbnR1YWxseSBpdCB3 aWxsIGdldCBpdHMgdHVybiwgaXQKPj4+PiB3aWxsIHR1cm4gb3V0IHRvIGJlIGVtcHR5LCBhbmQg anVzdCBiZSBza2lwcGVkIG92ZXIuCj4+PiBUaGVuIHRoYXQgd2lsbCBiZSBmaW5lLiBUaGFua3Mg Zm9yIHRoZSBleHBsYW5hdGlvbiBvZiB0aGUgZHJvcHBpbmcgCj4+PiBwYXJ0Cj4+PiBpbiBDb0Rl bCBhbGdvcml0aG0uCj4+IAo+PiBZdXAsIHRoaW5rIHNvLiBBbmQgeW91J3JlIHdlbGNvbWUgOikK Pj4gCj4+Pj4gVGhlIGlzc3VlIHdlIG5lZWQgdG8gYmUgY29uY2VybmVkIGFib3V0IGlzIHRoZSBv cHBvc2l0ZTogSWYgd2UgaGF2ZSBhCj4+Pj4gcXVldWUgdGhhdCAqZG9lcyogaGF2ZSBwYWNrZXRz IHF1ZXVlZCwgYnV0IHdoaWNoIGlzICpub3QqIHNjaGVkdWxlZCAKPj4+PiBmb3IKPj4+PiB0cmFu c21pc3Npb24sIHRoYXQgd2lsbCBzdGFsbCBUWC4KPj4+IElzIGl0IGJ5IGRlc2lnbiBzaW5jZSBp dHMgdnQgaXMgbW9yZSB0aGFuIGdsb2JhbCB2dCwgcmlnaHQ/IFRoZSAKPj4+IGxhdHRlbmN5Cj4+ PiBtYXkgc29tZWhvdyBnZXQgaW1wYWN0ZWQgdGhvdWdoLgo+PiAKPj4gV2VsbCwgaXQgc2hvdWxk IHN0aWxsIHN0YXkgb24gdGhlIHJidHJlZSBhcyBsb25nIGFzIGl0IGhhcyBwYWNrZXRzCj4+IHF1 ZXVlZC4gV2UgZG9uJ3QgaGF2ZSBhIGNoZWNrIGFueXdoZXJlIHRoYXQgcmVzY2hlZHVsZXMgVFhR cyB3aG9zZSB2X3QKPj4gZHJvcHMgYmVsb3cgZ2xvYmFsIHZfdC4uLgo+PiAKPj4+PiBbMF0gQ29E ZWwgaW4gbW9zdCBjYXNlcyBvbmx5IGRyb3BzIGEgc2luZ2xlIHBhY2tldCBhdCBhIHRpbWUsIHNv IGl0Cj4+Pj4gd2lsbAo+Pj4+IG5vdCBjbGVhciBvdXQgYW4gZW50aXJlIHF1ZXVlIHdpdGggbXVs dGlwbGUgcGFja2V0cyBpbiBvbmUgZ28uIEJ1dCAKPj4+PiB5b3UKPj4+PiBhcmUgcmlnaHQgdGhh dCBpdCBjb3VsZCBjb25jZWl2YWJseSBkcm9wIHRoZSBsYXN0IHBhY2tldCBpbiBhIHF1ZXVlLgo+ Pj4+IAo+Pj4+Pj4gV2Ugb25seSBuZWVkIHRvIGRlZmVyIHJlbW92YWwgaW5zaWRlIGEgc2luZ2xl ICJzY2hlZHVsaW5nIHJvdW5kIgo+Pj4+Pj4gKGkuZS4sCj4+Pj4+PiBiZXR3ZWVuIGEgcGFpciBv ZiBpZWVlODAyMTFfdHhxX3NjaGVkdWxlX3N0YXJ0L2VuZC4gU28gaWYgd2UganVzdAo+Pj4+Pj4g d2Fsawo+Pj4+Pj4gdGhlIHJlbW92ZSBsaXN0IGluIHNjaGVkdWxlX2VuZCgpIHdlIHNob3VsZCBi ZSBlbm91Z2gsIG5vPwo+Pj4+Pj4gCj4+Pj4+PiBIbW0sIG9yIG1heWJlIGEgc2ltcGxlciB3YXkg dG8gZml4IHRoZSBvcmlnaW5hbCBpc3N1ZSBpcyBqdXN0IHRvIAo+Pj4+Pj4gaGF2ZQo+Pj4+Pj4g dW5zY2hlZHVsZV90eHEoKSB1cGRhdGUgdGhlIHNjaGVkdWxlX3BvcygpIHBvaW50ZXI/Cj4+Pj4+ PiAKPj4+Pj4+IEkuZS4sIHVuc2NoZWR1bGVfdHhxIGNoZWNrcyBpZiB0aGUgdHhxIGJlaW5nIHJl bW92ZWQgaXMgY3VycmVudGx5Cj4+Pj4+PiBiZWluZwo+Pj4+Pj4gcG9pbnRlZCB0byBieSBzY2hl ZHVsZV9wb3NbYWNdLCBhbmQgaWYgaXQgaXMsIGl0IHVwZGF0ZXMgCj4+Pj4+PiBzY2hlZHVsZV9w b3MKPj4+Pj4+IHRvCj4+Pj4+PiBiZSB0aGUgcmJfbmV4dCBvZiB0aGUgY3VycmVudCB2YWx1ZT8K Pj4+Pj4gQWN0dWFsbHksIGlmIHNjaGVkdWxlX3BvcyBpcyB1cGRhdGVkIHRvIHJiX25leHQgb2Yg dGhlIGN1cnJlbnQgCj4+Pj4+IHZhbHVlLAo+Pj4+PiB0aGVuIGluIHRoZSBuZXh0X3R4cSgpIHdo ZXJlIHdlIGFyZSBnb2luZyB0byB1c2UgcmJfbmV4dCBhZ2FpbiBhbmQKPj4+Pj4gZmluYWxseSBw aWNrIHRoZSBuZXh0IG5vZGUgb2YgdGhlIG5vZGUgd2UgcmVhbGx5IHdhbnQuIElzIGl0IGZpbmUg dG8KPj4+Pj4gdXBkYXRlIHNjaGVkdWxlX3BvcyB0byBOVUxMPwo+Pj4+IAo+Pj4+IEhtbSwgeWVh aCwgZ29vZCBwb2ludC4KPj4+PiAKPj4+PiBJZiB3ZSBkbyBlbmQgdXAgc2V0dGluZyBzY2hlZHVs ZV9wb3MgdG8gTlVMTCBpbiB0aGUgbWlkZGxlIG9mIGEKPj4+PiBzY2hlZHVsaW5nIHJvdW5kLCB0 aGF0IHdpbGwgbWFrZSBuZXh0X3R4cSgpICJzdGFydCBvdmVyIiwgYW5kIGRvCj4+Pj4gYW5vdGhl cgo+Pj4+IGxvb3AgdGhyb3VnaCB0aGUgd2hvbGUgdGhpbmcuIEkgZ3Vlc3Mgd2UgbWF5IGJlIGFi bGUgaGl0IGEgY2FzZSB3aGVyZQo+Pj4+IHRoaW5ncyBjYW4gb3NjaWxsYXRlIGJhY2sgYW5kIGZv cnRoIGJldHdlZW4gYWRkaXRpb24gYW5kIHJlbW92YWwKPj4+PiByZXN1bHRpbmcgaW4gYW4gaW5m aW5pdGUgbG9vcD8gTm90IHN1cmUsIGJ1dCBhdCBsZWFzdCBJIGNhbid0IHNlZW0gdG8KPj4+PiBj b252aW5jZSBteXNlbGYgdGhhdCB0aGlzIGNhbid0IGhhcHBlbi4KPj4+IAo+Pj4gQXMgdGhlIGxv b3Agb2YgbmV4dF90eHEgdW5kZXIgbG9jayBwcm90ZWN0aW9uIGFzIGJlbG93LAo+Pj4gCj4+PiB0 eHFfc2NoZWR1bGVfc3RhcnQoKTsKPj4+IHdoaWxlKHR4cT1uZXh0X3R4cSgpKXsKPj4+IC4uLgo+ Pj4gcmV0dXJuX3R4cSh0eHEpOwo+Pj4gfQo+Pj4gdHhxX3NjaGVkdWxlX2VuZCgpOwo+Pj4gCj4+ PiBJIGRvIG5vdCBzZWUgYW55IGNoYW5jZSBvZiBhZGRpdGlvbiwgbm8/Cj4+IAo+PiBBcyB5b3Ug bm90ZWQgaW4geW91ciBvdGhlciBlbWFpbCwgRmVsaXggcmVkdWNlZCB0aGUgbG9ja2luZy4gQW5k IHllYWgsCj4+IHdlIG5lZWQgdG8gcmViYXNlIHRoaXMgc2VyaWVzIHRvIGFsc28gaW5jb3Jwb3Jh dGUgdGhhdC4gSSBmaWd1cmUgSSBjYW4KPj4gc2VuZCBhbiB1cGRhdGVkIHZlcnNpb24gb2YgdGhl IGZpcnN0IHBhdGNoIGluIHRoZSBzZXJpZXMgb25jZSB3ZSd2ZQo+PiB3b3JrZWQgb3V0IHRoZSBy ZW1haW5pbmcgaXNzdWVzIHdpdGggeW91ciBmb2xsb3ctdXAgcGF0Y2hlcy4KPj4gCj4gT2gsIEkg d2FzIHRoaW5raW5nIHdlIHdlcmUgZGlzY3Vzc2luZyB3aXRob3V0IGxvY2tpbmcgcmVkdWNlZC4g WWVzLCBJIAo+IGFsc28gYWdyZWUgdGhlcmUgbWlnaHQgYmUgYSBjYXNlIGNhdXNpbmcgaW5maW5p dGUgbG9vcC4gV2l0aCBsb2NraW5nIAo+IHJlZHVjZWQsIHRoZSB0cmVlIGNhbiBiZSBhZGp1c3Rl ZCBiZXR3ZWVuIG5leHRfdHhxKCkgYW5kIHJldHVybl90eHEoKSBpbiAKPiB0aGUgbG9vcCBzaXR1 YXRpb24uIEZvciBmdXJ0aGVyIGRpc2N1c3Npb24sIGxldCAncyBjb25zaWRlciwKPiAxKSB0aGUg dHJlZSBzdGFydHMgbGlrZToKPiAgICAgICAgIEEtPkItPkMtPkQtPkUKPiAyKSB0aGVuIG5leHRf dHhxKCkgcmV0dXJucyBBIGZvciBkZXF1ZXVpbmcKPiAzKSBkcml2ZXIgZGVxdWV1ZXMgQSBhbmQg ZHJhaW5lcyBBIHdpdGhvdXQgYW55IGFjdGl2ZSB0eHEgbG9ja2VkIG1lYW5pbmcgCj4gdGhlIHRy ZWUgY291bGQgYmUgY2hhbmdlZCB1cG9uIFR4IGNvbXBlbGV0aW9uLgo+IDQpIHRoZW4gaW4gcmV0 dXJuX3R4cSgpLCB0aGUgdHJlZSBjb3VsZCBiZSwKPiAgICAgICAgIGkgICBBLT5CLT5DLT5ELT5F IO+8iEEgaXMgZW1wdHksIGFuZCBtYXliZSBzb29uIGJlIGFkZGVkIGJhY2sgCj4gYmVmb3JlIHRo ZSBsb29wIGVuZO+8iQo+ICAgICAgICAgaWkgIEItPkMtPkEtPkQtPkUg77yIQSBpcyBlbXB0eSwg YW5kIG1heWJlIHNvb24gYmUgYWRkZWQgYmFjayAKPiBiZWZvcmUgdGhlIGxvb3AgZW5k77yJCj4g ICAgICAgICBpaWkgQi0+Qy0+RC0+RS0+QSDvvIhBIGlzIGVtcHR5LCBhbmQgbWF5YmUgc29vbiBi ZSBhZGRlZCBiYWNrIAo+IGJlZm9yZSB0aGUgbG9vcCBlbmQpCj4KPiB3aXRoIHRoaXMgY2hhbmdl Ogo+ICAgbG9jYWwtPnNjaGVkdWxlX3Bvc1thY10gPSByYl9uZXh0KG5vZGUpID86IHJiX3ByZXYo bm9kZSk7Cj4KPiBmb3IgY2FzZSBpLCBsb2NhbC0+c2NoZWR1bGVfcG9zW2FjXSBpcyByYl9uZXh0 KEEpIHdoaWNoIGlzIEIsIGFuZCBpbiAKPiBuZXh0X3R4cSgpLCByYl9uZXh0KEIpIGlzIHdoYXQg d2UgcmV0dXJucyB3aGljaCBhY3R1YWxseSBpcyBDIGFuZCBCIGlzIAo+IHNraXBwZWQsIG5vPwo+ Cj4gU2ltaWxpYXIgZm9yIGNhc2UgaWksIHdlIHNraXAgQiwgQywgRC4KCll1cCwgSSB0aGluayB5 b3UncmUgcmlnaHQuIEJ1dCBpZiB3ZSBjYW4gZml4IHRoaXMgYnkgbWFraW5nCmllZWU4MDIxMV9y ZXNvcnRfdHhxKCkgYXdhcmUgb2YgdGhlIHNjaGVkdWxlX3BvcyBhcyB3ZWxsLCBubz8gSS5lLiwg aWYKcmVzb3J0X3R4cSgpIGFjdHMgb24gdGhlIHR4cSB0aGF0J3MgY3VycmVudGx5IGluIHNjaGVk dWxlX3BvcywgaXQgd2lsbAp1cGRhdGUgc2NoZWR1bGUgcG9zIHdpdGggdGhlIHNhbWUgcmJfbmV4 dChub2RlKSA/OiByYl9wcmV2KG5vZGUpOwoob3B0aW9uYWxseSBhZnRlciBjaGVja2luZyB0aGF0 IHRoZSBwb3NpdGlvbiBvZiB0aGUgbm9kZSBpcyBhY3R1YWxseQpnb2luZyB0byBjaGFuZ2UpLgoK PiBBbHNvIEkgYW0gd29uZGVyaW5nIGlmIHRoZXJlIHdpbGwgYmUgc29tZSBTTVAgaXNzdWVzIHJl bGF0aW5nIHdpdGggCj4gbG9jYWwtPnNjaGVkdWxlX3Bvc1thY10uCgpOb3Qgc3VyZSB3aGF0IHlv dSBtZWFuIGJ5IHRoaXM/Cgo+Pj4gSW4gYXRoMTBrLCB3ZSB3aWxsIHVzdWFsbHkgcHVzaCBwYWNr ZXRzIG9mIGZpcnN0IHR4cSBhcyBtYW55IGFzIHdlIGNhbgo+Pj4gdW50aWwgaXQgaXMgZHJhaW5l ZCBhbmQgdGhlbiBtb3ZlIHRvIHRoZSBuZXh0IG9uZS4gU28gaWYgYSB0eHEgZ2V0cwo+Pj4gcmVt b3ZlZCBpbiB0aGUgcmV0dXJuX3R4cSwgaXQgc2hvdWxkIGFsd2F5cyBiZSB0aGUgbGVmdG1vc3Qu IEFuZAo+Pj4gZHVyaW5nIHRoaXMgcGVyaW9kLCBuZWl0aGVyIHZ0IG9mIGFueSBzdGF0aW9uIG9y IGdsb2JhbCB2dCBjYW4gYmUKPj4+IHVwZGF0ZWQgZHVlIHRvIGxvY2sgcHJvdGVjdGlvbi4KPj4+ IAo+Pj4+IAo+Pj4+IEJ1dCBpbiB0aGF0IGNhc2UsIHdlIGNvdWxkIGZpeCBpdCBieSBqdXN0IGNv bmRpdGlvbmFsbHkgYXNzaWduaW5nCj4+Pj4gZWl0aGVyCj4+Pj4gcmJfbmV4dCBvciByYl9wcmV2 IHRvIHRoZSBzY2hlZHVsZV9wb3MgaW4gdW5zY2hlZHVsZV90eHEoKT8gSS5lLiwKPj4+PiBzb21l dGhpbmcgbGlrZToKPj4+PiAKPj4+PiBsb2NhbC0+c2NoZWR1bGVfcG9zW2FjXSA9IHJiX25leHQo bm9kZSkgPzogcmJfcHJldihub2RlKTsKPj4+IEkgYW0gbm90IHN1cmUgSSBhbSBnZXR0aW5nIHlv dXIgcG9pbnQuIFN0aWxsIGluIG5leHRfdHhxLAo+Pj4gc2NoZWR1bGVfcG9zW2FjXSB3aWxsIGxl YWQgdXMgdG8gdGhlIG5leHQgbm9kZSBvZiB0aGUgb25lIHdlIHdhbnQuCj4+IAo+PiBUaGUgbG9n aWMgaW4gbmV4dF90eHEgaXMgZGlmZmVyZW50IHdoZW4gc2NoZWR1bGVfcG9zW2FjXSBpcyBOVUxM LCB2cwo+PiB3aGVuIHJiX25leHQoc2NoZWR1bGVfcG9zW2FjXSkgaXMgTlVMTC4gVGhlIGZvcm1l ciByZXN0YXJ0cyBhIG5ldwo+PiBzY2hlZHVsaW5nIHJvdW5kLCB3aGlsZSB0aGUgbGF0dGVyIGVu ZHMgdGhlIGN1cnJlbnQgcm91bmQuCj4+IAo+PiAtVG9rZQo+Cj4gLS0gCj4gWWlibwoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5n IGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95EB3C49ED7 for ; Sat, 21 Sep 2019 11:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 485B4217F5 for ; Sat, 21 Sep 2019 11:35:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VprQckjc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407579AbfIULff (ORCPT ); Sat, 21 Sep 2019 07:35:35 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:30459 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2407573AbfIULff (ORCPT ); Sat, 21 Sep 2019 07:35:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1569065733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HVdy21ZEB5CVcmBhd014+fMe37WVhrwZWRadCL+pTXQ=; b=VprQckjcBQ6TasCb93NHiaME/Xn7Vn+EjZrNwWgQnSGLYRKCh7ImfhtvsnLRQk0TdjWPA4 MnAUH+64HcsuJeC4+KiKAGhBEtiurSMrzA0IKSGkKuda2JPgxFmp+8xMZiJ4clmbBsdQ2c W8s34SsZr09f1GR49D5iqsKN02rsVkk= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-217-kgyF2garMhCfmWaVgDqshg-1; Sat, 21 Sep 2019 07:35:32 -0400 Received: by mail-ed1-f71.google.com with SMTP id h12so5902400eda.19 for ; Sat, 21 Sep 2019 04:35:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=Aqls8CCvXkwoNDeZptURR0uwdkCHASGFWfhyXbmPEQI=; b=OIPUgCk0zdoRnVsBOm2UVLAmHJIvmR2lOdv040ZSFLy/lfoFjBhu3KWyaY3ve98tSJ dsArmW7tAlFXNrNKZFiCIxuno+grE2vyMut7U8q+h8beogtO2I7mBmZbqrWVexQjcRd8 NvDeWiGhxO6vE4DB1FaEHyfA6LaS8Gn5sMf978b1iil4JEGpDnK71/EQjfCVSu2u9xHG NUQaxv7wuOsY16FKtnGfDwu2qWXFTK9jxEXYpGUX0c4vDCEACZct9xVxV50sfNdWMOfo Nyab29oNywMcnBZYT/Ivhuf96O1ONQbJOTXGxD5QhFKQ4delFAEVop/3myDTGsNqTe0R aZDg== X-Gm-Message-State: APjAAAXAWF8gGczpowLhMZirDHK7KLi/UOXlWxa/3cvPIC2gxArfI7TR ah4QXWgDZl5LIQRyWDiOop9xJ0Os5MwLPnNsJHtMPBmwosYLk3Y9fJAjlVBYwoUjfKcM//m8KrB uL8k2gPJTRomlHgpRV5m/oCFa0bY= X-Received: by 2002:a17:906:1ed1:: with SMTP id m17mr22485744ejj.82.1569065730936; Sat, 21 Sep 2019 04:35:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqxWzSz/5YiXG+yolMo39ELnl8Bt/OLp4zJ/uOJxe8OxIQNv9B5wOeKNxyD9YLHLdg9qECGGQQ== X-Received: by 2002:a17:906:1ed1:: with SMTP id m17mr22485717ejj.82.1569065730501; Sat, 21 Sep 2019 04:35:30 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id q33sm947739eda.60.2019.09.21.04.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Sep 2019 04:35:29 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 7C4E718063F; Sat, 21 Sep 2019 13:27:00 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Yibo Zhao Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH 2/4] mac80211: defer txqs removal from rbtree In-Reply-To: <198124204167325252fcfcd65e3f2733@codeaurora.org> References: <1568639388-27291-1-git-send-email-yiboz@codeaurora.org> <1568639388-27291-2-git-send-email-yiboz@codeaurora.org> <87pnjyiq7o.fsf@toke.dk> <87sgothmpy.fsf@toke.dk> <8cdece5c030fd95817fb099021c38613@codeaurora.org> <87tv98fu6l.fsf@toke.dk> <1b4ab006d9b5c88035845aaac193ef48@codeaurora.org> <8736gre3bm.fsf@toke.dk> <198124204167325252fcfcd65e3f2733@codeaurora.org> X-Clacks-Overhead: GNU Terry Pratchett Date: Sat, 21 Sep 2019 13:27:00 +0200 Message-ID: <87ftkp7uuz.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: kgyF2garMhCfmWaVgDqshg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Yibo Zhao writes: > On 2019-09-20 17:15, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> Yibo Zhao writes: >>=20 >>> On 2019-09-19 18:37, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>> Yibo Zhao writes: >>>>=20 >>>>> On 2019-09-18 19:23, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>>>> Yibo Zhao writes: >>>>>>=20 >>>>>>> On 2019-09-18 05:10, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>>>>>> Yibo Zhao writes: >>>>>>>>=20 >>>>>>>>> In a loop txqs dequeue scenario, if the first txq in the rbtree >>>>>>>>> gets >>>>>>>>> removed from rbtree immediately in the ieee80211_return_txq(),=20 >>>>>>>>> the >>>>>>>>> loop will break soon in the ieee80211_next_txq() due to >>>>>>>>> schedule_pos >>>>>>>>> not leading to the second txq in the rbtree. Thus, defering the >>>>>>>>> removal right before the end of this schedule round. >>>>>>>>>=20 >>>>>>>>> Co-developed-by: Yibo Zhao >>>>>>>>> Signed-off-by: Yibo Zhao >>>>>>>>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >>>>>>>>=20 >>>>>>>> I didn't write this patch, so please don't use my sign-off. I'll >>>>>>>> add >>>>>>>> ack or review tags as appropriate in reply; but a few comments >>>>>>>> first: >>>>>>>>=20 >>>>>>>>> --- >>>>>>>>> include/net/mac80211.h | 16 ++++++++++-- >>>>>>>>> net/mac80211/ieee80211_i.h | 3 +++ >>>>>>>>> net/mac80211/main.c | 6 +++++ >>>>>>>>> net/mac80211/tx.c | 63 >>>>>>>>> +++++++++++++++++++++++++++++++++++++++++++--- >>>>>>>>> 4 files changed, 83 insertions(+), 5 deletions(-) >>>>>>>>>=20 >>>>>>>>> diff --git a/include/net/mac80211.h b/include/net/mac80211.h >>>>>>>>> index ac2ed8e..ba5a345 100644 >>>>>>>>> --- a/include/net/mac80211.h >>>>>>>>> +++ b/include/net/mac80211.h >>>>>>>>> @@ -925,6 +925,8 @@ struct ieee80211_tx_rate { >>>>>>>>>=20 >>>>>>>>> #define IEEE80211_MAX_TX_RETRY=09=0931 >>>>>>>>>=20 >>>>>>>>> +#define IEEE80211_AIRTIME_TXQ_RM_CHK_INTV_IN_MS 100 >>>>>>>>> + >>>>>>>>> static inline void ieee80211_rate_set_vht(struct >>>>>>>>> ieee80211_tx_rate >>>>>>>>> *rate, >>>>>>>>> =09=09=09=09=09 u8 mcs, u8 nss) >>>>>>>>> { >>>>>>>>> @@ -6232,7 +6234,8 @@ struct sk_buff=20 >>>>>>>>> *ieee80211_tx_dequeue(struct >>>>>>>>> ieee80211_hw *hw, >>>>>>>>> * @ac: AC number to return packets from. >>>>>>>>> * >>>>>>>>> * Should only be called between calls to >>>>>>>>> ieee80211_txq_schedule_start() >>>>>>>>> - * and ieee80211_txq_schedule_end(). >>>>>>>>> + * and ieee80211_txq_schedule_end(). If the txq is empty, it=20 >>>>>>>>> will >>>>>>>>> be >>>>>>>>> added >>>>>>>>> + * to a remove list and get removed later. >>>>>>>>> * Returns the next txq if successful, %NULL if no queue is >>>>>>>>> eligible. >>>>>>>>> If a txq >>>>>>>>> * is returned, it should be returned with=20 >>>>>>>>> ieee80211_return_txq() >>>>>>>>> after the >>>>>>>>> * driver has finished scheduling it. >>>>>>>>> @@ -6268,7 +6271,8 @@ void ieee80211_txq_schedule_start(struct >>>>>>>>> ieee80211_hw *hw, u8 ac) >>>>>>>>> * @hw: pointer as obtained from ieee80211_alloc_hw() >>>>>>>>> * @ac: AC number to acquire locks for >>>>>>>>> * >>>>>>>>> - * Release locks previously acquired by >>>>>>>>> ieee80211_txq_schedule_end(). >>>>>>>>> + * Release locks previously acquired by >>>>>>>>> ieee80211_txq_schedule_end(). >>>>>>>>> Check >>>>>>>>> + * and remove the empty txq from rb-tree. >>>>>>>>> */ >>>>>>>>> void ieee80211_txq_schedule_end(struct ieee80211_hw *hw, u8 ac) >>>>>>>>> =09__releases(txq_lock); >>>>>>>>> @@ -6287,6 +6291,14 @@ void ieee80211_schedule_txq(struct >>>>>>>>> ieee80211_hw >>>>>>>>> *hw, struct ieee80211_txq *txq) >>>>>>>>> =09__acquires(txq_lock) __releases(txq_lock); >>>>>>>>>=20 >>>>>>>>> /** >>>>>>>>> + * ieee80211_txqs_check - Check txqs waiting for removal >>>>>>>>> + * >>>>>>>>> + * @tmr: pointer as obtained from local >>>>>>>>> + * >>>>>>>>> + */ >>>>>>>>> +void ieee80211_txqs_check(struct timer_list *tmr); >>>>>>>>> + >>>>>>>>> +/** >>>>>>>>> * ieee80211_txq_may_transmit - check whether TXQ is allowed to >>>>>>>>> transmit >>>>>>>>> * >>>>>>>>> * This function is used to check whether given txq is allowed= =20 >>>>>>>>> to >>>>>>>>> transmit by >>>>>>>>> diff --git a/net/mac80211/ieee80211_i.h >>>>>>>>> b/net/mac80211/ieee80211_i.h >>>>>>>>> index a4556f9..49aa143e 100644 >>>>>>>>> --- a/net/mac80211/ieee80211_i.h >>>>>>>>> +++ b/net/mac80211/ieee80211_i.h >>>>>>>>> @@ -847,6 +847,7 @@ struct txq_info { >>>>>>>>> =09struct codel_stats cstats; >>>>>>>>> =09struct sk_buff_head frags; >>>>>>>>> =09struct rb_node schedule_order; >>>>>>>>> +=09struct list_head candidate; >>>>>>>>> =09unsigned long flags; >>>>>>>>>=20 >>>>>>>>> =09/* keep last! */ >>>>>>>>> @@ -1145,6 +1146,8 @@ struct ieee80211_local { >>>>>>>>> =09u64 airtime_v_t[IEEE80211_NUM_ACS]; >>>>>>>>> =09u64 airtime_weight_sum[IEEE80211_NUM_ACS]; >>>>>>>>>=20 >>>>>>>>> +=09struct list_head remove_list[IEEE80211_NUM_ACS]; >>>>>>>>> +=09struct timer_list remove_timer; >>>>>>>>> =09u16 airtime_flags; >>>>>>>>>=20 >>>>>>>>> =09const struct ieee80211_ops *ops; >>>>>>>>> diff --git a/net/mac80211/main.c b/net/mac80211/main.c >>>>>>>>> index e9ffa8e..78fe24a 100644 >>>>>>>>> --- a/net/mac80211/main.c >>>>>>>>> +++ b/net/mac80211/main.c >>>>>>>>> @@ -667,10 +667,15 @@ struct ieee80211_hw >>>>>>>>> *ieee80211_alloc_hw_nm(size_t priv_data_len, >>>>>>>>>=20 >>>>>>>>> =09for (i =3D 0; i < IEEE80211_NUM_ACS; i++) { >>>>>>>>> =09=09local->active_txqs[i] =3D RB_ROOT_CACHED; >>>>>>>>> +=09=09INIT_LIST_HEAD(&local->remove_list[i]); >>>>>>>>> =09=09spin_lock_init(&local->active_txq_lock[i]); >>>>>>>>> =09} >>>>>>>>> =09local->airtime_flags =3D AIRTIME_USE_TX | AIRTIME_USE_RX; >>>>>>>>>=20 >>>>>>>>> +=09timer_setup(&local->remove_timer, ieee80211_txqs_check, 0); >>>>>>>>> +=09mod_timer(&local->remove_timer, >>>>>>>>> +=09=09 jiffies + >>>>>>>>> msecs_to_jiffies(IEEE80211_AIRTIME_TXQ_RM_CHK_INTV_IN_MS)); >>>>>>>>> + >>>>>>>>> =09INIT_LIST_HEAD(&local->chanctx_list); >>>>>>>>> =09mutex_init(&local->chanctx_mtx); >>>>>>>>>=20 >>>>>>>>> @@ -1305,6 +1310,7 @@ void ieee80211_unregister_hw(struct >>>>>>>>> ieee80211_hw >>>>>>>>> *hw) >>>>>>>>> =09tasklet_kill(&local->tx_pending_tasklet); >>>>>>>>> =09tasklet_kill(&local->tasklet); >>>>>>>>>=20 >>>>>>>>> +=09del_timer_sync(&local->remove_timer); >>>>>>>>> #ifdef CONFIG_INET >>>>>>>>> =09unregister_inetaddr_notifier(&local->ifa_notifier); >>>>>>>>> #endif >>>>>>>>> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c >>>>>>>>> index d00baaa..42ca010 100644 >>>>>>>>> --- a/net/mac80211/tx.c >>>>>>>>> +++ b/net/mac80211/tx.c >>>>>>>>> @@ -1450,6 +1450,7 @@ void ieee80211_txq_init(struct >>>>>>>>> ieee80211_sub_if_data *sdata, >>>>>>>>> =09codel_stats_init(&txqi->cstats); >>>>>>>>> =09__skb_queue_head_init(&txqi->frags); >>>>>>>>> =09RB_CLEAR_NODE(&txqi->schedule_order); >>>>>>>>> +=09INIT_LIST_HEAD(&txqi->candidate); >>>>>>>>>=20 >>>>>>>>> =09txqi->txq.vif =3D &sdata->vif; >>>>>>>>>=20 >>>>>>>>> @@ -3724,6 +3725,9 @@ void ieee80211_schedule_txq(struct >>>>>>>>> ieee80211_hw >>>>>>>>> *hw, >>>>>>>>>=20 >>>>>>>>> =09spin_lock_bh(&local->active_txq_lock[ac]); >>>>>>>>>=20 >>>>>>>>> +=09if (!list_empty(&txqi->candidate)) >>>>>>>>> +=09=09list_del_init(&txqi->candidate); >>>>>>>>> + >>>>>>>>> =09if (!RB_EMPTY_NODE(&txqi->schedule_order)) >>>>>>>>> =09=09goto out; >>>>>>>>>=20 >>>>>>>>> @@ -3783,6 +3787,20 @@ static void >>>>>>>>> __ieee80211_unschedule_txq(struct >>>>>>>>> ieee80211_hw *hw, >>>>>>>>> =09RB_CLEAR_NODE(&txqi->schedule_order); >>>>>>>>> } >>>>>>>>>=20 >>>>>>>>> +void ieee80211_remove_txq(struct ieee80211_hw *hw, >>>>>>>>> +=09=09=09 struct ieee80211_txq *txq) >>>>>>>>> +{ >>>>>>>>> +=09struct ieee80211_local *local =3D hw_to_local(hw); >>>>>>>>> +=09struct txq_info *txqi =3D to_txq_info(txq); >>>>>>>>> + >>>>>>>>> +=09lockdep_assert_held(&local->active_txq_lock[txq->ac]); >>>>>>>>> + >>>>>>>>> +=09if (!RB_EMPTY_NODE(&txqi->schedule_order)) { >>>>>>>>> +=09=09__ieee80211_unschedule_txq(hw, txq); >>>>>>>>> +=09=09list_del_init(&txqi->candidate); >>>>>>>>> +=09} >>>>>>>>> +} >>>>>>>>> + >>>>>>>>> void ieee80211_unschedule_txq(struct ieee80211_hw *hw, >>>>>>>>> =09=09=09 struct ieee80211_txq *txq) >>>>>>>>> =09__acquires(txq_lock) __releases(txq_lock) >>>>>>>>> @@ -3790,7 +3808,7 @@ void ieee80211_unschedule_txq(struct >>>>>>>>> ieee80211_hw *hw, >>>>>>>>> =09struct ieee80211_local *local =3D hw_to_local(hw); >>>>>>>>>=20 >>>>>>>>> =09spin_lock_bh(&local->active_txq_lock[txq->ac]); >>>>>>>>> -=09__ieee80211_unschedule_txq(hw, txq); >>>>>>>>> +=09ieee80211_remove_txq(hw, txq); >>>>>>>>> =09spin_unlock_bh(&local->active_txq_lock[txq->ac]); >>>>>>>>> } >>>>>>>>>=20 >>>>>>>>> @@ -3803,11 +3821,48 @@ void ieee80211_return_txq(struct >>>>>>>>> ieee80211_hw >>>>>>>>> *hw, >>>>>>>>> =09lockdep_assert_held(&local->active_txq_lock[txq->ac]); >>>>>>>>>=20 >>>>>>>>> =09if (!RB_EMPTY_NODE(&txqi->schedule_order) && >>>>>>>>> -=09 (skb_queue_empty(&txqi->frags) && >>>>>>>>> !txqi->tin.backlog_packets)) >>>>>>>>> -=09=09__ieee80211_unschedule_txq(hw, txq); >>>>>>>>> +=09=09!txq_has_queue(&txqi->txq) && >>>>>>>>> +=09=09list_empty(&txqi->candidate)) >>>>>>>>> +=09=09list_add_tail(&txqi->candidate,=20 >>>>>>>>> &local->remove_list[txq->ac]); >>>>>>>>> + >>>>>>>>> } >>>>>>>>> EXPORT_SYMBOL(ieee80211_return_txq); >>>>>>>>>=20 >>>>>>>>> +void __ieee80211_check_txqs(struct ieee80211_local *local, int >>>>>>>>> ac) >>>>>>>>> +{ >>>>>>>>> +=09struct txq_info *iter, *tmp; >>>>>>>>> +=09struct sta_info *sta; >>>>>>>>> + >>>>>>>>> +=09lockdep_assert_held(&local->active_txq_lock[ac]); >>>>>>>>> + >>>>>>>>> +=09list_for_each_entry_safe(iter, tmp, &local->remove_list[ac], >>>>>>>>> +=09=09=09=09 candidate) { >>>>>>>>> +=09=09sta =3D container_of(iter->txq.sta, struct sta_info, sta); >>>>>>>>> + >>>>>>>>> +=09=09if (txq_has_queue(&iter->txq)) >>>>>>>>> +=09=09=09list_del_init(&iter->candidate); >>>>>>>>> +=09=09else >>>>>>>>> +=09=09=09ieee80211_remove_txq(&local->hw, &iter->txq); >>>>>>>>> +=09} >>>>>>>>> +} >>>>>>>>> + >>>>>>>>> +void ieee80211_txqs_check(struct timer_list *t) >>>>>>>>> +{ >>>>>>>>> +=09struct ieee80211_local *local =3D from_timer(local, t, >>>>>>>>> remove_timer); >>>>>>>>> +=09struct txq_info *iter, *tmp; >>>>>>>>> +=09struct sta_info *sta; >>>>>>>>> +=09int ac; >>>>>>>>> + >>>>>>>>> +=09for (ac =3D 0; ac < IEEE80211_NUM_ACS; ac++) { >>>>>>>>> +=09=09spin_lock_bh(&local->active_txq_lock[ac]); >>>>>>>>> +=09=09__ieee80211_check_txqs(local, ac); >>>>>>>>> +=09=09spin_unlock_bh(&local->active_txq_lock[ac]); >>>>>>>>> +=09} >>>>>>>>> + >>>>>>>>> +=09mod_timer(&local->remove_timer, >>>>>>>>> +=09=09 jiffies + >>>>>>>>> msecs_to_jiffies(IEEE80211_AIRTIME_TXQ_RM_CHK_INTV_IN_MS)); >>>>>>>>> +} >>>>>>>>=20 >>>>>>>> I'll ask the same as I did last time (where you told me to hold=20 >>>>>>>> off >>>>>>>> until this round): >>>>>>>>=20 >>>>>>>> Why do you need the timer and the periodic check? If TXQs are=20 >>>>>>>> added >>>>>>>> to >>>>>>>> the remove list during the scheduling run, and >>>>>>>> __ieee80211_check_txqs() >>>>>>>> is run from schedule_end(), isn't that sufficient to clear the >>>>>>>> list? >>>>>>> Is it possible that a txq is not added to the remove list but then >>>>>>> packets in it are dropped by fq_codel algo? Like the station >>>>>>> disconnects >>>>>>> without any notification. >>>>>>=20 >>>>>> Well as long as all the other cleanup paths call directly into >>>>>> __unschedule_txq(), that should remove stations from the scheduler >>>>>> when >>>>>> they disconnect etc. >>>>> Yes, the disconnect scenario is a bad example. My concern is, say,=20 >>>>> we >>>>> have 10 stations and only one of them is assigned a very small=20 >>>>> weight >>>>> compared with that of others. Suppose, after its chance of Tx, it is >>>>> most likely to be placed in the rightmost(still has some packets in >>>>> the >>>>> txq) and no more incoming data for it. The remaining packets in txq >>>>> will >>>>> be dropped due to timeout algo in codel(correct me if I am wrong)=20 >>>>> but >>>>> this empty txq will stay on the rbtree until other txqs get drained= =20 >>>>> or >>>>> global vt catch up with its vt. The staying time could be long if >>>>> weight >>>>> is extremely small. Then do we need timer to check or any other=20 >>>>> better >>>>> solution? >>>>=20 >>>> Ah, I see what you mean. No, I don't think this will be a problem;=20 >>>> the >>>> scenario you're describing would play out like this: >>>>=20 >>>> 1. Station ends transmitting, still has a single packet queued, gets >>>> moved to the end of the rbtree (and stays there for a while). >>>>=20 >>>> 2. When we finally get to the point where this station gets another >>>> chance to transmit, the CoDel drop timer triggers and the last >>>> packet >>>> is dropped[0]. This means that the queue will just be empty >>>> (and ieee80211_tx_dequeue() will return NULL). >>>>=20 >>>> 3. Because the queue is empty, ieee80211_return_txq() will not put it >>>> back on the rbtree. >>>>=20 >>>> Crucially, in 2. the CoDel algorithm doesn't kick in until the point= =20 >>>> of >>>> packet dequeue. But even if an empty queue stays on the rbtree for a >>>> while, there is no harm in that: eventually it will get its turn, it >>>> will turn out to be empty, and just be skipped over. >>> Then that will be fine. Thanks for the explanation of the dropping=20 >>> part >>> in CoDel algorithm. >>=20 >> Yup, think so. And you're welcome :) >>=20 >>>> The issue we need to be concerned about is the opposite: If we have a >>>> queue that *does* have packets queued, but which is *not* scheduled=20 >>>> for >>>> transmission, that will stall TX. >>> Is it by design since its vt is more than global vt, right? The=20 >>> lattency >>> may somehow get impacted though. >>=20 >> Well, it should still stay on the rbtree as long as it has packets >> queued. We don't have a check anywhere that reschedules TXQs whose v_t >> drops below global v_t... >>=20 >>>> [0] CoDel in most cases only drops a single packet at a time, so it >>>> will >>>> not clear out an entire queue with multiple packets in one go. But=20 >>>> you >>>> are right that it could conceivably drop the last packet in a queue. >>>>=20 >>>>>> We only need to defer removal inside a single "scheduling round" >>>>>> (i.e., >>>>>> between a pair of ieee80211_txq_schedule_start/end. So if we just >>>>>> walk >>>>>> the remove list in schedule_end() we should be enough, no? >>>>>>=20 >>>>>> Hmm, or maybe a simpler way to fix the original issue is just to=20 >>>>>> have >>>>>> unschedule_txq() update the schedule_pos() pointer? >>>>>>=20 >>>>>> I.e., unschedule_txq checks if the txq being removed is currently >>>>>> being >>>>>> pointed to by schedule_pos[ac], and if it is, it updates=20 >>>>>> schedule_pos >>>>>> to >>>>>> be the rb_next of the current value? >>>>> Actually, if schedule_pos is updated to rb_next of the current=20 >>>>> value, >>>>> then in the next_txq() where we are going to use rb_next again and >>>>> finally pick the next node of the node we really want. Is it fine to >>>>> update schedule_pos to NULL? >>>>=20 >>>> Hmm, yeah, good point. >>>>=20 >>>> If we do end up setting schedule_pos to NULL in the middle of a >>>> scheduling round, that will make next_txq() "start over", and do >>>> another >>>> loop through the whole thing. I guess we may be able hit a case where >>>> things can oscillate back and forth between addition and removal >>>> resulting in an infinite loop? Not sure, but at least I can't seem to >>>> convince myself that this can't happen. >>>=20 >>> As the loop of next_txq under lock protection as below, >>>=20 >>> txq_schedule_start(); >>> while(txq=3Dnext_txq()){ >>> ... >>> return_txq(txq); >>> } >>> txq_schedule_end(); >>>=20 >>> I do not see any chance of addition, no? >>=20 >> As you noted in your other email, Felix reduced the locking. And yeah, >> we need to rebase this series to also incorporate that. I figure I can >> send an updated version of the first patch in the series once we've >> worked out the remaining issues with your follow-up patches. >>=20 > Oh, I was thinking we were discussing without locking reduced. Yes, I=20 > also agree there might be a case causing infinite loop. With locking=20 > reduced, the tree can be adjusted between next_txq() and return_txq() in= =20 > the loop situation. For further discussion, let 's consider, > 1) the tree starts like: > A->B->C->D->E > 2) then next_txq() returns A for dequeuing > 3) driver dequeues A and draines A without any active txq locked meaning= =20 > the tree could be changed upon Tx compeletion. > 4) then in return_txq(), the tree could be, > i A->B->C->D->E =EF=BC=88A is empty, and maybe soon be added ba= ck=20 > before the loop end=EF=BC=89 > ii B->C->A->D->E =EF=BC=88A is empty, and maybe soon be added ba= ck=20 > before the loop end=EF=BC=89 > iii B->C->D->E->A =EF=BC=88A is empty, and maybe soon be added ba= ck=20 > before the loop end) > > with this change: > local->schedule_pos[ac] =3D rb_next(node) ?: rb_prev(node); > > for case i, local->schedule_pos[ac] is rb_next(A) which is B, and in=20 > next_txq(), rb_next(B) is what we returns which actually is C and B is=20 > skipped, no? > > Similiar for case ii, we skip B, C, D. Yup, I think you're right. But if we can fix this by making ieee80211_resort_txq() aware of the schedule_pos as well, no? I.e., if resort_txq() acts on the txq that's currently in schedule_pos, it will update schedule pos with the same rb_next(node) ?: rb_prev(node); (optionally after checking that the position of the node is actually going to change). > Also I am wondering if there will be some SMP issues relating with=20 > local->schedule_pos[ac]. Not sure what you mean by this? >>> In ath10k, we will usually push packets of first txq as many as we can >>> until it is drained and then move to the next one. So if a txq gets >>> removed in the return_txq, it should always be the leftmost. And >>> during this period, neither vt of any station or global vt can be >>> updated due to lock protection. >>>=20 >>>>=20 >>>> But in that case, we could fix it by just conditionally assigning >>>> either >>>> rb_next or rb_prev to the schedule_pos in unschedule_txq()? I.e., >>>> something like: >>>>=20 >>>> local->schedule_pos[ac] =3D rb_next(node) ?: rb_prev(node); >>> I am not sure I am getting your point. Still in next_txq, >>> schedule_pos[ac] will lead us to the next node of the one we want. >>=20 >> The logic in next_txq is different when schedule_pos[ac] is NULL, vs >> when rb_next(schedule_pos[ac]) is NULL. The former restarts a new >> scheduling round, while the latter ends the current round. >>=20 >> -Toke > > --=20 > Yibo