From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45F34C7618B for ; Mon, 29 Jul 2019 10:58:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C87A2070D for ; Mon, 29 Jul 2019 10:58:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C87A2070D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hs3MT-0003Zd-DJ for qemu-devel@archiver.kernel.org; Mon, 29 Jul 2019 06:58:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44789) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hs3Le-0002oS-9o for qemu-devel@nongnu.org; Mon, 29 Jul 2019 06:57:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hs3Ld-00069T-9K for qemu-devel@nongnu.org; Mon, 29 Jul 2019 06:57:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15984) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hs3Lb-000660-86; Mon, 29 Jul 2019 06:57:43 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 631334E832; Mon, 29 Jul 2019 10:57:42 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D77110016EA; Mon, 29 Jul 2019 10:57:42 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A4CBB1138619; Mon, 29 Jul 2019 12:57:40 +0200 (CEST) From: Markus Armbruster To: Pino Toscano References: <20190726140954.31921-1-ptoscano@redhat.com> <20190726140954.31921-3-ptoscano@redhat.com> <549f94df-5d31-3dfe-0693-72a2861ddd7f@redhat.com> <28464409.aSG18riZGY@lindworm.usersys.redhat.com> Date: Mon, 29 Jul 2019 12:57:40 +0200 In-Reply-To: <28464409.aSG18riZGY@lindworm.usersys.redhat.com> (Pino Toscano's message of "Mon, 29 Jul 2019 10:00:08 +0200") Message-ID: <87ftmprtuj.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 29 Jul 2019 10:57:42 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, pkrempa@redhat.com, qemu-block@nongnu.org, rjones@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Pino Toscano writes: > On Friday, 26 July 2019 16:24:34 CEST Eric Blake wrote: >> On 7/26/19 9:09 AM, Pino Toscano wrote: >> > Add a 'private-key' option which represents the path of a private key >> > to use for authentication, and 'private-key-secret' as the name of an >> > object with its passphrase. >> > >> > Signed-off-by: Pino Toscano >> >> > +++ b/qapi/block-core.json >> > @@ -3226,6 +3226,11 @@ >> > # @password-secret: ID of a QCryptoSecret object providing a password >> > # for authentication (since 4.2) >> > # >> > +# @private-key: path to the private key (since 4.2) >> > +# >> > +# @private-key-secret: ID of a QCryptoSecret object providing the passphrase >> > +# for 'private-key' (since 4.2) >> >> Is password-secret intended to be mutually-exclusive with >> private-key/private-key-secret? > > My initial thought was to allow users to specify data for all the > authentication methods possible. Either ways (all of them, or a single > one) are fine for me. How does this work at the libssh level? Can you configure multiple authentication methods, and let negotiation pick the one to be used?