From: Jani Nikula <jani.nikula@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/csr: alpha_support doesn't depend on csr or vice versa
Date: Thu, 02 May 2019 11:18:43 +0300 [thread overview]
Message-ID: <87ftpxp8v0.fsf@intel.com> (raw)
In-Reply-To: <20190429163302.GG20006@intel.com>
On Mon, 29 Apr 2019, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Mon, Apr 29, 2019 at 05:22:53PM +0300, Jani Nikula wrote:
>> Debug logging should not be dependent on alpha support flag.
>>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> I agree... this is not the right way to track dependencies.
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Pushed, thanks.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/intel_csr.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
>> index f43c2a2563a5..4527b9662330 100644
>> --- a/drivers/gpu/drm/i915/intel_csr.c
>> +++ b/drivers/gpu/drm/i915/intel_csr.c
>> @@ -529,8 +529,6 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
>>
>> if (csr->fw_path == NULL) {
>> DRM_DEBUG_KMS("No known CSR firmware for platform, disabling runtime PM\n");
>> - WARN_ON(!IS_ALPHA_SUPPORT(INTEL_INFO(dev_priv)));
>> -
>> return;
>> }
>>
>> --
>> 2.20.1
>>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-02 8:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 14:22 [PATCH] drm/i915/csr: alpha_support doesn't depend on csr or vice versa Jani Nikula
2019-04-29 14:51 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-04-29 16:33 ` [PATCH] " Rodrigo Vivi
2019-05-02 8:18 ` Jani Nikula [this message]
2019-04-29 19:03 ` ✗ Fi.CI.IGT: failure for " Patchwork
2019-04-30 11:20 ` ✓ Fi.CI.BAT: success for drm/i915/csr: alpha_support doesn't depend on csr or vice versa (rev2) Patchwork
2019-04-30 21:15 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftpxp8v0.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.