From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH 1/2] drm/i915/icl: Factor out combo PHY lane
 power setup helper
Date: Thu, 25 Apr 2019 11:30:36 +0300
Message-ID: <87ftq6trkj.fsf@intel.com>
References: <20190424152632.8301-1-imre.deak@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 999C8890F9
 for <intel-gfx@lists.freedesktop.org>; Thu, 25 Apr 2019 08:28:19 +0000 (UTC)
In-Reply-To: <20190424152632.8301-1-imre.deak@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Imre Deak <imre.deak@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCAyNCBBcHIgMjAxOSwgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cm90
ZToKPiBGYWN0b3Igb3V0IHRoZSBjb21ibyBQSFkgbGFuZSBwb3dlciBjb25maWd1cmF0aW9uIGNv
ZGUgdG8gYSBzZXBhcmF0ZQo+IGhlbHBlcjsgaXQgd2lsbCBiZSBhbHNvIG5lZWRlZCBieSB0aGUg
bmV4dCBwYXRjaCBhZGRpbmcgdGhlIHNhbWUKPiBjb25maWd1cmF0aW9uIGZvciBEREkgcG9ydHMu
Cj4KPiBXaGlsZSBhdCBpdCBhbHNvIGFkZCBzdXBwb3J0IHRvIGhhbmRsZSBsYW5lIHJldmVyc2Fs
IHdoaWNoIHdhc24ndAo+IG5lZWRlZCBmb3IgRFNJLCBidXQgd2lsbCBiZSBuZWVkZWQgYnkgRERJ
IHBvcnRzLgo+Cj4gQWxzbywgcmVtb3ZlIHRoZSBtYWNyb3MgZm9yIHRoZSBwb3dlciBkb3duIGZs
YWdzLCB0aGV5IGFyZW4ndAo+IG5lZWRlZCBhbnkgbW9yZSBzaW5jZSB3ZSBub3cgY2FsY3VsYXRl
IHRoZSBwb3dlciBkb3duIG1hc2suIE1hbnkgb2YKPiB0aG9zZSBtYWNybyB2YWx1ZXMgKG1vc3Rs
eSB0aGUgb25lcyBmb3IgdGhlIGN1cnJlbnRseSB1bnVzZWQgcmV2ZXJzZWQKPiBsYW5lIGNvbmZp
Z3MpIHdlcmUgYWN0dWFsbHkgdW5kZWZpbmVkIGluIHRoZSBzcGVjIGFuZCBkaWRuJ3QgbWFrZSBt
dWNoCj4gc2Vuc2UgZWl0aGVyLgoKT25seSBQV1JfRE9XTl9MTl8xIGlzIHVuZGVmaW5lZCBpbiB0
aGUgc3BlYy4KCj4KPiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiBD
YzogTWFkaGF2IENoYXVoYW4gPG1hZGhhdi5jaGF1aGFuQGludGVsLmNvbT4KPiBDYzogVmlsbGUg
U3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTog
SW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v
aTkxNS9pOTE1X2Rydi5oICAgICAgICB8ICAzICsrKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X3JlZy5oICAgICAgICB8ICA5IC0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
Y2xfZHNpLmMgICAgICAgICB8IDI2ICsrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbWJvX3BoeS5jIHwgMzEgKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKwo+ICA0IGZpbGVzIGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDMyIGRl
bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2
LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggZGM3NGQzM2MyMGFh
Li4xMjA3ZWYwODBhYWUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k
cnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMzUxNSw2
ICszNTE1LDkgQEAgdm9pZCBpY2xfY29tYm9fcGh5c19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdik7Cj4gIHZvaWQgaWNsX2NvbWJvX3BoeXNfdW5pbml0KHN0cnVjdCBkcm1f
aTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gIHZvaWQgY25sX2NvbWJvX3BoeXNfaW5pdChzdHJ1
Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICB2b2lkIGNubF9jb21ib19waHlzX3Vu
aW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICt2b2lkIGljbF9jb21i
b19waHlfcG93ZXJfdXBfbGFuZXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+
ICsJCQkJICBlbnVtIHBvcnQgcG9ydCwgaW50IGxhbmVfY291bnQsCj4gKwkJCQkgIGJvb2wgbGFu
ZV9yZXZlcnNhbCk7Cj4gIAo+ICBpbnQgaW50ZWxfZ3B1X2ZyZXEoc3RydWN0IGRybV9pOTE1X3By
aXZhdGUgKmRldl9wcml2LCBpbnQgdmFsKTsKPiAgaW50IGludGVsX2ZyZXFfb3Bjb2RlKHN0cnVj
dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgaW50IHZhbCk7Cj4gZGlmZiAtLWdpdCBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X3JlZy5oCj4gaW5kZXggYjc0ODI0ZjBiNWIxLi4yOWYxNmJjNDBiMGEgMTAwNjQ0Cj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfcmVnLmgKPiBAQCAtMTgwNywxNSArMTgwNyw2IEBAIGVudW0gaTkxNV9wb3dlcl93
ZWxsX2lkIHsKPiAgI2RlZmluZSAgUEdfU0VRX0RFTEFZX09WRVJSSURFX01BU0sJKDMgPDwgMjUp
Cj4gICNkZWZpbmUgIFBHX1NFUV9ERUxBWV9PVkVSUklERV9TSElGVAkyNQo+ICAjZGVmaW5lICBQ
R19TRVFfREVMQVlfT1ZFUlJJREVfRU5BQkxFCSgxIDw8IDI0KQo+IC0jZGVmaW5lICBQV1JfVVBf
QUxMX0xBTkVTCQkoMHgwIDw8IDQpCj4gLSNkZWZpbmUgIFBXUl9ET1dOX0xOXzNfMl8xCQkoMHhl
IDw8IDQpCj4gLSNkZWZpbmUgIFBXUl9ET1dOX0xOXzNfMgkJKDB4YyA8PCA0KQo+IC0jZGVmaW5l
ICBQV1JfRE9XTl9MTl8zCQkJKDB4OCA8PCA0KQo+IC0jZGVmaW5lICBQV1JfRE9XTl9MTl8yXzFf
MAkJKDB4NyA8PCA0KQo+IC0jZGVmaW5lICBQV1JfRE9XTl9MTl8xXzAJCSgweDMgPDwgNCkKPiAt
I2RlZmluZSAgUFdSX0RPV05fTE5fMQkJCSgweDIgPDwgNCkKPiAtI2RlZmluZSAgUFdSX0RPV05f
TE5fM18xCQkoMHhhIDw8IDQpCj4gLSNkZWZpbmUgIFBXUl9ET1dOX0xOXzNfMV8wCQkoMHhiIDw8
IDQpCj4gICNkZWZpbmUgIFBXUl9ET1dOX0xOX01BU0sJCSgweGYgPDwgNCkKPiAgI2RlZmluZSAg
UFdSX0RPV05fTE5fU0hJRlQJCTQKPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ljbF9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ljbF9kc2kuYwo+IGluZGV4IDlk
OTYyZWExZTYzNS4uODg5NTk1MTdiNjY4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ljbF9kc2kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ljbF9kc2kuYwo+IEBA
IC0zNjMsMzAgKzM2MywxMCBAQCBzdGF0aWMgdm9pZCBnZW4xMV9kc2lfcG93ZXJfdXBfbGFuZXMo
c3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0
ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGVuY29kZXItPmJhc2UuZGV2KTsKPiAgCXN0cnVjdCBpbnRl
bF9kc2kgKmludGVsX2RzaSA9IGVuY190b19pbnRlbF9kc2koJmVuY29kZXItPmJhc2UpOwo+ICAJ
ZW51bSBwb3J0IHBvcnQ7Cj4gLQl1MzIgdG1wOwo+IC0JdTMyIGxhbmVfbWFzazsKPiAgCj4gLQlz
d2l0Y2ggKGludGVsX2RzaS0+bGFuZV9jb3VudCkgewo+IC0JY2FzZSAxOgo+IC0JCWxhbmVfbWFz
ayA9IFBXUl9ET1dOX0xOXzNfMV8wOwo+IC0JCWJyZWFrOwo+IC0JY2FzZSAyOgo+IC0JCWxhbmVf
bWFzayA9IFBXUl9ET1dOX0xOXzNfMTsKPiAtCQlicmVhazsKPiAtCWNhc2UgMzoKPiAtCQlsYW5l
X21hc2sgPSBQV1JfRE9XTl9MTl8zOwo+IC0JCWJyZWFrOwo+IC0JY2FzZSA0Ogo+IC0JZGVmYXVs
dDoKPiAtCQlsYW5lX21hc2sgPSBQV1JfVVBfQUxMX0xBTkVTOwo+IC0JCWJyZWFrOwo+IC0JfQo+
IC0KPiAtCWZvcl9lYWNoX2RzaV9wb3J0KHBvcnQsIGludGVsX2RzaS0+cG9ydHMpIHsKPiAtCQl0
bXAgPSBJOTE1X1JFQUQoSUNMX1BPUlRfQ0xfRFcxMChwb3J0KSk7Cj4gLQkJdG1wICY9IH5QV1Jf
RE9XTl9MTl9NQVNLOwo+IC0JCUk5MTVfV1JJVEUoSUNMX1BPUlRfQ0xfRFcxMChwb3J0KSwgdG1w
IHwgbGFuZV9tYXNrKTsKPiAtCX0KCkkgbG9vayBhdCB0aGF0IGFuZCBpdCB0YWtlcyBtZSBtYXli
ZSAxMCBzZWNvbmRzIHRvIGZpZ3VyZSBvdXQgd2hhdCdzCmdvaW5nIG9uLCBhc3N1bWluZyB0aGUg
UFdSX0RPV05fTE5fKiBtYWNyb3MgYXJlIHJpZ2h0LgoKPiArCWZvcl9lYWNoX2RzaV9wb3J0KHBv
cnQsIGludGVsX2RzaS0+cG9ydHMpCj4gKwkJaWNsX2NvbWJvX3BoeV9wb3dlcl91cF9sYW5lcyhk
ZXZfcHJpdiwgcG9ydCwKPiArCQkJCQkgICAgIGludGVsX2RzaS0+bGFuZV9jb3VudCwgZmFsc2Up
Owo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBnZW4xMV9kc2lfY29uZmlnX3BoeV9sYW5lc19zZXF1
ZW5jZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfY29tYm9fcGh5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9jb21ib19waHkuYwo+IGluZGV4IDJiZjQzNTlkN2U0MS4uZTNlZDU4NGVjYTQ3IDEwMDY0
NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbWJvX3BoeS5jCj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29tYm9fcGh5LmMKPiBAQCAtMjAzLDYgKzIwMywz
NyBAQCBzdGF0aWMgYm9vbCBpY2xfY29tYm9fcGh5X3ZlcmlmeV9zdGF0ZShzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+ICtzdGF0aWMg
dWludDhfdCByZXZlcnNlX25pYmJsZV9iaXRzKHVpbnQ4X3QgdmFsKQo+ICt7Cj4gKyNkZWZpbmUg
TU9WQklUKHYsIGZyb20sIHRvKSAoISEoKHYpICYgQklUKGZyb20pKSA8PCAodG8pKQo+ICsjZGVm
aW5lIFNXUEJJVCh2LCBiMSwgYjIpIChNT1ZCSVQoKHYpLCAoYjEpLCAoYjIpKSB8IE1PVkJJVCgo
diksIChiMiksIChiMSkpKQo+ICsKPiArCXJldHVybiBTV1BCSVQodmFsLCAwLCAzKSB8IFNXUEJJ
VCh2YWwsIDEsIDIpOwo+ICsjdW5kZWYgU1dQQklUCj4gKyN1bmRlZiBNT1ZCSVQKPiArfQo+ICsK
PiArdm9pZCBpY2xfY29tYm9fcGh5X3Bvd2VyX3VwX2xhbmVzKHN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdiwKPiArCQkJCSAgZW51bSBwb3J0IHBvcnQsIGludCBsYW5lX2NvdW50LAo+
ICsJCQkJICBib29sIGxhbmVfcmV2ZXJzYWwpCj4gK3sKPiArCXUzMiBwd3JfZG93bl9tYXNrOwo+
ICsJdTMyIHZhbDsKPiArCj4gKwlXQVJOX09OKCh1MzIpbGFuZV9jb3VudCA+IDQpOwo+ICsKPiAr
CXB3cl9kb3duX21hc2sgPSBCSVQobGFuZV9jb3VudCkgLSAxOwo+ICsJaWYgKGxhbmVfcmV2ZXJz
YWwpCj4gKwkJcHdyX2Rvd25fbWFzayA9IHJldmVyc2VfbmliYmxlX2JpdHMocHdyX2Rvd25fbWFz
ayk7Cj4gKwo+ICsJcHdyX2Rvd25fbWFzayA9IH5wd3JfZG93bl9tYXNrICYgMHhmOwo+ICsKPiAr
CXZhbCA9IEk5MTVfUkVBRChJQ0xfUE9SVF9DTF9EVzEwKHBvcnQpKTsKPiArCXZhbCAmPSB+UFdS
X0RPV05fTE5fTUFTSzsKPiArCUk5MTVfV1JJVEUoSUNMX1BPUlRfQ0xfRFcxMChwb3J0KSwKPiAr
CQkgICB2YWwgfCAocHdyX2Rvd25fbWFzayA8PCBQV1JfRE9XTl9MTl9TSElGVCkpOwo+ICt9CgpN
YXliZSBJJ20gc2xvdyB0b2RheSwgYnV0IGl0IHRvb2sgbWUgMTUtMzAgbWludXRlcyB0byBmaWd1
cmUgb3V0IHRoYXQKdGhpcyBzY3Jld3MgdXAgdGhlIDEgYW5kIDIgbGFuZSBEU0kgdmFsdWVzLgoK
VGhlIHVuc2hpZnRlZCB2YWx1ZSBjaGFuZ2VzOgoKRFNJIHgxOiAxMDExYiAtPiAxMTEwYgpEU0kg
eDI6IDEwMTBiIC0+IDExMDBiCgpEU0kgdXNlcyBkaWZmZXJlbnQgdmFsdWVzIGZyb20gRERJLgoK
VGhlcmUgKmlzKiB2YWx1ZSBpbiBrZWVwaW5nIGl0IHNpbXBsZSBhbmQgbWVjaGFuaWMgaW5zdGVh
ZCBvZiB0cnlpbmcgdG8KZm9yY2UgaXQgaW50byBhIGZvcm11bGEuCgoKQlIsCkphbmkuCgoKPiAr
Cj4gIHZvaWQgaWNsX2NvbWJvX3BoeXNfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2
X3ByaXYpCj4gIHsKPiAgCWVudW0gcG9ydCBwb3J0OwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBP
cGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vaW50ZWwtZ2Z4