All of lore.kernel.org
 help / color / mirror / Atom feed
From: Esben Haabendal <esben.haabendal@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gummiboot: fix linking for non-host compatible targets
Date: Wed, 27 Mar 2019 23:28:29 +0100	[thread overview]
Message-ID: <87ftr89cky.fsf@haabendal.dk> (raw)
In-Reply-To: <a98e9eba-82d2-a387-a99b-56c15ceeba40@mind.be> (Arnout Vandecappelle's message of "Tue, 26 Mar 2019 21:33:39 +0100")

Arnout Vandecappelle <arnout@mind.be> writes:

> On 26/03/2019 14:07, Esben Haabendal wrote:
>> + $(gummiboot_solib): $(gummiboot_objects)
>> +-	$(AM_V_CCLD)$(LD) $(efi_ldflags) $(gummiboot_objects) \
>> ++	$(AM_V_CCLD)$(EFI_LD) $(efi_ldflags) $(gummiboot_objects) \
>> + 		-o $@ -lefi -lgnuefi $(shell $(CC) -print-libgcc-file-name); \
>                                              ^^^^ Shouldn't this be EFI_CC?

Yes, it probably should.

>> + 	nm -D -u $@ | grep ' U ' && exit 1 || :
>
>  Is nm the same on all architectures?

I assume nm is cross, so no.

> Of course, since gummiboot is x86 only, it doesn't matter much.

I can include support for specifying $(NM) also, but as you say, it
might not make a difference for anybody.  Unless, someone builds x86
images on non-x86 platforms.

/Esben

      reply	other threads:[~2019-03-27 22:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 13:07 [Buildroot] [PATCH] gummiboot: fix linking for non-host compatible targets Esben Haabendal
2019-03-26 17:54 ` Thomas Petazzoni
2019-03-26 20:33 ` Arnout Vandecappelle
2019-03-27 22:28   ` Esben Haabendal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftr89cky.fsf@haabendal.dk \
    --to=esben.haabendal@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.