From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH v3 3/3] drm/i915: use REG_FIELD_PREP() to
 define register bitfield values
Date: Thu, 28 Feb 2019 15:48:09 +0200
Message-ID: <87fts8nhwm.fsf@intel.com>
References: <cover.1551286447.git.jani.nikula@intel.com>
 <3f787052750840935689ac2fa8f3fa44cfbf1119.1551286447.git.jani.nikula@intel.com>
 <op.zxwa3hwdxaggs7@mwajdecz-mobl1.ger.corp.intel.com>
 <87imx4nrbe.fsf@intel.com>
 <op.zxw6mjhuxaggs7@mwajdecz-mobl1.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 82D0589170
 for <intel-gfx@lists.freedesktop.org>; Thu, 28 Feb 2019 13:46:10 +0000 (UTC)
In-Reply-To: <op.zxw6mjhuxaggs7@mwajdecz-mobl1.ger.corp.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCAyOCBGZWIgMjAxOSwgTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0Bp
bnRlbC5jb20+IHdyb3RlOgo+IE9uIFRodSwgMjggRmViIDIwMTkgMTE6MjQ6NTMgKzAxMDAsIEph
bmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+ICAKPiB3cm90ZToKPgo+PiBPbiBUaHUs
IDI4IEZlYiAyMDE5LCBNaWNoYWwgV2FqZGVjemtvIDxtaWNoYWwud2FqZGVjemtvQGludGVsLmNv
bT4gd3JvdGU6Cj4+PiBPbiBXZWQsIDI3IEZlYiAyMDE5IDE4OjAyOjM4ICswMTAwLCBKYW5pIE5p
a3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+Pj4gd3JvdGU6Cj4+Pgo+Pj4+IEBAIC0xMDgs
OSArMTA4LDkgQEAKPj4+PiAgICogICNkZWZpbmUgRk9PKHBpcGUpICAgICAgICAgICAgICAgICAg
IF9NTUlPX1BJUEUocGlwZSwgX0ZPT19BLCAgCj4+Pj4gX0ZPT19CKQo+Pj4+ICAgKiAgI2RlZmlu
ZSAgIEZPT19FTkFCTEUgICAgICAgICAgICAgICAgUkVHX0JJVCgzMSkKPj4+PiAgICogICNkZWZp
bmUgICBGT09fTU9ERV9NQVNLICAgICAgICAgICAgIFJFR19HRU5NQVNLKDE5LCAxNikKPj4+PiAt
ICogICNkZWZpbmUgICBGT09fTU9ERV9CQVIgICAgICAgICAgICAgICgwIDw8IDE2KQo+Pj4+IC0g
KiAgI2RlZmluZSAgIEZPT19NT0RFX0JBWiAgICAgICAgICAgICAgKDEgPDwgMTYpCj4+Pj4gLSAq
ICAjZGVmaW5lICAgRk9PX01PREVfUVVYX1NOQiAgICAgICAgICAoMiA8PCAxNikKPj4+PiArICog
ICNkZWZpbmUgICBGT09fTU9ERV9CQVIgICAgICAgICAgICAgIFJFR19GSUVMRF9QUkVQKEZPT19N
T0RFX01BU0ssICAKPj4+PiAwKQo+Pj4+ICsgKiAgI2RlZmluZSAgIEZPT19NT0RFX0JBWiAgICAg
ICAgICAgICAgUkVHX0ZJRUxEX1BSRVAoRk9PX01PREVfTUFTSywgIAo+Pj4+IDEpCj4+Pj4gKyAq
ICAjZGVmaW5lICAgRk9PX01PREVfUVVYX1NOQiAgICAgICAgICBSRUdfRklFTERfUFJFUChGT09f
TU9ERV9NQVNLLCAgCj4+Pj4gMikKPj4+Cj4+PiBobW0sIHNob3VsZG4ndCB3ZSBkZWZpbmUgdGhl
c2UgdmFsdWVzIGFzOgo+Pj4KPj4+ICNkZWZpbmUgICBGT09fTU9ERV9CQVIgICAgICAgICAgICAg
ICgwKQo+Pj4gI2RlZmluZSAgIEZPT19NT0RFX0JBWiAgICAgICAgICAgICAgKDEpCj4+PiAjZGVm
aW5lICAgRk9PX01PREVfUVVYX1NOQiAgICAgICAgICAoMikKPj4+Cj4+PiB0byBhbGxvdyB1c2lu
ZyB0aGVtIG5hdGl2ZWx5IHdpdGggUkVHX0ZJRUxEX0dFVC9QUkVQQVJFKCkgPwo+Pj4gbWF5YmUg
d2Ugc2hvdWxkIGFsc28gY29uc2lkZXIgZHJvcHBpbmcgX01BU0sgc3VmZml4Pwo+Pj4KPj4+IE1N
SU9fV1JJVEUoLi4uLAo+Pj4gICAgICAgICAgICAgUkVHX0ZJRUxEX1BSRVBBUkUoRk9PX0VOQUJM
RSwgdHJ1ZSkgfAo+Pj4gICAgICAgICAgICAgUkVHX0ZJRUxEX1BSRVBBUkUoRk9PX01PREUsIEZP
T19NT0RFX0JBUikpCj4+Pgo+Pj4gbW9kZSA9IFJFR19GSUVMRF9HRVQoRk9PX01PREUsIE1NSU9f
UkVBRCguLi4pKTsKPj4+IGVuYWJsZWQgPSBSRUdfRklFTERfR0VUKEZPT19FTkFCTEUsIE1NSU9f
UkVBRCguLi4pKTsKPj4KPj4gSSB3b3VsZCBoYXZlIHRvIGFncmVlIHdpdGggeW91ICppZiogd2Ug
d2VyZSB3cml0aW5nIGFsbCB0aGlzIGZyb20KPj4gc2NyYXRjaC4gQnV0IGFsbW9zdCBhbGwgb2Yg
dGhlIGV4aXN0aW5nIGJpdGZpZWxkIHZhbHVlcyBhcmUgZGVmaW5lZAo+PiBzaGlmdGVkIGluIHBs
YWNlLCBzbyB5b3UgY2FuIE9SIHRoZW0gaW4gcGxhY2UgZGlyZWN0bHkuIEkgd2FudCB0byBrZWVw
Cj4+IGl0IHRoYXQgd2F5IGluc3RlYWQgb2YgY3JlYXRpbmcgYSBtaXguIEFuZCB3ZSBoYXZlIGFi
b3V0IDFrIG1hY3JvcyB3aXRoCj4+IF9NQVNLIHN1ZmZpeCB0b28uCj4KPiBCdXQgc2luY2UgdGhp
cyBpcyAnZG9jdW1lbnRhdGlvbicgcGFydCwgbWF5YmUgd2Ugc2hvdWxkIHB1c2ggaW50byBwcmVm
ZXJyZWQKPiB1c2FnZSBtb2RlbCwgbGVhdmluZyBiZWhpbmQgZXhpc3RpbmcgY29kZSAoYW5kIGxl
dCBpdCB1cGdyYWRlIGNhc2UgYnkgY2FzZSkKCkknbSBhY3R1YWxseSBub3QgZXZlbiBzdXJlIEkg
YWdyZWUgd2l0aCB0aGUgdXNhZ2UgbW9kZWwuIENvbnRyYXN0OgoKSTkxNV9XUklURSguLi4sIEZP
T19NT0RFX0JBUiB8IEZPT19TT01FVEhJTkdfRUxTRSk7Cgp3aXRoCgpJOTE1X1dSSVRFKC4uLiwg
UkVHX0ZJRUxEX1BSRVAoRk9PX01PREVfTUFTSywgRk9PX01PREVfQkFSKSB8CgkgICBGT09fU09N
RVRISU5HX0VMU0UpOwoKV2hlbiBwb3NzaWJsZSwgSSB0aGluayBJIHN0aWxsIHByZWZlciBoYXZp
bmcgdGhlIHZlcmJvc2UgcGFydCBpbgppOTE1X3JlZy5oIGluIGZhdm9yIG9mIGtlZXBpbmcgdGhl
IGNvZGUgcmVhZGFibGUgKmFuZCogdW5pZm9ybQpyZWdhcmRsZXNzIG9mIHdoZXRoZXIgdGhlIGZp
ZWxkcyB3ZXJlIGRlZmluZWQgdXNpbmcgUkVHX0ZJRUxEX1BSRVAoKSBvcgptYW51YWwgc2hpZnRz
LgoKSSBjYW4gYWxzbyBpbWFnaW5lIGRvaW5nOgoKI2RlZmluZSBGT09fU0laRV9NQVNLCQlSRUdf
R0VOTUFTSyg3LCAwKQojZGVmaW5lIEZPT19TSVpFKHNpemUpCQlSRUdfRklFTERfUFJFUChGT09f
U0laRV9NQVNLLCBzaXplKQoKYW5kIHVzaW5nOgoKSTkxNV9XUklURSguLi4sIEZPT19TSVpFKDQy
KSkKCmluc3RlYWQgb2Y6CgpJOTE1X1dSSVRFKC4uLiwgUkVHX0ZJRUxEX1BSRVAoRk9PX1NJWkVf
TUFTSywgc2l6ZSkpCgo+Cj4+Cj4+IFNvLCB5ZWFoLCBpdCdzIGdvaW5nIHRvIGJlIHNsaWdodGx5
IHByb2JsZW1hdGljIHRvIFJFR19GSUVMRF9HRVQoKSBhCj4+IGZpZWxkIGFuZCBjb21wYXJlIGl0
IGFnYWluc3QgYSBkZWZpbmVkIHZhbHVlIGZvciB0aGF0IGZpZWxkLiBJIGV4cGVjdCB1cwo+PiB0
byBrZWVwIHVzaW5nIHRoaW5ncyBsaWtlOgo+Pgo+PiAJaWYgKCh2YWwgJiBGT09fTU9ERV9NQVNL
KSA9PSBGT09fTU9ERV9CQVIpCj4KPiBIbW0sIGlmIHlvdSBzdGlsbCB3YW50IHRvIHVzZSBpdCB0
aGlzIHdheSwgd2hhdCdzIHRoZSBwdXJwb3NlIG9mIGhhdmluZwo+IHBhaXIgb2YgUkVHX0ZJRUxE
X0dFVCBtYWNybz8KCkkgZG9uJ3QgdGhpbmsgd2UgcmVhZCByZWdpc3RlciBmaWVsZHMgdG8gY29t
cGFyZSB0aGVtIGFnYWluc3QgdGhlIG1hY3JvcwphbGwgdGhhdCBtdWNoLiBJIHRoaW5rIGl0J3Mg
bW9yZSBjb21tb24gdG8gcmVhZCB0aGUgZmllbGRzIHRvIGV4dHJhY3QKc29tZSB2YWx1ZSAoc2F5
LCBwaXhlbHMsIHRpbWluZyksIG9yIHRvIGNvbXBhcmUgYWdhaW5zdCBhIHZhbHVlIHN0b3JlZApp
biBzdGF0ZS4KCj4KPj4KPj4gSW5kZWVkLCBvbmUgb2YgdGhlIHJlYXNvbnMgZm9yIHRoZSBsb2Nh
bCBpbnRlZ2VyIGNvbnN0YW50IGV4cHJlc3Npb24KPj4gdmVyc2lvbiBvZiBSRUdfRklFTERfUFJF
UCgpIGlzIHRvIGFsbG93IGl0IGluIGNhc2UgbGFiZWxzOgo+Pgo+PiAJc3dpdGNoICh2YWwgJiBG
T09fTU9ERV9NQVNLKSB7Cj4+ICAgICAgICAgY2FzZSBGT09fTU9ERV9CQVI6IC8qIGRlZmluZWQg
dXNpbmcgUkVHX0ZJRUxEX1BSRVAoKSAqLwo+PiAgICAgICAgIAkvKiAuLi4gKi8KPj4gICAgICAg
ICB9Cj4+Cj4+IEkgZG9uJ3Qgd2FudCB0byBoYXZlIHRvIHN0YXJ0IGNoYW5naW5nIHRoZXNlIGNv
bW1vbiBleGlzdGluZyBjb252ZW50aW9ucwo+PiB0aHJvdWdob3V0IHRoZSBkcml2ZXIuIFdpdGgg
dGhlIHByb3Bvc2VkIGFwcHJvYWNoLCB3ZSBjYW4gZGVmaW5lIHRoZQo+PiByZWdpc3RlcnMgaW4g
dGhlIG5ldyBzdHlsZSBhbmQgbm90IGNoYW5nZSBhbnl0aGluZy4gV2UgY2FuIGRyb3AgX1NISUZU
Cj4+IGNhc2UgYnkgY2FzZSBpZiB3ZSBtb3ZlIHRvIFJFR19GSUVMRF9QUkVQL0dFVCB1c2FnZS4K
Pj4KPgo+IEJ1dCBhY3R1YWxseSBtYXliZSBiZXR0ZXIgb3B0aW9uIHdvdWxkIGJlIHRvIGxldCBv
bGQgZGVmaW5pdGlvbnMgYW5kIGNvZGUKPiBpbnRhY3QsIGFuZCB0aGVuIGxhdGVyIGNoYW5nZSBi
b3RoIHBsYWNlcyBhdCBvbmNlLCB0byBmb2xsb3cgbmV3IHJ1bGVzOgo+Cj4gCW1vZGUgPSBSRUdf
RklFTERfR0VUKEZPT19NT0RFX01BU0ssIHZhbCk7Cj4gCXN3aXRjaCAobW9kZSkgewo+IAkJY2Fz
ZSBGT09fTU9ERV9CQVI6IC8qIGRlZmluZWQgbGlrZSAwIGJhc2VkIGVudW1zICovCj4gCQkvKiAu
Li4gKi8KPiAJfQo+Cj4gb3RoZXJ3aXNlLCByZWdhcmRsZXNzIG9mIGhhdmluZyBuZXcgc3R5bGUg
X1BSRVAvX0dFVCBtYWNyb3MsIHdlIHN0aWxsCj4gYmUgdXNpbmcgb3VyIG9sZCBjb252ZW50aW9u
IGJhc2VkIG9uIF9TSElGVCdlZCB2YWx1ZXMuCj4KPiBBcyBDaHJpcyByZXBsaWVkIGVhcmxpZXIs
IHdlIG11c3QgdGFrZSBpbnRvIGFjY291bnQgInRoYXQgb3RoZXIgcGVvcGxlCj4gcmVhZGluZyBv
dXIgY29kZSBhbHJlYWR5IGtub3cgdGhlIGxhbmd1YWdlIiBhbmQgd2l0aCBrZWVwaW5nIHJlZ2lz
dGVyCj4gdmFsdWVzIHNoaWZ0ZWQsIHdlIG1heSBicmVhayBzdHlsZSBleHBlY3RlZCBieSBfUFJF
UC9fR0VULgoKU28gaW1hZ2luZSB0aGUgbWl4ZWQgdXNlLCBvbmUgc2V0IG9mIHJlZ2lzdGVycyBj
b252ZXJ0ZWQsIHNvbWUgb3RoZXJzCm5vdCwgYW5kIHlvdSBoYXZlIGNvZGUgd2l0aDoKCkk5MTVf
V1JJVEUoLi4uLCBSRUdfRklFTERfUFJFUChGT09fTU9ERV9NQVNLLCBGT09fTU9ERV9CQVIpIHwK
CSAgIEZPT19TT01FVEhJTkdfRUxTRSk7Ckk5MTVfV1JJVEUoLi4uLCBCQVJfTU9ERV9CQVogfCBC
QVJfU09NRVRISU5HX0VMU0UpOwoKQW5kIHlvdSdyZSB3b25kZXJpbmcgd2h5IHRoZSBpbmNvbnNp
c3RlbmN5LgoKCkJSLApKYW5pLgoKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2Ug
R3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w
Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs
LWdmeA==