From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwg9L-0005o2-O3 for ath10k@lists.infradead.org; Thu, 21 Feb 2019 04:39:57 +0000 From: Kalle Valo Subject: Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips References: <1533724802-30944-1-git-send-email-wgong@codeaurora.org> <1533724802-30944-3-git-send-email-wgong@codeaurora.org> <87sh3pdtpg.fsf@toke.dk> <87mutue4y8.fsf@toke.dk> <1535967508.3437.31.camel@sipsolutions.net> <87in3m25uu.fsf@toke.dk> <1535975240.3437.61.camel@sipsolutions.net> <878t4i1z74.fsf@toke.dk> <871sa7ylmi.fsf@toke.dk> Date: Thu, 21 Feb 2019 06:39:35 +0200 In-Reply-To: (Grant Grundler's message of "Wed, 20 Feb 2019 11:15:02 -0800") Message-ID: <87ftshpxfc.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Grant Grundler Cc: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= , wgong@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, wgong@codeaurora.org, Johannes Berg R3JhbnQgR3J1bmRsZXIgPGdydW5kbGVyQGdvb2dsZS5jb20+IHdyaXRlczoKCj4gT24gVGh1LCBT ZXAgNiwgMjAxOCBhdCAzOjE4IEFNIFRva2UgSMO4aWxhbmQtSsO4cmdlbnNlbiA8dG9rZUB0b2tl LmRrPiB3cm90ZToKPj4KPj4gR3JhbnQgR3J1bmRsZXIgPGdydW5kbGVyQGdvb2dsZS5jb20+IHdy aXRlczoKPj4KPj4gPj4gQW5kLCB3ZWxsLCBHcmFudCdzIGRhdGEgaXMgZnJvbSBhIHNpbmdsZSB0 ZXN0IGluIGEgbm9pc3kKPj4gPj4gZW52aXJvbm1lbnQgd2hlcmUgdGhlIHRpbWUgc2VyaWVzIGdy YXBoIHNob3dzIHRoYXQgdGhyb3VnaHB1dCBpcyBhbGwgb3Zlcgo+PiA+PiB0aGUgcGxhY2UgZm9y IHRoZSBkdXJhdGlvbiBvZiB0aGUgdGVzdDsgc28gaXQncyBoYXJkIHRvIGRyYXcgc29saWQKPj4g Pj4gY29uY2x1c2lvbnMgZnJvbSAoZm9yIGluc3RhbmNlLCBmb3IgdGhlIDUtc3RyZWFtIHRlc3Qs IHRoZSBhdmVyYWdlCj4+ID4+IHRocm91Z2hwdXQgZm9yIDYgaXMgMzMxIGFuZCAzNzkgTWJwcyBm b3IgdGhlIHR3byByZXBldGl0aW9ucywgYW5kIGZvciA3Cj4+ID4+IGl0J3MgMzI2IGFuZCAzNzEg TWJwcykgLiBVbmZvcnR1bmF0ZWx5IEkgZG9uJ3QgaGF2ZSB0aGUgc2FtZSBoYXJkd2FyZQo+PiA+ PiB1c2VkIGluIHRoaXMgdGVzdCwgc28gSSBjYW4ndCBnbyB2ZXJpZnkgaXQgbXlzZWxmOyBzbyB0 aGUgb25seSB0aGluZyBJCj4+ID4+IGNhbiBkbyBpcyBncnVtYmxlIGFib3V0IGl0IGhlcmUuLi4g OikKPj4gPgo+PiA+IEl0J3MgYSBmYWlyIGNvbXBsYWludCBhbmQgSSBhZ3JlZSB3aXRoIGl0LiBN eSBjb3VudGVyIGFyZ3VtZW50IGlzIHRoZQo+PiA+IG9wcG9zaXRlIGlzIHRydWUgdG9vOiBtb3N0 IGlkZWFsIGJlbmNobWFya3MgZG9uJ3QgbWVhc3VyZSB3aGF0IG1vc3QKPj4gPiB1c2VycyBzZWUu IFdoaWxlIHRoZSBkYXRhIHdnb25nIHByb3ZpZGVkIGFyZSB3YXkgbW9yZSBub2lzeSB0aGFuIEkK Pj4gPiBsaWtlLCBteSBvdmVyYWxsICJjb25maWRlbmNlIiBpbiB0aGUgImNvbmNsdXNpb24iIEkg b2ZmZXJlZCBpcyBzdGlsbAo+PiA+IHBvc2l0aXZlLgo+Pgo+PiBSaWdodC4gSSBndWVzcyBJIHdv dWxkIGp1c3QgcHJlZmVyIGEgc2xpZ2h0bHkgbW9yZSBjb21wcmVoZW5zaXZlCj4+IGV2YWx1YXRp b24gdG8gYmFzZSBhIDR4IGluY3JlYXNlIGluIGJ1ZmZlciBzaXplIG9uLi4uCj4KPiBLYWxsZSwg aXMgdGhpcyB3aHkgeW91IGRpZG4ndCBhY2NlcHQgdGhpcyBwYXRjaD8gT3RoZXIgcmVhc29ucz8K Ckp1c3QgZm9yIHJlZmVyZW5jZSwgaGVyZSBhcmUgcGF0Y2h3b3JrIGxpbmtzOgoKaHR0cHM6Ly9w YXRjaHdvcmsua2VybmVsLm9yZy9jb3Zlci8xMDU1OTcyOS8KaHR0cHM6Ly9wYXRjaHdvcmsua2Vy bmVsLm9yZy9wYXRjaC8xMDU1OTczMS8KaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRj aC8xMDU1OTczMy8KClRoZSBtYWM4MDIxMSBwYXRjaCBpcyBhY2NlcHRlZCBhbmQgdGhlIGF0aDEw ayBwYXRjaCBpcyBkZWZlcnJlZC4gSUlSQyBJCnB1dCBpdCBkZWZlcnJlZCBhcyBJIGRpZG4ndCBz ZWUgYSByZWFsIGNvbnNlbnN1cyBhYm91dCB0aGUgcGF0Y2ggYW5kIHdhcwpzdXBwb3NlZCB0byBs b29rIGF0IGl0IGxhdGVyLCBidXQgaGF2ZW4ndCBkb25lIHlldC4gSSBkb24ndCBoYXZlIGFueQpp c3N1ZXMgd2l0aCB0aGUgcGF0Y2gsIGV4Y2VwdCBtYXliZSByZW1vdmluZyB0aGUgZHVwbGljYXRl IGRlZmluZSBmb3IKOTM3NyAod2hpY2ggSSBjYW4gZWFzaWx5IGZpeCBpbiB0aGUgcGVuZGluZyBi cmFuY2gpLgoKLS0gCkthbGxlIFZhbG8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 334EBC43381 for ; Thu, 21 Feb 2019 04:39:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC8E32148D for ; Thu, 21 Feb 2019 04:39:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="KVltXBZg"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="LVhXjlYp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726234AbfBUEjw (ORCPT ); Wed, 20 Feb 2019 23:39:52 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:39812 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbfBUEjv (ORCPT ); Wed, 20 Feb 2019 23:39:51 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B82AA608FB; Thu, 21 Feb 2019 04:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1550723990; bh=ziBRonHZubtJ/YGdZVpTd1BLIdHGV2jWG7r5H2Ec+Cs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KVltXBZgvWqfHXtLoAVkfG44/zQUu40vCFGgnyRTxJkLzbmoxkQx2/XqwCV1tFzgJ 9FHcEW2MQYOI9392LCfC+qw1sgAf4Rag6ae7GGzYteY2T47d9gEQWiMKquzLsgCJjN W38h9hgVFuzxlynxV6WeaS+c+VuniXvYQDIZhMuw= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1E375605FC; Thu, 21 Feb 2019 04:39:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1550723979; bh=ziBRonHZubtJ/YGdZVpTd1BLIdHGV2jWG7r5H2Ec+Cs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LVhXjlYpIHs5izlScGxFoYPfEuRJcrsg45jcmZhFaLdQgZcl2ZNetTJURZ19pxsVx BAx1BmuYiPCcloHe9JeTC22vbmF9Z5ngEOpPxCqX5czIuagkIDCETuWI4UwEAItMSw LQbfHRpMEmgABPC5Pn8ewfy0LJ17ag6y5sYy3a0k= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1E375605FC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Grant Grundler Cc: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= , linux-wireless@vger.kernel.org, Johannes Berg , wgong@qti.qualcomm.com, ath10k@lists.infradead.org, wgong@codeaurora.org Subject: Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips References: <1533724802-30944-1-git-send-email-wgong@codeaurora.org> <1533724802-30944-3-git-send-email-wgong@codeaurora.org> <87sh3pdtpg.fsf@toke.dk> <87mutue4y8.fsf@toke.dk> <1535967508.3437.31.camel@sipsolutions.net> <87in3m25uu.fsf@toke.dk> <1535975240.3437.61.camel@sipsolutions.net> <878t4i1z74.fsf@toke.dk> <871sa7ylmi.fsf@toke.dk> Date: Thu, 21 Feb 2019 06:39:35 +0200 In-Reply-To: (Grant Grundler's message of "Wed, 20 Feb 2019 11:15:02 -0800") Message-ID: <87ftshpxfc.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Grant Grundler writes: > On Thu, Sep 6, 2018 at 3:18 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> >> Grant Grundler writes: >> >> >> And, well, Grant's data is from a single test in a noisy >> >> environment where the time series graph shows that throughput is all = over >> >> the place for the duration of the test; so it's hard to draw solid >> >> conclusions from (for instance, for the 5-stream test, the average >> >> throughput for 6 is 331 and 379 Mbps for the two repetitions, and for= 7 >> >> it's 326 and 371 Mbps) . Unfortunately I don't have the same hardware >> >> used in this test, so I can't go verify it myself; so the only thing I >> >> can do is grumble about it here... :) >> > >> > It's a fair complaint and I agree with it. My counter argument is the >> > opposite is true too: most ideal benchmarks don't measure what most >> > users see. While the data wgong provided are way more noisy than I >> > like, my overall "confidence" in the "conclusion" I offered is still >> > positive. >> >> Right. I guess I would just prefer a slightly more comprehensive >> evaluation to base a 4x increase in buffer size on... > > Kalle, is this why you didn't accept this patch? Other reasons? Just for reference, here are patchwork links: https://patchwork.kernel.org/cover/10559729/ https://patchwork.kernel.org/patch/10559731/ https://patchwork.kernel.org/patch/10559733/ The mac80211 patch is accepted and the ath10k patch is deferred. IIRC I put it deferred as I didn't see a real consensus about the patch and was supposed to look at it later, but haven't done yet. I don't have any issues with the patch, except maybe removing the duplicate define for 9377 (which I can easily fix in the pending branch). --=20 Kalle Valo