From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gw5AK-00031M-Fj for qemu-devel@nongnu.org; Tue, 19 Feb 2019 08:10:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gw5AJ-0002L4-Ql for qemu-devel@nongnu.org; Tue, 19 Feb 2019 08:10:28 -0500 From: Markus Armbruster References: <20190219114609.1582-1-berrange@redhat.com> Date: Tue, 19 Feb 2019 14:10:18 +0100 In-Reply-To: <20190219114609.1582-1-berrange@redhat.com> ("Daniel P. =?utf-8?Q?Berrang=C3=A9=22's?= message of "Tue, 19 Feb 2019 11:46:09 +0000") Message-ID: <87ftsjvs91.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qemu-img: fix error reporting for -object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. =?utf-8?Q?Berrang=C3=A9?=" Cc: qemu-devel@nongnu.org, Kevin Wolf , qemu-block@nongnu.org, qemu-stable@nongnu.org, Max Reitz Daniel P. Berrang=C3=A9 writes: > Error reporting for user_creatable_add_opts_foreach was changed so that > it no longer called 'error_report_err' in: > > commit 7e1e0c11127bde81cff260fc6859690435c509d6 > Author: Markus Armbruster > Date: Wed Oct 17 10:26:43 2018 +0200 > > qom: Clean up error reporting in user_creatable_add_opts_foreach() > > Some callers were updated to pass in "&error_fatal" but all the ones in > qemu-img were left passing NULL. As a result all errors went to > /dev/null instead of being reported to the user. > > Signed-off-by: Daniel P. Berrang=C3=A9 Mea culpa, I have no idea how this happened. Reviewed-by: Markus Armbruster