From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 04/46] drm/i915: Markup paired operations on wakerefs Date: Wed, 09 Jan 2019 11:23:53 +0200 Message-ID: <87ftu22nh2.fsf@gaia.fi.intel.com> References: <20190107115509.12523-1-chris@chris-wilson.co.uk> <20190107115509.12523-4-chris@chris-wilson.co.uk> <87k1jf2k5l.fsf@gaia.fi.intel.com> <154696569366.30943.8523963162255757545@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 433926EBEF for ; Wed, 9 Jan 2019 09:25:34 +0000 (UTC) In-Reply-To: <154696569366.30943.8523963162255757545@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Jani Nikula List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUXVvdGlu ZyBNaWthIEt1b3BwYWxhICgyMDE5LTAxLTA4IDE2OjIzOjE4KQo+PiA+IEBAIC0zOTY1LDcgKzQw MTQsNyBAQCB2b2lkIGludGVsX3Bvd2VyX2RvbWFpbnNfaW5pdF9odyhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsIGJvb2wgcmVzdW1lKQo+PiA+ICB2b2lkIGludGVsX3Bvd2VyX2Rv bWFpbnNfZmluaV9odyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ID4gIHsK Pj4gPiAgICAgICAvKiBLZWVwIHRoZSBwb3dlciB3ZWxsIGVuYWJsZWQsIGJ1dCBjYW5jZWwgaXRz IHJwbSB3YWtlcmVmLiAqLwo+PiA+IC0gICAgIGludGVsX3J1bnRpbWVfcG1fcHV0KGRldl9wcml2 KTsKPj4gPiArICAgICBpbnRlbF9ydW50aW1lX3BtX3B1dF91bmNoZWNrZWQoZGV2X3ByaXYpOwo+ PiA+ICAKPj4gPiAgICAgICAvKiBSZW1vdmUgdGhlIHJlZmNvdW50IHdlIHRvb2sgdG8ga2VlcCBw b3dlciB3ZWxsIHN1cHBvcnQgZGlzYWJsZWQuICovCj4+ID4gICAgICAgaWYgKCFpOTE1X21vZHBh cmFtcy5kaXNhYmxlX3Bvd2VyX3dlbGwpCj4+ID4gQEAgLTQxNzksNyArNDIyOCw3IEBAIHN0YXRp YyB2b2lkIGludGVsX3Bvd2VyX2RvbWFpbnNfdmVyaWZ5X3N0YXRlKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPj4gPiAgICogQW55IHJ1bnRpbWUgcG0gcmVmZXJlbmNlIG9idGFp bmVkIGJ5IHRoaXMgZnVuY3Rpb24gbXVzdCBoYXZlIGEgc3ltbWV0cmljCj4+ID4gICAqIGNhbGwg dG8gaW50ZWxfcnVudGltZV9wbV9wdXQoKSB0byByZWxlYXNlIHRoZSByZWZlcmVuY2UgYWdhaW4u Cj4+ID4gICAqLwo+PiAKPj4gTmVlZCB0byB1cGRhdGUgdGhlIGRvY3VtZW50YXRpb24uCj4KPiBO by4gWW91IGFyZSBleHBlY3RlZCB0byBwYWlyIGludGVsX3J1bnRpbWVfcG1fZ2V0IHdpdGggaW50 ZWxfcnVudGltZV9wbV9wdXQuCj4gVGhlIF91bmNoZWNrZWQgdmVyc2lvbiBpcyB0ZW1wb3Jhcnkg YW5kIG5vdCBleHBlY3RlZCB0byBiZSB1c2VkIGluIG5ldyBjb2RlLgo+IE9uY2UgdGhlIGR1c3Qg aGFzIHNldHRsZWQgaXQgd2lsbCBiZSBnb25lLgo+Cj4gKiBBbnkgcnVudGltZSBwbSByZWZlcmVu Y2Ugb2J0YWluZWQgYnkgdGhpcyBmdW5jdGlvbiBtdXN0IGhhdmUgYSBzeW1tZXRyaWMKPiAqIGNh bGwgdG8gaW50ZWxfcnVudGltZV9wbV9wdXQoKSB0byByZWxlYXNlIHRoZSByZWZlcmVuY2UgYWdh aW4uCj4KPiBpcyBhY2N1cmF0ZS4KCk9rLgo+Cj4+ID4gLXZvaWQgaW50ZWxfcnVudGltZV9wbV9n ZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4+ID4gK2ludGVsX3dha2VyZWZfdCBp bnRlbF9ydW50aW1lX3BtX2dldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPj4gPiAg ewo+PiA+ICAgICAgIHN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gaTkxNS0+ZHJtLnBkZXY7Cj4+ID4g ICAgICAgc3RydWN0IGRldmljZSAqa2RldiA9ICZwZGV2LT5kZXY7Cj4+ID4gQEAgLTQxOTEsNyAr NDI0MCw3IEBAIHZvaWQgaW50ZWxfcnVudGltZV9wbV9nZXQoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmk5MTUpCj4+ID4gICAgICAgYXRvbWljX2luYygmaTkxNS0+cnVudGltZV9wbS53YWtlcmVm X2NvdW50KTsKPj4gPiAgICAgICBhc3NlcnRfcnBtX3dha2Vsb2NrX2hlbGQoaTkxNSk7Cj4+ID4g IAo+PiA+IC0gICAgIHRyYWNrX2ludGVsX3J1bnRpbWVfcG1fd2FrZXJlZihpOTE1KTsKPj4gPiAr ICAgICByZXR1cm4gdHJhY2tfaW50ZWxfcnVudGltZV9wbV93YWtlcmVmKGk5MTUpOwo+PiA+ICB9 Cj4+ID4gIAo+PiA+ICAvKioKPj4gPiBAQCAtNDIwNyw3ICs0MjU2LDcgQEAgdm9pZCBpbnRlbF9y dW50aW1lX3BtX2dldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPj4gPiAgICoKPj4g PiAgICogUmV0dXJuczogVHJ1ZSBpZiB0aGUgd2FrZXJlZiB3YXMgYWNxdWlyZWQsIG9yIEZhbHNl IG90aGVyd2lzZS4KPj4gCj4+IEZvciBwcmFjdGljYWwgcHVycG9zZXMgdGhpcyBjb3VsZCBzdGls bCBiZSB0aGUgY2FzZSBidXQgcGxlYXNlIHVwZGF0ZQo+PiB0aGUgcmV0dXJuIHZhbHVlIHR5cGUu Cj4KPiBTdGlsbCBzaG91bGQgYmUgdXNlZCBhcyBhIGJvb2xlYW4gKHRydWUvZmFsc2UpIHRob3Vn aC4KCkFncmVlZCBidXQgdGhpcyBpcyBkb2N1bWVudGF0aW9uIGZvciBmdW5jdGlvbi4gSXQgcmV0 dXJucyBhIHdha2VyZWYuCgo+Cj4+ID4gICAqLwo+PiA+IC1ib29sIGludGVsX3J1bnRpbWVfcG1f Z2V0X2lmX2luX3VzZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPj4gPiAraW50ZWxf d2FrZXJlZl90IGludGVsX3J1bnRpbWVfcG1fZ2V0X2lmX2luX3VzZShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqaTkxNSkKPj4gPiAgewo+PiA+ICAgICAgIGlmIChJU19FTkFCTEVEKENPTkZJR19Q TSkpIHsKPj4gPiAgICAgICAgICAgICAgIHN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gaTkxNS0+ZHJt LnBkZXY7Cj4+ID4gQEAgLTQyMjAsMTUgKzQyNjksMTMgQEAgYm9vbCBpbnRlbF9ydW50aW1lX3Bt X2dldF9pZl9pbl91c2Uoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4+ID4gICAgICAg ICAgICAgICAgKiBhdG0gdG8gdGhlIGxhdGUvZWFybHkgc3lzdGVtIHN1c3BlbmQvcmVzdW1lIGhh bmRsZXJzLgo+PiA+ICAgICAgICAgICAgICAgICovCj4+ID4gICAgICAgICAgICAgICBpZiAocG1f cnVudGltZV9nZXRfaWZfaW5fdXNlKGtkZXYpIDw9IDApCj4+ID4gLSAgICAgICAgICAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKPj4gPiArICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4+ ID4gICAgICAgfQo+PiA+ICAKPj4gPiAgICAgICBhdG9taWNfaW5jKCZpOTE1LT5ydW50aW1lX3Bt Lndha2VyZWZfY291bnQpOwo+PiA+ICAgICAgIGFzc2VydF9ycG1fd2FrZWxvY2tfaGVsZChpOTE1 KTsKPj4gPiAgCj4+ID4gLSAgICAgdHJhY2tfaW50ZWxfcnVudGltZV9wbV93YWtlcmVmKGk5MTUp Owo+PiA+IC0KPj4gPiAtICAgICByZXR1cm4gdHJ1ZTsKPj4gPiArICAgICByZXR1cm4gdHJhY2tf aW50ZWxfcnVudGltZV9wbV93YWtlcmVmKGk5MTUpOwo+PiA+ICB9Cj4+ID4gIAo+PiA+ICAvKioK Pj4gPiBAQCAtNDI0OCw3ICs0Mjk1LDcgQEAgYm9vbCBpbnRlbF9ydW50aW1lX3BtX2dldF9pZl9p bl91c2Uoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4+ID4gICAqIEFueSBydW50aW1l IHBtIHJlZmVyZW5jZSBvYnRhaW5lZCBieSB0aGlzIGZ1bmN0aW9uIG11c3QgaGF2ZSBhIHN5bW1l dHJpYwo+PiA+ICAgKiBjYWxsIHRvIGludGVsX3J1bnRpbWVfcG1fcHV0KCkgdG8gcmVsZWFzZSB0 aGUgcmVmZXJlbmNlIGFnYWluLgo+PiA+ICAgKi8KPj4gCj4+IERvY3VtZW50IHVwZGF0ZSBuZWVk ZWQgaGVyZSBhbHNvLgo+Cj4gTm9wZS4KPgo+PiA+IC12b2lkIGludGVsX3J1bnRpbWVfcG1fZ2V0 X25vcmVzdW1lKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+PiA+ICtpbnRlbF93YWtl cmVmX3QgaW50ZWxfcnVudGltZV9wbV9nZXRfbm9yZXN1bWUoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmk5MTUpCj4+ID4gIHsKPj4gPiAgICAgICBzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IGk5MTUt PmRybS5wZGV2Owo+PiA+ICAgICAgIHN0cnVjdCBkZXZpY2UgKmtkZXYgPSAmcGRldi0+ZGV2Owo+ PiA+IEBAIC00MjU4LDcgKzQzMDUsNyBAQCB2b2lkIGludGVsX3J1bnRpbWVfcG1fZ2V0X25vcmVz dW1lKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+PiA+ICAKPj4gPiAgICAgICBhdG9t aWNfaW5jKCZpOTE1LT5ydW50aW1lX3BtLndha2VyZWZfY291bnQpOwo+PiA+ICAKPj4gPiAtICAg ICB0cmFja19pbnRlbF9ydW50aW1lX3BtX3dha2VyZWYoaTkxNSk7Cj4+ID4gKyAgICAgcmV0dXJu IHRyYWNrX2ludGVsX3J1bnRpbWVfcG1fd2FrZXJlZihpOTE1KTsKPj4gPiAgfQo+PiA+ICAKPj4g PiAgLyoqCj4+ID4gQEAgLTQyNjksNyArNDMxNiw3IEBAIHZvaWQgaW50ZWxfcnVudGltZV9wbV9n ZXRfbm9yZXN1bWUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4+ID4gICAqIGludGVs X3J1bnRpbWVfcG1fZ2V0KCkgYW5kIG1pZ2h0IHBvd2VyIGRvd24gdGhlIGNvcnJlc3BvbmRpbmcK Pj4gPiAgICogaGFyZHdhcmUgYmxvY2sgcmlnaHQgYXdheSBpZiB0aGlzIGlzIHRoZSBsYXN0IHJl ZmVyZW5jZS4KPj4gPiAgICovCj4+IAo+PiBEb2N1bWVudGF0aW9uIHBhcnQgbmVlZHMgdXBkYXRp bmcuCj4KPiBJIGVpdGhlciBkb24ndCBnZXQgeW91ciBwb2ludCwgb3IgeW91IG1pc3NlZCB0aGUg cG9pbnQgb2YgdGhlIHdha2VyZWYKPiB0cmFja2luZz8gOikKCkkgc2hvdWxkIGhhdmUgYmVlbiBt b3JlIHNwZWNpZmljLiBNeSBjb25jZXJuIHdhcyBvbiBkb2N1bWVudGluZwp0aGUgY2hhbmdpbmcg cmV0dXJuIHZhbHVlcy4KLU1pa2EKCgo+IC1DaHJpcwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK