From: Markus Armbruster <armbru@redhat.com>
To: Li Qiang <liq3ea@163.com>
Cc: pbonzini@redhat.com, Fam Zheng <fam@euphon.net>,
liq3ea@gmail.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Hot-pluggable device without ->unrealize() is highly suspect (was: [PATCH] hw: scsi: dc390: add device unrealize function)
Date: Thu, 29 Nov 2018 20:02:34 +0100 [thread overview]
Message-ID: <87ftvj4shh.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20181129152552.14363-1-liq3ea@163.com> (Li Qiang's message of "Thu, 29 Nov 2018 07:25:52 -0800")
Li Qiang <liq3ea@163.com> writes:
> Currently the dc390 device has no unrealize function. This
> can cause memory leak when hotplug/unplug device. Also more
> serious, it will trigger an assert when rehotplug.
[...]
When a hot-pluggable device doesn't have an ->unrealize() method, unplug
is probably broken. I think we should track down such devices for
review. Any takers?
next prev parent reply other threads:[~2018-11-29 19:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 15:25 [Qemu-devel] [PATCH] hw: scsi: dc390: add device unrealize function Li Qiang
2018-11-29 19:02 ` Markus Armbruster [this message]
2018-11-29 19:11 ` [Qemu-devel] Hot-pluggable device without ->unrealize() is highly suspect (was: [PATCH] hw: scsi: dc390: add device unrealize function) Peter Maydell
2018-11-30 7:40 ` [Qemu-devel] Hot-pluggable device without ->unrealize() is highly suspect Markus Armbruster
2018-11-30 11:20 ` Peter Maydell
2018-12-03 17:44 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftvj4shh.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=fam@euphon.net \
--cc=liq3ea@163.com \
--cc=liq3ea@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.