From: Markus Armbruster <armbru@redhat.com>
To: Fei Li <fli@suse.com>
Cc: Fam Zheng <fam@euphon.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal_init fails
Date: Thu, 29 Nov 2018 09:35:11 +0100 [thread overview]
Message-ID: <87ftvkcmdc.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <13916895-daeb-15ad-5540-be15d1dd7e73@suse.com> (Fei Li's message of "Thu, 29 Nov 2018 14:16:53 +0800")
Fei Li <fli@suse.com> writes:
> On 11/28/2018 08:53 PM, Markus Armbruster wrote:
>> Fei Li <fli@suse.com> writes:
>>
>>> When qemu_signal_init() fails in qemu_init_main_loop(), we return
>>> without setting an error. Its callers crash then when they try to
>>> report the error with error_report_err().
>> Yes, that's a bug. Broken in 2f78e491d7b, v2.2.0. Has escaped notice
>> since qemu_signalfd() is quite unlikely to fail. Could go into 3.1 as a
>> bug fix, but I think punting it to the next release is just fine.
> Thanks. :) BTW, should I send the next version only includes patch 1/5
> and 2/5 separately so that you can merge? (I guess Dave will help to
> merge the other three migration related patches)
I can pick patches out of a series for merging, and I trust Dave can,
too. But keeping unrelated fixes separate is a good idea. I can see
three groups: PATCH 1 (main loop), PATCH 2 (thread abstraction), PATCH
3-5 (migration).
[...]
next prev parent reply other threads:[~2018-11-29 8:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 10:33 [Qemu-devel] [PATCH RFC 0/5] fix some segmentation faults and migration issues Fei Li
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal_init fails Fei Li
2018-11-28 12:53 ` Markus Armbruster
2018-11-29 6:16 ` Fei Li
2018-11-29 8:35 ` Markus Armbruster [this message]
2018-11-29 9:15 ` Fei Li
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 2/5] qemu_thread_join: fix segmentation fault Fei Li
2018-11-29 14:32 ` Philippe Mathieu-Daudé
2018-11-30 11:38 ` Fei Li
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 3/5] migration: fix the multifd code when receiving less channels Fei Li
2018-11-28 12:17 ` Peter Xu
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 4/5] migration: remove unused &local_err parameter in multifd_save_cleanup Fei Li
2018-11-28 10:33 ` [Qemu-devel] [PATCH RFC 5/5] migration: add more error handling for postcopy_ram_enable_notify Fei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftvkcmdc.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=fam@euphon.net \
--cc=fli@suse.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.