From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPBmB-00062h-FC for qemu-devel@nongnu.org; Tue, 20 Nov 2018 14:33:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPBm4-0000bU-IH for qemu-devel@nongnu.org; Tue, 20 Nov 2018 14:33:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55800) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gPBlz-0000Mx-SP for qemu-devel@nongnu.org; Tue, 20 Nov 2018 14:33:24 -0500 From: Markus Armbruster References: <20181119154737.9840-1-liq3ea@163.com> <20181119154737.9840-4-liq3ea@163.com> Date: Tue, 20 Nov 2018 20:33:09 +0100 In-Reply-To: <20181119154737.9840-4-liq3ea@163.com> (Li Qiang's message of "Mon, 19 Nov 2018 07:47:37 -0800") Message-ID: <87ftvv8ryi.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 3/3] fw_cfg: make qemu_extra_params_fw locally List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Li Qiang Cc: pbonzini@redhat.com, kraxel@redhat.com, lersek@redhat.com, philmd@redhat.com, qemu-devel@nongnu.org Li Qiang writes: > qemu_extra_params_fw[] has external linkage, but is used > only in fw_cfg_bootsplash(), it makes sense to make it > locally. > > Suggested-by: Markus Armbruster > Signed-off-by: Li Qiang Reviewed-by: Markus Armbruster