From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 2/2] drm/i915/sdvo: Utilize intel_panel for fixed_mode Date: Tue, 09 Oct 2018 17:44:57 +0300 Message-ID: <87ftxfnpqu.fsf@intel.com> References: <20180917151504.8754-1-ville.syrjala@linux.intel.com> <20180917151504.8754-2-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C4F189DA7 for ; Tue, 9 Oct 2018 14:45:21 +0000 (UTC) In-Reply-To: <20180917151504.8754-2-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAxNyBTZXAgMjAxOCwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4KPiBSZW1vdmUgdGhlIGxvY2FsIGx2ZHMgZml4ZWQgbW9kZSBwb2lu dGVyIGZyb20gdGhlIHNkdm8gZW5jb2Rlcgo+IHN0cnVjdHVyZSBhbmQgaW5zdGVhZCB1dGlsaXpl IGludGVsX3BhbmVsIGxpa2UgZXZlcnlvbmUgZWxzZS4KPgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTog SmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3Nkdm8uYyB8IDQwICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRp b25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2R2by5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2R2by5jCj4gaW5kZXggNzAxMzcyZTUxMmE4 Li4xMWU4ZDU5ODcwMmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf c2R2by5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2R2by5jCj4gQEAgLTEw NSwxMSArMTA1LDYgQEAgc3RydWN0IGludGVsX3Nkdm8gewo+ICAJYm9vbCBoYXNfaGRtaV9hdWRp bzsKPiAgCWJvb2wgcmdiX3F1YW50X3JhbmdlX3NlbGVjdGFibGU7Cj4gIAo+IC0JLyoqCj4gLQkg KiBUaGlzIGlzIHNkdm8gZml4ZWQgcGFubmVsIG1vZGUgcG9pbnRlcgo+IC0JICovCj4gLQlzdHJ1 Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqc2R2b19sdmRzX2ZpeGVkX21vZGU7Cj4gLQo+ICAJLyogRERD IGJ1cyB1c2VkIGJ5IHRoaXMgU0RWTyBlbmNvZGVyICovCj4gIAl1aW50OF90IGRkY19idXM7Cj4g IAo+IEBAIC03NjUsMTAgKzc2MCwxNCBAQCBpbnRlbF9zZHZvX2NyZWF0ZV9wcmVmZXJyZWRfaW5w dXRfdGltaW5nKHN0cnVjdCBpbnRlbF9zZHZvICppbnRlbF9zZHZvLAo+ICAJYXJncy5oZWlnaHQg PSBoZWlnaHQ7Cj4gIAlhcmdzLmludGVybGFjZSA9IDA7Cj4gIAo+IC0JaWYgKElTX0xWRFMoaW50 ZWxfc2R2b19jb25uZWN0b3IpICYmCj4gLQkgICAoaW50ZWxfc2R2by0+c2R2b19sdmRzX2ZpeGVk X21vZGUtPmhkaXNwbGF5ICE9IHdpZHRoIHx8Cj4gLQkgICAgaW50ZWxfc2R2by0+c2R2b19sdmRz X2ZpeGVkX21vZGUtPnZkaXNwbGF5ICE9IGhlaWdodCkpCj4gLQkJYXJncy5zY2FsZWQgPSAxOwo+ ICsJaWYgKElTX0xWRFMoaW50ZWxfc2R2b19jb25uZWN0b3IpKSB7Cj4gKwkJY29uc3Qgc3RydWN0 IGRybV9kaXNwbGF5X21vZGUgKmZpeGVkX21vZGUgPQo+ICsJCQlpbnRlbF9zZHZvX2Nvbm5lY3Rv ci0+YmFzZS5wYW5lbC5maXhlZF9tb2RlOwo+ICsKPiArCQlpZiAoZml4ZWRfbW9kZS0+aGRpc3Bs YXkgIT0gd2lkdGggfHwKPiArCQkgICAgZml4ZWRfbW9kZS0+dmRpc3BsYXkgIT0gaGVpZ2h0KQo+ ICsJCQlhcmdzLnNjYWxlZCA9IDE7Cj4gKwl9Cj4gIAo+ICAJcmV0dXJuIGludGVsX3Nkdm9fc2V0 X3ZhbHVlKGludGVsX3Nkdm8sCj4gIAkJCQkgICAgU0RWT19DTURfQ1JFQVRFX1BSRUZFUlJFRF9J TlBVVF9USU1JTkcsCj4gQEAgLTExNDQsNyArMTE0Myw3IEBAIHN0YXRpYyBib29sIGludGVsX3Nk dm9fY29tcHV0ZV9jb25maWcoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAkJcGlw ZV9jb25maWctPnNkdm9fdHZfY2xvY2sgPSB0cnVlOwo+ICAJfSBlbHNlIGlmIChJU19MVkRTKGlu dGVsX3Nkdm9fY29ubmVjdG9yKSkgewo+ICAJCWlmICghaW50ZWxfc2R2b19zZXRfb3V0cHV0X3Rp bWluZ3NfZnJvbV9tb2RlKGludGVsX3Nkdm8sCj4gLQkJCQkJCQkgICAgIGludGVsX3Nkdm8tPnNk dm9fbHZkc19maXhlZF9tb2RlKSkKPiArCQkJCQkJCSAgICAgaW50ZWxfc2R2b19jb25uZWN0b3It PmJhc2UucGFuZWwuZml4ZWRfbW9kZSkpCj4gIAkJCXJldHVybiBmYWxzZTsKPiAgCj4gIAkJKHZv aWQpIGludGVsX3Nkdm9fZ2V0X3ByZWZlcnJlZF9pbnB1dF9tb2RlKGludGVsX3Nkdm8sCj4gQEAg LTEzMDEsNyArMTMwMCw3IEBAIHN0YXRpYyB2b2lkIGludGVsX3Nkdm9fcHJlX2VuYWJsZShzdHJ1 Y3QgaW50ZWxfZW5jb2RlciAqaW50ZWxfZW5jb2RlciwKPiAgCS8qIGx2ZHMgaGFzIGEgc3BlY2lh bCBmaXhlZCBvdXRwdXQgdGltaW5nLiAqLwo+ICAJaWYgKElTX0xWRFMoaW50ZWxfc2R2b19jb25u ZWN0b3IpKQo+ICAJCWludGVsX3Nkdm9fZ2V0X2R0ZF9mcm9tX21vZGUoJm91dHB1dF9kdGQsCj4g LQkJCQkJICAgICBpbnRlbF9zZHZvLT5zZHZvX2x2ZHNfZml4ZWRfbW9kZSk7Cj4gKwkJCQkJICAg ICBpbnRlbF9zZHZvX2Nvbm5lY3Rvci0+YmFzZS5wYW5lbC5maXhlZF9tb2RlKTsKPiAgCWVsc2UK PiAgCQlpbnRlbF9zZHZvX2dldF9kdGRfZnJvbV9tb2RlKCZvdXRwdXRfZHRkLCBtb2RlKTsKPiAg CWlmICghaW50ZWxfc2R2b19zZXRfb3V0cHV0X3RpbWluZyhpbnRlbF9zZHZvLCAmb3V0cHV0X2R0 ZCkpCj4gQEAgLTE2NDIsMTAgKzE2NDEsMTMgQEAgaW50ZWxfc2R2b19tb2RlX3ZhbGlkKHN0cnVj dCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAkJcmV0dXJuIE1PREVfQ0xPQ0tfSElHSDsK PiAgCj4gIAlpZiAoSVNfTFZEUyhpbnRlbF9zZHZvX2Nvbm5lY3RvcikpIHsKPiAtCQlpZiAobW9k ZS0+aGRpc3BsYXkgPiBpbnRlbF9zZHZvLT5zZHZvX2x2ZHNfZml4ZWRfbW9kZS0+aGRpc3BsYXkp Cj4gKwkJY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmZpeGVkX21vZGUgPQo+ICsJCQlp bnRlbF9zZHZvX2Nvbm5lY3Rvci0+YmFzZS5wYW5lbC5maXhlZF9tb2RlOwo+ICsKPiArCQlpZiAo bW9kZS0+aGRpc3BsYXkgPiBmaXhlZF9tb2RlLT5oZGlzcGxheSkKPiAgCQkJcmV0dXJuIE1PREVf UEFORUw7Cj4gIAo+IC0JCWlmIChtb2RlLT52ZGlzcGxheSA+IGludGVsX3Nkdm8tPnNkdm9fbHZk c19maXhlZF9tb2RlLT52ZGlzcGxheSkKPiArCQlpZiAobW9kZS0+dmRpc3BsYXkgPiBmaXhlZF9t b2RlLT52ZGlzcGxheSkKPiAgCQkJcmV0dXJuIE1PREVfUEFORUw7Cj4gIAl9Cj4gIAo+IEBAIC0y MDYzLDYgKzIwNjUsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9zZHZvX2Rlc3Ryb3koc3RydWN0IGRy bV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgCXN0cnVjdCBpbnRlbF9zZHZvX2Nvbm5lY3RvciAq aW50ZWxfc2R2b19jb25uZWN0b3IgPSB0b19pbnRlbF9zZHZvX2Nvbm5lY3Rvcihjb25uZWN0b3Ip Owo+ICAKPiAgCWRybV9jb25uZWN0b3JfY2xlYW51cChjb25uZWN0b3IpOwo+ICsJaW50ZWxfcGFu ZWxfZmluaSgmaW50ZWxfc2R2b19jb25uZWN0b3ItPmJhc2UucGFuZWwpOwo+ICAJa2ZyZWUoaW50 ZWxfc2R2b19jb25uZWN0b3IpOwo+ICB9Cj4gIAo+IEBAIC0yMjY3LDEwICsyMjcwLDYgQEAgc3Rh dGljIHZvaWQgaW50ZWxfc2R2b19lbmNfZGVzdHJveShzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29k ZXIpCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9zZHZvICppbnRlbF9zZHZvID0gdG9fc2R2byh0b19p bnRlbF9lbmNvZGVyKGVuY29kZXIpKTsKPiAgCj4gLQlpZiAoaW50ZWxfc2R2by0+c2R2b19sdmRz X2ZpeGVkX21vZGUgIT0gTlVMTCkKPiAtCQlkcm1fbW9kZV9kZXN0cm95KGVuY29kZXItPmRldiwK PiAtCQkJCSBpbnRlbF9zZHZvLT5zZHZvX2x2ZHNfZml4ZWRfbW9kZSk7Cj4gLQo+ICAJaTJjX2Rl bF9hZGFwdGVyKCZpbnRlbF9zZHZvLT5kZGMpOwo+ICAJaW50ZWxfZW5jb2Rlcl9kZXN0cm95KGVu Y29kZXIpOwo+ICB9Cj4gQEAgLTI2NjMsMTMgKzI2NjIsMTYgQEAgaW50ZWxfc2R2b19sdmRzX2lu aXQoc3RydWN0IGludGVsX3Nkdm8gKmludGVsX3Nkdm8sIGludCBkZXZpY2UpCj4gIAo+ICAJbGlz dF9mb3JfZWFjaF9lbnRyeShtb2RlLCAmY29ubmVjdG9yLT5wcm9iZWRfbW9kZXMsIGhlYWQpIHsK PiAgCQlpZiAobW9kZS0+dHlwZSAmIERSTV9NT0RFX1RZUEVfUFJFRkVSUkVEKSB7Cj4gLQkJCWlu dGVsX3Nkdm8tPnNkdm9fbHZkc19maXhlZF9tb2RlID0KPiArCQkJc3RydWN0IGRybV9kaXNwbGF5 X21vZGUgKmZpeGVkX21vZGUgPQo+ICAJCQkJZHJtX21vZGVfZHVwbGljYXRlKGNvbm5lY3Rvci0+ ZGV2LCBtb2RlKTsKPiArCj4gKwkJCWludGVsX3BhbmVsX2luaXQoJmludGVsX2Nvbm5lY3Rvci0+ cGFuZWwsCj4gKwkJCQkJIGZpeGVkX21vZGUsIE5VTEwpOwo+ICAJCQlicmVhazsKPiAgCQl9Cj4g IAl9Cj4gIAo+IC0JaWYgKCFpbnRlbF9zZHZvLT5zZHZvX2x2ZHNfZml4ZWRfbW9kZSkKPiArCWlm ICghaW50ZWxfY29ubmVjdG9yLT5wYW5lbC5maXhlZF9tb2RlKQo+ICAJCWdvdG8gZXJyOwo+ICAK PiAgCXJldHVybiB0cnVlOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFw aGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==