From: Markus Armbruster <armbru@redhat.com>
To: Kashyap Chamarthy <kchamart@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
imammedo@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/2] Deprecate QMP `cpu-add`
Date: Mon, 08 Oct 2018 15:29:10 +0200 [thread overview]
Message-ID: <87ftxg36u1.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20181001124039.GF25720@paraplu> (Kashyap Chamarthy's message of "Mon, 1 Oct 2018 14:40:39 +0200")
Kashyap Chamarthy <kchamart@redhat.com> writes:
> On Mon, Oct 01, 2018 at 11:28:17AM +0200, Thomas Huth wrote:
>> On 2018-09-25 18:02, Kashyap Chamarthy wrote:
>
> [...]
>
>> > +++ b/qapi/misc.json
>> > @@ -1104,7 +1104,11 @@
>> > ##
>> > # @cpu-add:
>> > #
>> > -# Adds CPU with specified ID
>> > +# Adds CPU with specified ID.
>> > +#
>> > +# Notes: This command is deprecated. The `device_add` command should be
>>
>> s/Notes/Note/ ?
>
> Yeah, first I wrote the singular. But went with plural as I saw it as
> it was the 'majority' pattern:
>
> $> git grep "Note:" qapi/misc.json | wc -l
> 13
> $> git grep "Notes:" qapi/misc.json | wc -l
> 18
Not exactly overwhelming majority :)
> Maybe people use the plural, "Notes", as they can add multiple entries.
For what it's worth, our doc generator recognizes both.
[...]
prev parent reply other threads:[~2018-10-08 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180925160248.30801-1-kchamart@redhat.com>
[not found] ` <20180925160248.30801-3-kchamart@redhat.com>
[not found] ` <20180926172427.05a2de94@redhat.com>
[not found] ` <87zhw33t8z.fsf@dusky.pond.sub.org>
2018-10-01 8:18 ` [Qemu-devel] [PATCH v2 2/2] docs: Document vCPU hotplug procedure Kashyap Chamarthy
2018-10-01 8:59 ` Igor Mammedov
2018-10-08 19:10 ` Eric Blake
2018-10-09 9:59 ` Igor Mammedov
[not found] ` <20180925160248.30801-2-kchamart@redhat.com>
2018-10-01 9:28 ` [Qemu-devel] [PATCH v2 1/2] Deprecate QMP `cpu-add` Thomas Huth
2018-10-01 12:40 ` Kashyap Chamarthy
2018-10-08 13:29 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftxg36u1.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kchamart@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.