From: Markus Armbruster <armbru@redhat.com>
To: "Emilio G. Cota" <cota@braap.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Stefan Weil <sw@weilnetz.de>, Peter Xu <peterx@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler
Date: Wed, 15 Aug 2018 06:29:11 +0200 [thread overview]
Message-ID: <87ftzgqmlk.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20180815004420.GB17669@flamenco> (Emilio G. Cota's message of "Tue, 14 Aug 2018 20:44:20 -0400")
"Emilio G. Cota" <cota@braap.org> writes:
> On Tue, Aug 14, 2018 at 10:13:12 +0200, Paolo Bonzini wrote:
>> On 13/08/2018 19:11, Emilio G. Cota wrote:
>> > + struct qsp_report rep;
>>
>> Don't like camelcase? But that's really all that I have to remark on
>> this lovely series.
>
> I have a strong aversion to it :-)
I despise it as much as anyone, but CODING_STYLE demands CamelCase for
"type names" (which I interpret as typedef names), and convention (not
codified in CODING_STYLE) demands typedef for struct types.
> But if that's a deal breaker, let me know.
Hold your nose and go with the flow.
next prev parent reply other threads:[~2018-08-15 4:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 17:11 [Qemu-devel] [PATCH 0/3] synchronization profiler Emilio G. Cota
2018-08-13 17:11 ` [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler Emilio G. Cota
2018-08-14 8:13 ` Paolo Bonzini
2018-08-15 0:44 ` Emilio G. Cota
2018-08-15 4:29 ` Markus Armbruster [this message]
2018-08-15 3:09 ` Fam Zheng
2018-08-15 4:53 ` Emilio G. Cota
2018-08-15 7:04 ` Fam Zheng
2018-08-15 23:55 ` Emilio G. Cota
2018-08-16 4:29 ` Emilio G. Cota
2018-08-16 4:36 ` Fam Zheng
2018-08-13 17:11 ` [Qemu-devel] [PATCH 2/3] monitor: show sync profiling info with 'info sync' Emilio G. Cota
2018-08-14 8:14 ` Paolo Bonzini
2018-08-15 1:26 ` Emilio G. Cota
2018-08-16 13:20 ` Peter Xu
2018-08-14 9:43 ` Dr. David Alan Gilbert
2018-08-15 1:33 ` Emilio G. Cota
2018-08-14 16:03 ` Markus Armbruster
2018-08-13 17:11 ` [Qemu-devel] [PATCH 3/3] qsp: track BQL callers directly Emilio G. Cota
2018-08-15 23:30 ` [Qemu-devel] [PATCH 0/3] synchronization profiler no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftzgqmlk.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=cota@braap.org \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.