Re: [Qemu-devel] [PATCH 18/18] rbd: New parameter key-secret

[Markus Armbruster <armbru@redhat.com>]

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Tue, Jun 12, 2018 at 02:58:21PM +0200, Markus Armbruster wrote:
>> Legacy -drive supports "password-secret" parameter that isn't
>> available with -blockdev / blockdev-add.  That's because we backed out
>> our first try to provide it there due to interface design doubts, in
>> commit 577d8c9a811, v2.9.0.
>> 
>> This is the second try.  It brings back the parameter, except it's
>> named "key-secret" now.
>> 
>> Let's review our reasons for backing out the first try, as stated in
>> the commit message:
>> 
>>     * BlockdevOptionsRbd member @password-secret isn't actually a
>>       password, it's a key generated by Ceph.
>
> I thought about that when I first added password-secret, but felt
> that it is still effectively acting as a password to authenticate
> to the server, and calling it password-secret made it clearer that
> it was related to the authentication phase, and not for example,
> disk encryption.

I feel it's best to stick to the names Ceph uses, and Ceph calls it
"key".

[...]