From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915/execlists: Use rmb() to order CSB reads Date: Tue, 08 May 2018 16:21:34 +0300 Message-ID: <87fu32wae9.fsf@gaia.fi.intel.com> References: <20180508101506.22759-1-chris@chris-wilson.co.uk> <20180508125230.14528-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 758E56E960 for ; Tue, 8 May 2018 13:21:50 +0000 (UTC) In-Reply-To: <20180508125230.14528-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gV2UgYXNz dW1lIHRoYXQgdGhlIENTQiBpcyB3cml0dGVuIHVzaW5nIHRoZSBub3JtYWwgcmluZ2J1ZmZlcgo+ IGNvaGVyZW5jeSBwcm90b2NvbHMsIGFzIG91dGxpbmVkIGluIGtlcm5lbC9ldmVudHMvcmluZ19i dWZmZXIuYzoKPgo+ICAgICAqICAgKEhXKSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChE UklWRVIpCj4gICAgICoKPiAgICAgKiAgIGlmIChMT0FEIC0+ZGF0YV90YWlsKSB7ICAgICAgICAg ICAgTE9BRCAtPmRhdGFfaGVhZAo+ICAgICAqICAgICAgICAgICAgICAgICAgICAgIChBKSAgICAg ICAgICAgICBzbXBfcm1iKCkgICAgICAgKEMpCj4gICAgICogICAgICBTVE9SRSAkZGF0YSAgICAg ICAgICAgICAgICAgICAgIExPQUQgJGRhdGEKPiAgICAgKiAgICAgIHNtcF93bWIoKSAgICAgICAo QikgICAgICAgICAgICAgc21wX21iKCkgICAgICAgIChEKQo+ICAgICAqICAgICAgU1RPUkUgLT5k YXRhX2hlYWQgICAgICAgICAgICAgICBTVE9SRSAtPmRhdGFfdGFpbAo+ICAgICAqICAgfQo+Cj4g U28gd2UgYXNzdW1lIHRoYXQgdGhlIEhXIGZ1bGZpbHMgaXQncyBvcmRlcmluZyByZXF1aXJlbWVu dHMgKEIpLCBhbmQgc28KPiB3ZSBzaG91bGQgdXNlIGEgY29tcGxpbWVudGFyeSBybWIgKEMpIHRv IGVuc3VyZSB0aGF0IG91ciByZWFkIG9mIGl0cwo+IFdSSVRFIHBvaW50ZXIgaXMgY29tcGxldGVk IGJlZm9yZSB3ZSBzdGFydCBhY2Nlc3NpbmcgdGhlIGRhdGEuCj4KPiBUaGUgZmluYWwgbWIgKEQp IGlzIGltcGxpZWQgYnkgdGhlIHVuY2FjaGVkIG1taW8gd2UgcGVyZm9ybSB0byBpbmZvcm0KPiB0 aGUgSFcgb2Ygb3VyIFJFQUQgcG9pbnRlci4KPgo+IFJlZmVyZW5jZXM6IGh0dHBzOi8vYnVncy5m cmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTA2NAo+IFJlZmVyZW5jZXM6IGh0dHBz Oi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTg4OAo+IFJlZmVyZW5j ZXM6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjE4NQo+ IFJlZmVyZW5jZXM6IDYxYmY5NzE5ZmExNyAoImRybS9pOTE1L2NubDogVXNlIG1taW8gYWNjZXNz IHRvIGNvbnRleHQgc3RhdHVzIGJ1ZmZlciIpCj4gU3VnZ2VzdGVkLWJ5OiBNaWthIEt1b3BwYWxh IDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBX aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlr YS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFz LmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51 cnN1bGluQGludGVsLmNvbT4KPiBDYzogTWljaGHFgiBXaW5pYXJza2kgPG1pY2hhbC53aW5pYXJz a2lAaW50ZWwuY29tPgo+IENjOiBSYWZhZWwgQW50b2dub2xsaSA8cmFmYWVsLmFudG9nbm9sbGlA aW50ZWwuY29tPgo+IENjOiBNaWNoZWwgVGhpZXJyeSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29t Pgo+IENjOiBUaW1vIEFhbHRvbmVuIDx0amFhbHRvbkB1YnVudHUuY29tPgo+IFRlc3RlZC1ieTog VGltbyBBYWx0b25lbiA8dGphYWx0b25AdWJ1bnR1LmNvbT4KPiAtLS0KPgo+IEp1c3QgdHdlYWtl ZCB0aGUgY29tbWl0bXNnIHRvIGNyb3NzIHJlZmVyZW5jZSB0aGUgbWIgYWdhaW5zdCB0aGUKPiBk aWFncmFtLgo+IC1DaHJpcwo+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Vu Z2luZV9jcy5jIHwgMyAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgICAg ICAgfCAxICsKPiAgMiBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMyBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3Mu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gaW5kZXggNzAzMjVl MDgyNGUzLi44MzAzZTA1YjBjN2QgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZW5naW5lX2NzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdp bmVfY3MuYwo+IEBAIC00NzAsOSArNDcwLDYgQEAgc3RhdGljIGJvb2wgY3NiX2ZvcmNlX21taW8o c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gIAlpZiAoaW50ZWxfdmdwdV9hY3RpdmUo aTkxNSkgJiYgIWludGVsX3ZncHVfaGFzX2h3c3BfZW11bGF0aW9uKGk5MTUpKQo+ICAJCXJldHVy biB0cnVlOwo+ICAKPiAtCWlmIChJU19DQU5OT05MQUtFKGk5MTUpKQo+IC0JCXJldHVybiB0cnVl Owo+IC0KPiAgCXJldHVybiBmYWxzZTsKPiAgfQo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMu Ywo+IGluZGV4IDkxMWYyODhmNzhhYS4uODk3NzYwMGYwZDgxIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfbHJjLmMKPiBAQCAtOTkyLDYgKzk5Miw3IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19z dWJtaXNzaW9uX3Rhc2tsZXQodW5zaWduZWQgbG9uZyBkYXRhKQo+ICAKPiAgCQkJaGVhZCA9IGV4 ZWNsaXN0cy0+Y3NiX2hlYWQ7Cj4gIAkJCXRhaWwgPSBSRUFEX09OQ0UoYnVmW3dyaXRlX2lkeF0p Owo+ICsJCQlybWIoKTsgLyogSG9wZWZ1bGx5IHBhaXJlZCB3aXRoIGEgd21iKCkgaW4gSFcgKi8K CklmIHRoZSBncHUgZG9lcyBvcmRlcmVkIHdyaXRlcyAod2l0aCB3cml0ZSBidWZmZXIgaW4gYmV0 d2VlbiksIHRoaXMgaXMgb2suCgpJZiB0aGUgZ3B1IGRvZXMgbm90IG9yZGVyIHdyaXRlcywgd2Ug d291bGQgc3RpbGwgbmVlZCB0aGUgcm1iKCkKdG8gcHJldmVudCBjcHUgZnJvbSBsb2FkaW5nIGFu IHN0YWxlIGNzYiBlbnRyeSBhaGVhZCBvZiB0YWlsIHJlYWQ/CgpRdW90aW5nIG1lbW9yeS1iYXJy aWVzLnR4dDoKIiAoKikgbG9hZHMgbWF5IGJlIGRvbmUgc3BlY3VsYXRpdmVseSwgbGVhZGluZyB0 byB0aGUgcmVzdWx0IGhhdmluZyBiZWVuIGZldGNoZWQKICAgICBhdCB0aGUgd3JvbmcgdGltZSBp biB0aGUgZXhwZWN0ZWQgc2VxdWVuY2Ugb2YgZXZlbnRzOwoiCgpTbyBJIHdvdWxkIGNoYW5nZSB0 aGUgY29tbWVudCB0byAvKiBFbmZvcmNlIHRhaWwgdnMgY3NiIGVudHJ5IHJlYWQgb3JkZXIgKi8K Ci1NaWthCgo+ICAJCX0KPiAgCQlHRU1fVFJBQ0UoIiVzIGNzLWlycSBoZWFkPSVkIFslZCVzXSwg dGFpbD0lZCBbJWQlc11cbiIsCj4gIAkJCSAgZW5naW5lLT5uYW1lLAo+IC0tIAo+IDIuMTcuMApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK