From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1 Date: Mon, 30 Apr 2018 13:22:20 +0300 Message-ID: <87fu3d9eoz.fsf@intel.com> References: <20180425174253.4616-1-daniel.vetter@ffwll.ch> <20180425174253.4616-4-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 36E186E195 for ; Mon, 30 Apr 2018 10:19:41 +0000 (UTC) In-Reply-To: <20180425174253.4616-4-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: DRI Development , LKML Cc: Thomas Petazzoni , Daniel Thompson , Daniel Vetter , Jingoo Han , Daniel Vetter , Lee Jones List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyNSBBcHIgMjAxOCwgRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5j aD4gd3JvdGU6Cj4gTGVha2luZyBkcml2ZXIgaW50ZXJuYWwgdHJhY2tpbmcgaW50byB0aGUgYWxy ZWFkeSBtYXNzaXZlbHkgY29uZnVzaW5nCj4gYmFja2xpZ2h0IHBvd2VyIHRyYWNraW5nIGlzIHJl YWxseSBjb25mdXNpbmcuCj4KPiBMdWNraWx5IHdlIGhhdmUgYWxyZWFkeSBhIGRydmRhdGEgc3Ry dWN0dXJlLCBzbyBmaXhpbmcgdGhpcyBpcyByZWFsbHkKPiBlYXN5Lgo+Cj4gQ2M6IExlZSBKb25l cyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gQ2M6IERhbmllbCBUaG9tcHNvbiA8ZGFuaWVsLnRo b21wc29uQGxpbmFyby5vcmc+Cj4gQ2M6IEppbmdvbyBIYW4gPGppbmdvb2hhbjFAZ21haWwuY29t Pgo+IENjOiBUaG9tYXMgUGV0YXp6b25pIDx0aG9tYXMucGV0YXp6b25pQGZyZWUtZWxlY3Ryb25z LmNvbT4KPiBBY2tlZC1ieTogRGFuaWVsIFRob21wc29uIDxkYW5pZWwudGhvbXBzb25AbGluYXJv Lm9yZz4KPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVs LmNvbT4KClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoK PiAtLS0KPiAgZHJpdmVycy9zdGFnaW5nL2ZidGZ0L2ZidGZ0LWNvcmUuYyB8IDQgKystLQo+ICBk cml2ZXJzL3N0YWdpbmcvZmJ0ZnQvZmJ0ZnQuaCAgICAgIHwgMSArCj4gIDIgZmlsZXMgY2hhbmdl ZCwgMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvc3RhZ2luZy9mYnRmdC9mYnRmdC1jb3JlLmMgYi9kcml2ZXJzL3N0YWdpbmcvZmJ0ZnQvZmJ0 ZnQtY29yZS5jCj4gaW5kZXggMGUzNmI2NmFlNWY3Li43MzFlNDcxNDlhZjggMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9zdGFnaW5nL2ZidGZ0L2ZidGZ0LWNvcmUuYwo+ICsrKyBiL2RyaXZlcnMvc3Rh Z2luZy9mYnRmdC9mYnRmdC1jb3JlLmMKPiBAQCAtMjQ2LDcgKzI0Niw3IEBAIHN0YXRpYyBpbnQg ZmJ0ZnRfcmVxdWVzdF9ncGlvc19kdChzdHJ1Y3QgZmJ0ZnRfcGFyICpwYXIpCj4gIHN0YXRpYyBp bnQgZmJ0ZnRfYmFja2xpZ2h0X3VwZGF0ZV9zdGF0dXMoc3RydWN0IGJhY2tsaWdodF9kZXZpY2Ug KmJkKQo+ICB7Cj4gIAlzdHJ1Y3QgZmJ0ZnRfcGFyICpwYXIgPSBibF9nZXRfZGF0YShiZCk7Cj4g LQlib29sIHBvbGFyaXR5ID0gISEoYmQtPnByb3BzLnN0YXRlICYgQkxfQ09SRV9EUklWRVIxKTsK PiArCWJvb2wgcG9sYXJpdHkgPSBwYXItPnBvbGFyaXR5Owo+ICAKPiAgCWZidGZ0X3Bhcl9kYmco REVCVUdfQkFDS0xJR0hULCBwYXIsCj4gIAkJIiVzOiBwb2xhcml0eT0lZCwgcG93ZXI9JWQsIGZi X2JsYW5rPSVkXG4iLAo+IEBAIC0yOTYsNyArMjk2LDcgQEAgdm9pZCBmYnRmdF9yZWdpc3Rlcl9i YWNrbGlnaHQoc3RydWN0IGZidGZ0X3BhciAqcGFyKQo+ICAJLyogQXNzdW1lIGJhY2tsaWdodCBp cyBvZmYsIGdldCBwb2xhcml0eSBmcm9tIGN1cnJlbnQgc3RhdGUgb2YgcGluICovCj4gIAlibF9w cm9wcy5wb3dlciA9IEZCX0JMQU5LX1BPV0VSRE9XTjsKPiAgCWlmICghZ3Bpb19nZXRfdmFsdWUo cGFyLT5ncGlvLmxlZFswXSkpCj4gLQkJYmxfcHJvcHMuc3RhdGUgfD0gQkxfQ09SRV9EUklWRVIx Owo+ICsJCXBhci0+cG9sYXJpdHkgPSB0cnVlOwo+ICAKPiAgCWJkID0gYmFja2xpZ2h0X2Rldmlj ZV9yZWdpc3RlcihkZXZfZHJpdmVyX3N0cmluZyhwYXItPmluZm8tPmRldmljZSksCj4gIAkJCQkg ICAgICAgcGFyLT5pbmZvLT5kZXZpY2UsIHBhciwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zdGFn aW5nL2ZidGZ0L2ZidGZ0LmggYi9kcml2ZXJzL3N0YWdpbmcvZmJ0ZnQvZmJ0ZnQuaAo+IGluZGV4 IGUxOWU2NGUwZDA5NC4uYzdjYjRhNzg5NmY0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvc3RhZ2lu Zy9mYnRmdC9mYnRmdC5oCj4gKysrIGIvZHJpdmVycy9zdGFnaW5nL2ZidGZ0L2ZidGZ0LmgKPiBA QCAtMjI5LDYgKzIyOSw3IEBAIHN0cnVjdCBmYnRmdF9wYXIgewo+ICAJa3RpbWVfdCB1cGRhdGVf dGltZTsKPiAgCWJvb2wgYmdyOwo+ICAJdm9pZCAqZXh0cmE7Cj4gKwlib29sIHBvbGFyaXR5Owo+ ICB9Owo+ICAKPiAgI2RlZmluZSBOVU1BUkdTKC4uLikgIChzaXplb2YoKGludFtdKXtfX1ZBX0FS R1NfX30pL3NpemVvZihpbnQpKQoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBU ZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753075AbeD3KTm (ORCPT ); Mon, 30 Apr 2018 06:19:42 -0400 Received: from mga18.intel.com ([134.134.136.126]:51484 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752080AbeD3KTl (ORCPT ); Mon, 30 Apr 2018 06:19:41 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,346,1520924400"; d="scan'208";a="51101894" From: Jani Nikula To: Daniel Vetter , DRI Development , LKML Cc: Thomas Petazzoni , Daniel Thompson , Daniel Vetter , Jingoo Han , Daniel Vetter , Lee Jones Subject: Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1 In-Reply-To: <20180425174253.4616-4-daniel.vetter@ffwll.ch> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20180425174253.4616-1-daniel.vetter@ffwll.ch> <20180425174253.4616-4-daniel.vetter@ffwll.ch> Date: Mon, 30 Apr 2018 13:22:20 +0300 Message-ID: <87fu3d9eoz.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Apr 2018, Daniel Vetter wrote: > Leaking driver internal tracking into the already massively confusing > backlight power tracking is really confusing. > > Luckily we have already a drvdata structure, so fixing this is really > easy. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Thomas Petazzoni > Acked-by: Daniel Thompson > Signed-off-by: Daniel Vetter Reviewed-by: Jani Nikula > --- > drivers/staging/fbtft/fbtft-core.c | 4 ++-- > drivers/staging/fbtft/fbtft.h | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c > index 0e36b66ae5f7..731e47149af8 100644 > --- a/drivers/staging/fbtft/fbtft-core.c > +++ b/drivers/staging/fbtft/fbtft-core.c > @@ -246,7 +246,7 @@ static int fbtft_request_gpios_dt(struct fbtft_par *par) > static int fbtft_backlight_update_status(struct backlight_device *bd) > { > struct fbtft_par *par = bl_get_data(bd); > - bool polarity = !!(bd->props.state & BL_CORE_DRIVER1); > + bool polarity = par->polarity; > > fbtft_par_dbg(DEBUG_BACKLIGHT, par, > "%s: polarity=%d, power=%d, fb_blank=%d\n", > @@ -296,7 +296,7 @@ void fbtft_register_backlight(struct fbtft_par *par) > /* Assume backlight is off, get polarity from current state of pin */ > bl_props.power = FB_BLANK_POWERDOWN; > if (!gpio_get_value(par->gpio.led[0])) > - bl_props.state |= BL_CORE_DRIVER1; > + par->polarity = true; > > bd = backlight_device_register(dev_driver_string(par->info->device), > par->info->device, par, > diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h > index e19e64e0d094..c7cb4a7896f4 100644 > --- a/drivers/staging/fbtft/fbtft.h > +++ b/drivers/staging/fbtft/fbtft.h > @@ -229,6 +229,7 @@ struct fbtft_par { > ktime_t update_time; > bool bgr; > void *extra; > + bool polarity; > }; > > #define NUMARGS(...) (sizeof((int[]){__VA_ARGS__})/sizeof(int)) -- Jani Nikula, Intel Open Source Technology Center