From mboxrd@z Thu Jan  1 00:00:00 1970
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
Subject: Re: [PATCH net-next v4] Add Common Applications Kept Enhanced (cake) qdisc
Date: Fri, 27 Apr 2018 15:45:40 +0200
Message-ID: <87fu3g4vaz.fsf@toke.dk>
References: <20180427121706.23273-1-toke@toke.dk> <efb401ac-bc79-cbc5-cd03-120803b65b4d@gmail.com> <87in8c4vn7.fsf@toke.dk> <673fc1b9-809c-2e14-a054-7eb8beb9a8fd@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: cake@lists.bufferbloat.net, Dave Taht <dave.taht@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.toke.dk ([52.28.52.200]:59267 "EHLO mail.toke.dk"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1758355AbeD0Npm (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 27 Apr 2018 09:45:42 -0400
In-Reply-To: <673fc1b9-809c-2e14-a054-7eb8beb9a8fd@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Eric Dumazet <eric.dumazet@gmail.com> writes:

> On 04/27/2018 06:38 AM, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>>=20
>> Ah, right. Will fix.
>>=20
>> Is it safe to dereference the iph pointer before calling
>> pskb_may_pull()?
>
> No, please take a look at ip_rcv() for a typical use case.

Will do, thanks.

-Toke