From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH libdrm 1/3] xf86drm: replace sprintf()+strdup() with
 asprintf()
Date: Mon, 26 Mar 2018 16:57:20 +0300
Message-ID: <87fu4ney7z.fsf@intel.com>
References: <20180326102648.1754-1-eric.engestrom@imgtec.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 2A7F06E3FF
 for <dri-devel@lists.freedesktop.org>; Mon, 26 Mar 2018 13:56:29 +0000 (UTC)
In-Reply-To: <20180326102648.1754-1-eric.engestrom@imgtec.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Eric Engestrom <eric.engestrom@imgtec.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gTW9uLCAyNiBNYXIgMjAxOCwgRXJpYyBFbmdlc3Ryb20gPGVyaWMuZW5nZXN0cm9tQGltZ3Rl
Yy5jb20+IHdyb3RlOgo+IFNpZ25lZC1vZmYtYnk6IEVyaWMgRW5nZXN0cm9tIDxlcmljLmVuZ2Vz
dHJvbUBpbWd0ZWMuY29tPgo+IC0tLQo+ICB4Zjg2ZHJtLmMgfCAyOCArKysrKysrKysrKysrKy0t
LS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxNCBkZWxl
dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS94Zjg2ZHJtLmMgYi94Zjg2ZHJtLmMKPiBpbmRleCAz
YTlkMGVkMmNjOWIxOTZhZTdkMS4uYjZlNWQ4Y2MxYmI1MGZmZTc1YTIgMTAwNjQ0Cj4gLS0tIGEv
eGY4NmRybS5jCj4gKysrIGIveGY4NmRybS5jCj4gQEAgLTI4MjMsNyArMjgyMyw3IEBAIHN0YXRp
YyBjaGFyICpkcm1HZXRNaW5vck5hbWVGb3JGRChpbnQgZmQsIGludCB0eXBlKQo+ICAgICAgc3Ry
dWN0IHN0YXQgc2J1ZjsKPiAgICAgIGNvbnN0IGNoYXIgKm5hbWUgPSBkcm1HZXRNaW5vck5hbWUo
dHlwZSk7Cj4gICAgICBpbnQgbGVuOwo+IC0gICAgY2hhciBkZXZfbmFtZVs2NF0sIGJ1Zls2NF07
Cj4gKyAgICBjaGFyICpkZXZfbmFtZSwgYnVmWzY0XTsKPiAgICAgIGludCBtYWosIG1pbjsKPiAg
Cj4gICAgICBpZiAoIW5hbWUpCj4gQEAgLTI4NDgsMjAgKzI4NDgsMjIgQEAgc3RhdGljIGNoYXIg
KmRybUdldE1pbm9yTmFtZUZvckZEKGludCBmZCwgaW50IHR5cGUpCj4gIAo+ICAgICAgd2hpbGUg
KChlbnQgPSByZWFkZGlyKHN5c2RpcikpKSB7Cj4gICAgICAgICAgaWYgKHN0cm5jbXAoZW50LT5k
X25hbWUsIG5hbWUsIGxlbikgPT0gMCkgewo+IC0gICAgICAgICAgICBzbnByaW50ZihkZXZfbmFt
ZSwgc2l6ZW9mKGRldl9uYW1lKSwgRFJNX0RJUl9OQU1FICIvJXMiLAo+IC0gICAgICAgICAgICAg
ICAgIGVudC0+ZF9uYW1lKTsKPiArICAgICAgICAgICAgaWYgKGFzcHJpbnRmKCZkZXZfbmFtZSwg
RFJNX0RJUl9OQU1FICIvJXMiLAoKSnVzdCBub3RpbmcgaW4gcGFzc2luZyB0aGF0IGFzcHJpbnRm
IGlzIGEgR05VIGV4dGVuc2lvbiwgaXMgdGhhdCBva2F5PwoKQlIsCkphbmkuCgoKPiArICAgICAg
ICAgICAgICAgICBlbnQtPmRfbmFtZSkgPCAwKSB7Cj4gKyAgICAgICAgICAgICAgICBkZXZfbmFt
ZSA9IE5VTEw7Cj4gKyAgICAgICAgICAgIH0KPiAgCj4gICAgICAgICAgICAgIGNsb3NlZGlyKHN5
c2Rpcik7Cj4gLSAgICAgICAgICAgIHJldHVybiBzdHJkdXAoZGV2X25hbWUpOwo+ICsgICAgICAg
ICAgICByZXR1cm4gZGV2X25hbWU7Cj4gICAgICAgICAgfQo+ICAgICAgfQo+ICAgICAgcmV0dXJu
IE5VTEw7Cj4gICNlbHNlCj4gICAgICBzdHJ1Y3Qgc3RhdCBzYnVmOwo+IC0gICAgY2hhciBidWZb
UEFUSF9NQVggKyAxXTsKPiArICAgIGNoYXIgKmJ1ZjsKPiAgICAgIGNvbnN0IGNoYXIgKmRldl9u
YW1lOwo+ICAgICAgdW5zaWduZWQgaW50IG1haiwgbWluOwo+IC0gICAgaW50IG4sIGJhc2U7Cj4g
KyAgICBpbnQgYmFzZTsKPiAgCj4gICAgICBpZiAoZnN0YXQoZmQsICZzYnVmKSkKPiAgICAgICAg
ICByZXR1cm4gTlVMTDsKPiBAQCAtMjg5MCwxMSArMjg5MiwxMCBAQCBzdGF0aWMgY2hhciAqZHJt
R2V0TWlub3JOYW1lRm9yRkQoaW50IGZkLCBpbnQgdHlwZSkKPiAgICAgIGlmIChiYXNlIDwgMCkK
PiAgICAgICAgICByZXR1cm4gTlVMTDsKPiAgCj4gLSAgICBuID0gc25wcmludGYoYnVmLCBzaXpl
b2YoYnVmKSwgZGV2X25hbWUsIERSTV9ESVJfTkFNRSwgbWluIC0gYmFzZSk7Cj4gLSAgICBpZiAo
biA9PSAtMSB8fCBuID49IHNpemVvZihidWYpKQo+ICsgICAgaWYgKGFzcHJpbnRmKCZidWYsIGRl
dl9uYW1lLCBEUk1fRElSX05BTUUsIG1pbiAtIGJhc2UpIDwgMCkKPiAgICAgICAgICByZXR1cm4g
TlVMTDsKPiAgCj4gLSAgICByZXR1cm4gc3RyZHVwKGJ1Zik7Cj4gKyAgICByZXR1cm4gYnVmOwo+
ICAjZW5kaWYKPiAgfQo+ICAKPiBAQCAtNDExOSwxMCArNDEyMCwxMCBAQCBjaGFyICpkcm1HZXRE
ZXZpY2VOYW1lRnJvbUZkMihpbnQgZmQpCj4gICAgICByZXR1cm4gc3RyZHVwKHBhdGgpOwo+ICAj
ZWxzZQo+ICAgICAgc3RydWN0IHN0YXQgICAgICBzYnVmOwo+IC0gICAgY2hhciAgICAgICAgICAg
ICBub2RlW1BBVEhfTUFYICsgMV07Cj4gKyAgICBjaGFyICAgICAgICAgICAgKm5vZGU7Cj4gICAg
ICBjb25zdCBjaGFyICAgICAgKmRldl9uYW1lOwo+ICAgICAgaW50ICAgICAgICAgICAgICBub2Rl
X3R5cGU7Cj4gLSAgICBpbnQgICAgICAgICAgICAgIG1haiwgbWluLCBuLCBiYXNlOwo+ICsgICAg
aW50ICAgICAgICAgICAgICBtYWosIG1pbiwgYmFzZTsKPiAgCj4gICAgICBpZiAoZnN0YXQoZmQs
ICZzYnVmKSkKPiAgICAgICAgICByZXR1cm4gTlVMTDsKPiBAQCAtNDE1NSwxMSArNDE1NiwxMCBA
QCBjaGFyICpkcm1HZXREZXZpY2VOYW1lRnJvbUZkMihpbnQgZmQpCj4gICAgICBpZiAoYmFzZSA8
IDApCj4gICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gIAo+IC0gICAgbiA9IHNucHJpbnRmKG5vZGUs
IFBBVEhfTUFYLCBkZXZfbmFtZSwgRFJNX0RJUl9OQU1FLCBtaW4gLSBiYXNlKTsKPiAtICAgIGlm
IChuID09IC0xIHx8IG4gPj0gUEFUSF9NQVgpCj4gKyAgICBpZiAoYXNwcmludGYoJm5vZGUsIGRl
dl9uYW1lLCBEUk1fRElSX05BTUUsIG1pbiAtIGJhc2UpIDwgMCkKPiAgICAgICAgcmV0dXJuIE5V
TEw7Cj4gIAo+IC0gICAgcmV0dXJuIHN0cmR1cChub2RlKTsKPiArICAgIHJldHVybiBub2RlOwo+
ICAjZW5kaWYKPiAgfQoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9s
b2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK
aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK