From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Keith Packard" <keithp@keithp.com>
Subject: Re: [PATCH 1/5] drm/vblank: Fix return type for drm_vblank_count()
Date: Tue, 30 Jan 2018 22:42:13 -0800
Message-ID: <87fu6mlebe.fsf@keithp.com>
References: <20180112215707.3084-1-dhinakaran.pandiyan@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1789829275=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <20180112215707.3084-1-dhinakaran.pandiyan@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: intel-gfx@lists.freedesktop.org
Cc: Michel =?utf-8?Q?D=C3=A4nzer?= <michel@daenzer.net>, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>, dri-devel@lists.freedesktop.org, rodrigo.vivi@intel.com
List-Id: dri-devel@lists.freedesktop.org

--===============1789829275==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> writes:

> drm_vblank_count() has a u32 type returning what is a 64-bit vblank
> count.

It looks like a general review of the 64-bit widening patch is needed.

 * drm_crtc_accurate_vblank_count has a 32-bit return, and uses a 32-bit te=
mporary
 * drm_wait_one_vblank uses a 32-bit temporary.

I looked at every 'u32' in drm_vblank.c; it would be good to have more
eyes check this.

Thanks for finding the first one.

=2D-=20
=2Dkeith

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAlpxZUUACgkQ2yIaaQAA
ABEuEhAAs+q/OcUpKPLzJLs2Kdu+uvARNI1mmQRf4WMqy6WXKNEbHe1wr+qsbvV6
d3vFL4/dhGjCFW4Sd7brqKtWl1KXaLZaygECY4jGG2L5aPXvGVlJEr7LJH84Uf+K
HLCECzgGtCsvevlCL34h4jt9U5yxa6wMDtYggUP6PUv1fltUKYGFwW6DgVHKv42H
HVesH0WhPJaDfd6jskYgA/dynWKPpXskyltG5YdFSdns5wve4Go5UOf0oumMD1hS
6CWJQc6QQefiuGXiDvYcZvV4orzlxDFVbTMMJ54AsZXJLaGXoAgj2nX/x3iOjt6o
LyWcjIO6EOChOq25Iu1PUwUvaiHdBsghuTCOVmAJh0R2Utgu+w0yroMa+6RGvpUe
P7LZhChujCZ4VQWpkJ7IkllHZR+2LMLg7jKvZjUppXFqp9iloK8aKDERqth7ySA0
IqmNHw62yLAFN21iGkSQNmv14TQDWV1yibBYrPyHpL9Zb5nmxAwlJJf6fWnxGfpt
WsnkNzQ5ifBeiuXZHc2Q/ifC9+vGZbFrHm4CHrzZ327LmdJV8P7pL+Bc47h/8Hi5
407qnQr0QhY3dZShDCJt7Gh+LAtIsjiTLg3a+87qnFoZ/g+hBXDSs1uqX4rP+vvE
yp4WHKcoRznM2RAALXMT1YYOAOWyIDj2RjK2CtxGMwZt5wx6YDM=
=3yCm
-----END PGP SIGNATURE-----
--=-=-=--

--===============1789829275==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============1789829275==--