All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Christian Ludwig <chrissicool@googlemail.com>
Cc: git@vger.kernel.org, Christian Ludwig <chrissicool@gmail.com>,
	Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 2/2] send-email: Support separate Reply-To address
Date: Wed, 17 Jan 2018 23:06:44 +0100	[thread overview]
Message-ID: <87fu74i1hn.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20180117180801.31049-2-chrissicool@gmail.com>


On Wed, Jan 17 2018, Christian Ludwig jotted:

> +if (defined $reply_to) {
> +	$reply_to =~ s/^\s+|\s+$//g;
> +	($reply_to) = expand_aliases($reply_to);
> +	$reply_to = sanitize_address($reply_to);
> +}

Just a note to other reviewers: I found it odd to call a function with
one argument and then enforce list context, but I see expand_aliases()
expects to be called that way, and this is copied from a previous
pattern earlier in the file.

(As an aside, that code looks a bit odd, but then I see 302e04ea4d
("send-email: detect cycles in alias expansion", 2009-07-23) )

Looks good to me.

  parent reply	other threads:[~2018-01-17 22:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17 18:08 [PATCH v2 1/2] send-email: Rename variable for clarity Christian Ludwig
2018-01-17 18:08 ` [PATCH v2 2/2] send-email: Support separate Reply-To address Christian Ludwig
2018-01-17 21:02   ` Junio C Hamano
2018-01-17 22:06   ` Ævar Arnfjörð Bjarmason [this message]
2018-01-18 11:00   ` Martin Ågren
2018-01-17 19:05 ` [PATCH v2 1/2] send-email: Rename variable for clarity Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fu74i1hn.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=chrissicool@gmail.com \
    --cc=chrissicool@googlemail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.