diff for duplicates of <87fu82ahtw.fsf@kamboji.qca.qualcomm.com> diff --git a/a/1.txt b/N1/1.txt index 21436e2..db62137 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -11,7 +11,7 @@ Erik Stromdahl <erik.stromdahl@gmail.com> writes: This and patch 6 are somehow connected but the division is not clear. I think at least dma map/unmap changes should be split into their own -patch. +patch.=20 I recommend revisiting both patches 6 and 7. The htt layer can be quite tricky so better to have smaller logical changes to make it easier @@ -22,23 +22,23 @@ review them. > @@ -409,6 +409,9 @@ int ath10k_htt_tx_start(struct ath10k_htt *htt) > if (htt->tx_mem_allocated) > return 0; -> +> =20 > + if (ar->is_high_latency) > + return 0; > + -> ret = ath10k_htt_tx_alloc_buf(htt); +> ret =3D ath10k_htt_tx_alloc_buf(htt); > if (ret) > goto free_idr_pending_tx; > @@ -445,7 +448,8 @@ void ath10k_htt_tx_destroy(struct ath10k_htt *htt) > return; -> +> =20 > ath10k_htt_tx_free_cont_txbuf(htt); > - ath10k_htt_tx_free_txq(htt); > + if (!htt->ar->is_high_latency) > + ath10k_htt_tx_free_txq(htt); > ath10k_htt_tx_free_cont_frag_desc(htt); > ath10k_htt_tx_free_txdone_fifo(htt); -> htt->tx_mem_allocated = false; +> htt->tx_mem_allocated =3D false; These two don't look symmetric. You prevent calling these functions: @@ -54,9 +54,5 @@ ath10k_htt_tx_free_cont_txbuf(htt); ath10k_htt_tx_free_cont_frag_desc(htt); ath10k_htt_tx_free_txdone_fifo(htt); --- -Kalle Valo -_______________________________________________ -ath10k mailing list -ath10k@lists.infradead.org -http://lists.infradead.org/mailman/listinfo/ath10k +--=20 +Kalle Valo= diff --git a/a/content_digest b/N1/content_digest index d00697d..c823aed 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -21,7 +21,7 @@ "\n" "This and patch 6 are somehow connected but the division is not clear. I\n" "think at least dma map/unmap changes should be split into their own\n" - "patch. \n" + "patch.=20\n" "\n" "I recommend revisiting both patches 6 and 7. The htt layer can be quite\n" "tricky so better to have smaller logical changes to make it easier\n" @@ -32,23 +32,23 @@ "> @@ -409,6 +409,9 @@ int ath10k_htt_tx_start(struct ath10k_htt *htt)\n" "> \tif (htt->tx_mem_allocated)\n" "> \t\treturn 0;\n" - "> \n" + "> =20\n" "> +\tif (ar->is_high_latency)\n" "> +\t\treturn 0;\n" "> +\n" - "> \tret = ath10k_htt_tx_alloc_buf(htt);\n" + "> \tret =3D ath10k_htt_tx_alloc_buf(htt);\n" "> \tif (ret)\n" "> \t\tgoto free_idr_pending_tx;\n" "> @@ -445,7 +448,8 @@ void ath10k_htt_tx_destroy(struct ath10k_htt *htt)\n" "> \t\treturn;\n" - "> \n" + "> =20\n" "> \tath10k_htt_tx_free_cont_txbuf(htt);\n" "> -\tath10k_htt_tx_free_txq(htt);\n" "> +\tif (!htt->ar->is_high_latency)\n" "> +\t\tath10k_htt_tx_free_txq(htt);\n" "> \tath10k_htt_tx_free_cont_frag_desc(htt);\n" "> \tath10k_htt_tx_free_txdone_fifo(htt);\n" - "> \thtt->tx_mem_allocated = false;\n" + "> \thtt->tx_mem_allocated =3D false;\n" "\n" "These two don't look symmetric. You prevent calling these functions:\n" "\n" @@ -64,11 +64,7 @@ "ath10k_htt_tx_free_cont_frag_desc(htt);\n" "ath10k_htt_tx_free_txdone_fifo(htt);\n" "\n" - "-- \n" - "Kalle Valo\n" - "_______________________________________________\n" - "ath10k mailing list\n" - "ath10k@lists.infradead.org\n" - http://lists.infradead.org/mailman/listinfo/ath10k + "--=20\n" + Kalle Valo= -411963aa2e53457ddc12210b8bba99a11d1c2c2e5ac193e7fa63bcdaddfc5fb8 +bb7cfec4b5949b3e359198552f592205b699bf9c1cd6e848f0ff9d86e8562a2f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.