From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: Cyril Bur <cyrilbur@gmail.com>, Michael Tritz <mtritz@us.ibm.com>,
skiboot@lists.ozlabs.org, openbmc@lists.ozlabs.org,
Joel Stanley <joel@jms.id.au>,
Sam Mendoza-Jonas <sam@mendozajonas.com>,
Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Subject: Re: [Skiboot] [PATCH v4] pflash option to retrieve PNOR partition flags
Date: Mon, 26 Jun 2017 18:41:21 +1000 [thread overview]
Message-ID: <87fuenw37y.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1498089208.1181.3.camel@gmail.com>
Cyril Bur <cyrilbur@gmail.com> writes:
> On Tue, 2017-06-20 at 22:49 -0500, Michael Tritz wrote:
>> This commit extends pflash with an option to retrieve and print
>> information for a particular partition, including the content from
>> "pflash -i" and a verbose list of set miscellaneous flags. -i option
>> is also updated to print a short list of flags in addition to the
>> ECC flag, with one character per flag. A test of the new option is
>> included in libflash/test.
>
> I wonder if we should bikeshed the layout of print_partition_detail(),
> I'm absolutely not the person to review that kind of thing.
>
> I think it makes more sense for the changes to the libffs interface to
> be a separate patch.
I don't have a problem taking it as one patch, at least then we merge in
a user at the same time
--
Stewart Smith
OPAL Architect, IBM.
next prev parent reply other threads:[~2017-06-26 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 3:49 [PATCH v4] pflash option to retrieve PNOR partition flags Michael Tritz
2017-06-21 23:53 ` Cyril Bur
2017-06-26 8:41 ` Stewart Smith [this message]
2017-06-26 8:46 ` [Skiboot] " Stewart Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuenw37y.fsf@linux.vnet.ibm.com \
--to=stewart@linux.vnet.ibm.com \
--cc=cyrilbur@gmail.com \
--cc=joel@jms.id.au \
--cc=mtritz@us.ibm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=sam@mendozajonas.com \
--cc=sjitindarsingh@gmail.com \
--cc=skiboot@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.