From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFHMN-0004Cc-I2 for qemu-devel@nongnu.org; Mon, 29 May 2017 05:53:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFHMM-0005Sn-KK for qemu-devel@nongnu.org; Mon, 29 May 2017 05:53:11 -0400 From: Markus Armbruster References: <20170525163851.8047-1-berrange@redhat.com> <20170525163851.8047-20-berrange@redhat.com> <1acec55c-fd89-ee9d-0082-372a6e967036@redhat.com> <20170526140242.GK24484@redhat.com> Date: Mon, 29 May 2017 11:53:01 +0200 In-Reply-To: <20170526140242.GK24484@redhat.com> (Daniel P. Berrange's message of "Fri, 26 May 2017 15:02:42 +0100") Message-ID: <87fufo6lc2.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v7 19/20] qcow2: report encryption specific image information List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Eric Blake , Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz "Daniel P. Berrange" writes: > On Thu, May 25, 2017 at 02:52:30PM -0500, Eric Blake wrote: >> On 05/25/2017 11:38 AM, Daniel P. Berrange wrote: >> > Currently 'qemu-img info' reports a simple "encrypted: yes" >> > field. This is not very useful now that qcow2 can support >> > multiple encryption formats. Users want to know which format >> > is in use and some data related to it. >> > >> > Wire up usage of the qcrypto_block_get_info() method so that >> > 'qemu-img info' can report about the encryption format >> > and parameters in use >> > >> >> > Signed-off-by: Daniel P. Berrange >> > --- >> > block/qcow2.c | 35 ++++++++++++++++++++++++++++++++++- >> > qapi/block-core.json | 24 +++++++++++++++++++++++- >> > 2 files changed, 57 insertions(+), 2 deletions(-) >> > >> > diff --git a/block/qcow2.c b/block/qcow2.c >> > index 38f9eb5..cb321a2 100644 >> > --- a/block/qcow2.c >> > +++ b/block/qcow2.c >> > @@ -3196,8 +3196,17 @@ static int qcow2_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) >> > static ImageInfoSpecific *qcow2_get_specific_info(BlockDriverState *bs) >> > { >> > BDRVQcow2State *s = bs->opaque; >> > - ImageInfoSpecific *spec_info = g_new(ImageInfoSpecific, 1); >> > + ImageInfoSpecific *spec_info; >> > + QCryptoBlockInfo *encrypt_info = NULL; >> > >> > + if (s->crypto != NULL) { >> > + encrypt_info = qcrypto_block_get_info(s->crypto, NULL); >> >> Worth using &error_abort instead of silently ignoring the error? Is an >> error even possible in our output visitor [adding Markus for reference]? > > In fact the qcrypto_block_get_info() will never return an error > right now as implemented. So I guess we could even just remove > the Error **errp parameter from that call Do you still need advice on QAPI from me here? [...]