From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v5 3/9] drm/i915: Drop AUX backlight enable check for backlight control Date: Wed, 10 May 2017 13:05:49 +0300 Message-ID: <87fugdni0y.fsf@intel.com> References: <20170504002836.120988-1-puthik@chromium.org> <20170504002836.120988-4-puthik@chromium.org> <1494062349.26187.26.camel@dk-H97M-D3H> <1494396010.12201.10.camel@dk-H97M-D3H> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1494396010.12201.10.camel@dk-H97M-D3H> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Pandiyan, Dhinakaran" , "puthik@chromium.org" Cc: "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAxMCBNYXkgMjAxNywgIlBhbmRpeWFuLCBEaGluYWthcmFuIiA8ZGhpbmFrYXJhbi5w YW5kaXlhbkBpbnRlbC5jb20+IHdyb3RlOgo+IE9uIFR1ZSwgMjAxNy0wNS0wOSBhdCAxNjozOSAt MDcwMCwgUHV0aGlrb3JuIFZvcmF2b290aXZhdCB3cm90ZToKPj4gPiBIb3cgaXMgYmFja2xpZ2h0 IGVuYWJsZWQgaW4gdGhpcyBjYXNlPwo+PiBVc2luZyBlRFAgQkxfRU5BQkxFIHBpbgo+Cj4KPiBT dXJlLCBidXQgSSBhbSBub3Qgc2VlaW5nIGhvdyB0aGlzIGZhbGxzIGJhY2sgdG8gb25lIG9mIHRo ZQo+IFtieHQsbHB0XV9lbmFibGVfYmFja2xpZ2h0KCkgZnVuY3Rpb25zIGluIGludGVsX3BhbmVs LmMuIEFwb2xvZ2llcyBpZiBJCj4gYW0gbWlzc2luZyBzb21ldGhpbmcgdmVyeSBvYnZpb3VzLgo+ Cj4gSWYgaW50ZWxfZHBfYXV4X2luaXRfYmFja2xpZ2h0X2Z1bmNzKCkgcmV0dXJuZWQgLUVOT0RF ViwgdGhlbiBvbmUgb2YgdGhlCj4gcGxhdGZvcm0gc3BlY2lmaWMgUFdNIGVuYWJsZSBjYWxsYmFj a3Mgd291bGQgYmUgY2FsbGVkLiBCdXQgaW4gdGhpcwo+IGNhc2UsIGRwX2F1eF9lbmFibGVfYmFj a2xpZ2h0KCkganVzdCByZXR1cm5zIHdpdGhvdXQgZG9pbmcgYW55dGhpbmcuCgpUaGUgZURQIEJM X0VOQUJMRSBwaW4gKGluIHRoZSBwaHlzaWNhbCBlRFAgY29ubmVjdG9yKSBpcyBjb250cm9sbGVk IGJ5CnRoZSBwYW5lbCBwb3dlciBzZXF1ZW5jZXIsIGluZGVwZW5kZW50IGZyb20gdGhlIFBXTSBj b250cm9sLiBTZWUKaW50ZWxfZWRwX2JhY2tsaWdodF8qIGZ1bmN0aW9ucyBpbiBpbnRlbF9kcC5j LgoKQlIsCkphbmkuCgoKPgo+Cj4gLURLCj4+IAo+PiAKPj4gT24gU2F0LCBNYXkgNiwgMjAxNyBh dCAxOjU5IEFNLCBQYW5kaXlhbiwgRGhpbmFrYXJhbgo+PiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBp bnRlbC5jb20+IHdyb3RlOgo+PiAgICAgICAgIE9uIFdlZCwgMjAxNy0wNS0wMyBhdCAxNzoyOCAt MDcwMCwgUHV0aGlrb3JuIFZvcmF2b290aXZhdAo+PiAgICAgICAgIHdyb3RlOgo+PiAgICAgICAg ID4gVGhlcmUgYXJlIHNvbWUgcGFuZWwgdGhhdAo+PiAgICAgICAgID4gKDEpIGRvZXMgbm90IHN1 cHBvcnQgZGlzcGxheSBiYWNrbGlnaHQgZW5hYmxlIHZpYSBBVVgKPj4gICAgICAgICA+ICgyKSBz dXBwb3J0IGRpc3BsYXkgYmFja2xpZ2h0IGFkanVzdG1lbnQgdmlhIEFVWAo+PiAgICAgICAgID4g KDMpIHN1cHBvcnQgZGlzcGxheSBiYWNrbGlnaHQgZW5hYmxlIHZpYSBlRFAgQkxfRU5BQkxFIHBp bgo+PiAgICAgICAgID4KPj4gICAgICAgICA+IFRoZSBjdXJyZW50IGRyaXZlciByZXF1aXJlZCB0 aGF0ICgxKSBtdXN0IGJlIHN1cHBvcnQgdG8KPj4gICAgICAgICBlbmFibGUgKDIpLgo+PiAgICAg ICAgID4gVGhpcyBwYXRjaCBkcm9wcyB0aGF0IHJlcXVpcmVtZW50Lgo+PiAgICAgICAgID4KPj4g ICAgICAgICA+IFNpZ25lZC1vZmYtYnk6IFB1dGhpa29ybiBWb3Jhdm9vdGl2YXQgPHB1dGhpa0Bj aHJvbWl1bS5vcmc+Cj4+ICAgICAgICAgPiAtLS0KPj4gICAgICAgICA+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMgfCA1ICsrKystCj4+ICAgICAgICAgPiAg MSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+PiAgICAgICAg ID4KPj4gICAgICAgICA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cF9hdXhfYmFja2xpZ2h0LmMKPj4gICAgICAgICBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RwX2F1eF9iYWNrbGlnaHQuYwo+PiAgICAgICAgID4gaW5kZXggYWQ4NTYwYzVmNjg5Li41Yjgz Yzk3Mzc2NDQgMTAwNjQ0Cj4+ICAgICAgICAgPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPj4gICAgICAgICA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwX2F1eF9iYWNrbGlnaHQuYwo+PiAgICAgICAgID4gQEAgLTI4LDYgKzI4 LDEwIEBAIHN0YXRpYyB2b2lkCj4+ICAgICAgICAgc2V0X2F1eF9iYWNrbGlnaHRfZW5hYmxlKHN0 cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIGJvb2wKPj4gICAgICAgICBlbmFibGUpCj4+ICAgICAg ICAgPiAgewo+PiAgICAgICAgID4gICAgICAgdWludDhfdCByZWdfdmFsID0gMDsKPj4gICAgICAg ICA+Cj4+ICAgICAgICAgPiArICAgICAgIC8qIEVhcmx5IHJldHVybiB3aGVuIGRpc3BsYXkgdXNl IG90aGVyIG1lY2hhbmlzbSB0bwo+PiAgICAgICAgIGVuYWJsZSBiYWNrbGlnaHQuICovCj4+ICAg ICAgICAgPiArICAgICBpZiAoIShpbnRlbF9kcC0+ZWRwX2RwY2RbMV0gJgo+PiAgICAgICAgIERQ X0VEUF9CQUNLTElHSFRfQVVYX0VOQUJMRV9DQVApKQo+PiAgICAgICAgID4gKyAgICAgICAgICAg ICByZXR1cm47Cj4+ICAgICAgICAgPiArCj4+ICAgICAgICAgCj4+ICAgICAgICAgSG93IGlzIGJh Y2tsaWdodCBlbmFibGVkIGluIHRoaXMgY2FzZT8KPj4gICAgICAgICAKPj4gICAgICAgICAtREsK Pj4gICAgICAgICAKPj4gICAgICAgICA+ICAgICAgIGlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50 ZWxfZHAtPmF1eCwKPj4gICAgICAgICBEUF9FRFBfRElTUExBWV9DT05UUk9MX1JFR0lTVEVSLAo+ PiAgICAgICAgID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICZyZWdfdmFsKSA8IDApIHsK Pj4gICAgICAgICA+ICAgICAgICAgICAgICAgRFJNX0RFQlVHX0tNUygiRmFpbGVkIHRvIHJlYWQg RFBDRCByZWdpc3RlciAweAo+PiAgICAgICAgICV4XG4iLAo+PiAgICAgICAgID4gQEAgLTE2NCw3 ICsxNjgsNiBAQAo+PiAgICAgICAgIGludGVsX2RwX2F1eF9kaXNwbGF5X2NvbnRyb2xfY2FwYWJs ZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yCj4+ICAgICAgICAgKmNvbm5lY3RvcikKPj4gICAgICAg ICA+ICAgICAgICAqIHRoZSBwYW5lbCBjYW4gc3VwcG9ydCBiYWNrbGlnaHQgY29udHJvbCBvdmVy IHRoZQo+PiAgICAgICAgIGF1eCBjaGFubmVsCj4+ICAgICAgICAgPiAgICAgICAgKi8KPj4gICAg ICAgICA+ICAgICAgIGlmICgoaW50ZWxfZHAtPmVkcF9kcGNkWzFdICYKPj4gICAgICAgICBEUF9F RFBfVENPTl9CQUNLTElHSFRfQURKVVNUTUVOVF9DQVApICYmCj4+ICAgICAgICAgPiAtICAgICAg ICAgKGludGVsX2RwLT5lZHBfZHBjZFsxXSAmCj4+ICAgICAgICAgRFBfRURQX0JBQ0tMSUdIVF9B VVhfRU5BQkxFX0NBUCkgJiYKPj4gICAgICAgICA+ICAgICAgICAgICAoaW50ZWxfZHAtPmVkcF9k cGNkWzJdICYKPj4gICAgICAgICBEUF9FRFBfQkFDS0xJR0hUX0JSSUdIVE5FU1NfQVVYX1NFVF9D QVApKSB7Cj4+ICAgICAgICAgPiAgICAgICAgICAgICAgIERSTV9ERUJVR19LTVMoIkFVWCBCYWNr bGlnaHQgQ29udHJvbAo+PiAgICAgICAgIFN1cHBvcnRlZCFcbiIpOwo+PiAgICAgICAgID4gICAg ICAgICAgICAgICByZXR1cm4gdHJ1ZTsKPj4gICAgICAgICAKPj4gICAgICAgICAKPj4gCj4+IAo+ PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBJbnRl bC1nZnggbWFpbGluZyBsaXN0Cj4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4g aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK PgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK