From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anton Volkov <arvolkov@inbox.ru>,
borntraeger@de.ibm.com, kraxel@redhat.com, agraf@suse.de,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw: dead code removal
Date: Tue, 21 Mar 2017 12:56:56 +0100 [thread overview]
Message-ID: <87fui6onav.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <73e35c44-eda8-318c-77a3-0a7d42704dba@redhat.com> (Paolo Bonzini's message of "Tue, 21 Mar 2017 12:22:01 +0100")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 21/03/2017 10:37, Markus Armbruster wrote:
>> Four related changes, really:
>>
>> 1. HDACodecDeviceClass method exit()
>> 2. VirtIOCCWDeviceClass method exit()
>> 3. DeviceClass method exit()
>> 4. SCLPEventClass method exit()
>>
>> Regarding 3: method exit() needs to go. Your patch shows there are only
>> a few remaining users. Please convert them to unrealize().
>
> But that should be a separate patch anyway, so this patch should be good
> as is, shouldn't it?
Separate, yes, but I'd do it first. Of course that's a matter of taste.
next prev parent reply other threads:[~2017-03-21 11:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 18:00 [Qemu-devel] [PATCH] hw: dead code removal Anton Volkov
2017-03-21 8:28 ` Cornelia Huck
2017-03-21 8:50 ` Frederic Konrad
2017-03-21 9:37 ` Markus Armbruster
2017-03-21 11:22 ` Paolo Bonzini
2017-03-21 11:56 ` Markus Armbruster [this message]
2017-03-21 12:05 ` Thomas Huth
2017-03-21 12:48 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fui6onav.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=agraf@suse.de \
--cc=arvolkov@inbox.ru \
--cc=borntraeger@de.ibm.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.